fix: Single-use and Expire-by virtual cards regression by nkdengineer · Pull Request #81957 · Expensify/App

nkdengineer · 2026-02-10T10:10:52Z

Explanation of Change

fix: Single-use and Expire-by virtual cards regression

Fixed Issues

$ #81949
#81945
PROPOSAL:

Tests

Expensify Card - Set expiry date is still enabled after disabling it from confirm page #81949

Precondition:

Workspace is set up with Expensify card feature.

Go to workspace settings > Expensify Card.
Click Issue card.
Select assignee, virtual card and reach "Set expiry options" step.
Enable Set expiry date.
Click Confirm.
Complete the rest of the details and reach confirm page.
On confirm page, click Expiration date.
Disable Set expiry date.
Click Confirm.
Verify that the Expiration date disappears

Expensify Card- RHP does not proceed to next page after entering limit amount & pressing Enter #81945

Precondition:

Workspace is set up with Expensify card feature.

Go to workspace settings > Expensify Card.
Click Issue card.
Select assignee, virtual card and reach "Choose a limit type" step.
Click on Limit amount field and enter a limit.
Hit Enter.
Verify that the user go to the next step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-10.at.17.03.54.mov

Screen.Recording.2026-02-10.at.23.05.38.mov

… page

codecov · 2026-02-10T10:20:18Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...workspace/expensifyCard/issueNew/LimitTypeStep.tsx	`0.00% <ø> (ø)`
src/components/ValuePicker/ValueSelectorModal.tsx	`0.00% <0.00%> (ø)`
src/components/ValuePicker/index.tsx	`0.00% <0.00%> (ø)`
...ce/expensifyCard/issueNew/SetExpiryOptionsStep.tsx	`0.00% <0.00%> (ø)`
src/components/ValuePicker/ValueSelectionList.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

github-actions · 2026-02-10T10:28:38Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

nkdengineer · 2026-02-10T12:28:03Z

Looks like we have a critical bug where the date picker isn't shown, so I can't test #81949

Screen.Recording.2026-02-10.at.19.26.56.mov

lakchote · 2026-02-10T13:38:14Z

Looks like we have a critical bug where the date picker isn't shown, so I can't test #81949

@nkdengineer did you find the culprit of the date picker bug?

Isn't it introduced by the recent changes made to the virtual cards flow?

nkdengineer · 2026-02-10T13:42:33Z

Isn't it introduced by the recent changes made to the virtual cards flow?

No, it's happening for all date picker.

nkdengineer · 2026-02-10T13:49:12Z

@nkdengineer did you find the culprit of the date picker bug?

@lakchote It comes from this PR. It's a bad change that created an empty PressableWithoutFeedback instead of wrapping it with the View component. Then onPress event is never fired.

App/src/components/TextInput/BaseTextInput/implementation/index.tsx

Lines 317 to 327 in b2679d9

    
           <PressableWithoutFeedback 
        
               role={CONST.ROLE.PRESENTATION} 
        
               onPress={onPress} 
        
               tabIndex={-1} 
        
               accessible={false} 
        
               accessibilityElementsHidden 
        
               importantForAccessibility="no" 
        
               aria-hidden 
        
               style={[StyleSheet.absoluteFillObject]} 
        
               sentryLabel={sentryLabel} 
        
           />

lakchote · 2026-02-10T14:15:42Z

It comes from this PR. It's a bad change that created an empty PressableWithoutFeedback instead of wrapping it with the View component. Then onPress event is never fired.

cc @marufsharifi

melvin-bot · 2026-02-10T16:06:24Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marufsharifi · 2026-02-10T16:15:07Z

It comes from this PR. It's a bad change that created an empty PressableWithoutFeedback instead of wrapping it with the View component. Then onPress event is never fired.

cc @marufsharifi

@nkdengineer, is right, i reverted that part, it got solved.

m-natarajan · 2026-02-10T17:03:39Z

Unable to reproduce the date picker issue , Chrome / v9.3.16-5

Screen.Recording.2026-02-10.at.6.57.16.PM.mp4

dukenv0307 · 2026-02-11T03:40:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-11.at.10.39.17.mov

Android: mWeb Chrome

Screen.Recording.2026-02-11.at.10.37.37.mov

iOS: HybridApp

Screen.Recording.2026-02-11.at.10.40.21.mov

iOS: mWeb Safari

Screen.Recording.2026-02-11.at.10.36.53.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-11.at.10.32.39.mov

dukenv0307

LGTM

joekaufmanexpensify

Fixing bugs from WN project

lakchote

LGTM

github-actions · 2026-02-11T16:58:12Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T17:03:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81957.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-eddf27e-c84ed63408786622722d39194ea8bfa7fcbc3ff0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-eddf27e-45fc56ea0b0435daad9274a71e514e3b76757883/index.html

Web 🕸️
https://81957.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-11T17:05:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-12T15:49:13Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-13T18:49:55Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Set expiry date is still enabled after disabling it from confirm…

fb3d92b

… page

melvin-bot bot assigned nkdengineer Feb 10, 2026

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix/81949

a11e04c

nkdengineer marked this pull request as ready for review February 10, 2026 16:06

nkdengineer requested review from a team as code owners February 10, 2026 16:06

melvin-bot bot requested review from dukenv0307 and joekaufmanexpensify and removed request for a team February 10, 2026 16:06

dukenv0307 approved these changes Feb 11, 2026

View reviewed changes

melvin-bot bot requested a review from lakchote February 11, 2026 03:41

joekaufmanexpensify approved these changes Feb 11, 2026

View reviewed changes

lakchote approved these changes Feb 11, 2026

View reviewed changes

lakchote merged commit eddf27e into Expensify:main Feb 11, 2026
33 checks passed

OSBotify mentioned this pull request Feb 12, 2026

Deploy Checklist: New Expensify 2026-02-12 #82262

Closed

lakchote mentioned this pull request Mar 6, 2026

Expensify Card- RHP does not proceed to next page after entering limit amount & pressing Enter #81945

Closed

7 tasks

nkdengineer mentioned this pull request Mar 9, 2026

[Due for payment 2026-02-23] Single-use & Expire-by Virtual Expensify Cards #77672

Closed

Conversation

nkdengineer commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 10, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

This comment has been minimized.

nkdengineer commented Feb 10, 2026

Uh oh!

lakchote commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Feb 10, 2026

Uh oh!

nkdengineer commented Feb 10, 2026

Uh oh!

lakchote commented Feb 10, 2026

Uh oh!

melvin-bot bot commented Feb 10, 2026

Uh oh!

marufsharifi commented Feb 10, 2026

Uh oh!

m-natarajan commented Feb 10, 2026

Uh oh!

dukenv0307 commented Feb 11, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

OSBotify commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nkdengineer commented Feb 10, 2026 •

edited

Loading

codecov bot commented Feb 10, 2026 •

edited by github-actions bot

Loading

lakchote commented Feb 10, 2026 •

edited

Loading