[No QA] Update Global-Reimbursement-Canada.md#82037
Conversation
added to FAQ section for adding a zero for Canadian routing numbers
| 2. Click **Add deposit-only bank account**. | ||
| 3. Enter personal bank details. | ||
|
|
||
| ## If routing numbers for Canadian bank accounts are 8 digits, why does Expensify require 9 digits? |
There was a problem hiding this comment.
Structural violation: This FAQ entry is placed after the closing </div> tag, which means it's outside the document structure. Move this content to appear before line 108 (before the </div> tag) to keep all content within the proper document container.
docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Canada.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## If routing numbers for Canadian bank accounts are 8 digits, why does Expensify require 9 digits? | ||
|
|
||
| * The 9-digit requirement is for electronic fund transfers. |
There was a problem hiding this comment.
Readability violation: Using bullet points for a sequential explanation is less clear than plain text. Since these two points work together to form a complete answer (not independent facts), consider combining them into 1-2 sentences of plain text: "Expensify requires 9 digits for electronic fund transfers. To convert your 8-digit Canadian routing number, add a zero at the beginning."
docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Canada.md
Outdated
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR adds a helpful FAQ entry to clarify the 9-digit routing number requirement for Canadian bank accounts. The addition is relevant and addresses a common user confusion point. However, there are several areas where the content could be improved for clarity, consistency, and AI readiness. Scores Summary
Key FindingsIssues:
Positive aspects:
RecommendationsHigh Priority:
Suggested improvement: Change the heading to something like 'Why do I need to add a zero to my 8-digit Canadian routing number?' and expand the explanation to mention that Canadian bank routing numbers are typically 8 digits, but Expensify requires 9 digits to process electronic fund transfers. Include an example. Files Reviewed
VerdictThe documentation change is helpful but needs refinement for optimal clarity and user experience. Recommend revisions before merging to ensure consistency with HelpDot quality standards. |
|
A preview of your ExpensifyHelp changes have been deployed to https://b984a95c.helpdot.pages.dev ⚡️ Updated articles: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Hey @brianlee-expensify you should be able to merge this now yourself! I can't merge bc I was the last pusher |
|
@stephanieelliott gotcha, but i also cannot approve and merge since i created the PR 😂 - adding @kadiealexander as the additional approver here! |
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.3.28-0 🚀
|
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.3.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
added to FAQ section for adding a zero for Canadian routing numbers
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/598537
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari