[No QA] Update Concierge-Basics.md#82052
Conversation
| - Create or edit expenses | ||
| - Submit, approve, reimburse, or export reports | ||
| - Schedule a call with a human (when available) | ||
| - Proactively reach out to you in a New Expensify workspace #admins room assist when company card, business bank account, or accounting integration connections break |
There was a problem hiding this comment.
Readability violation: This sentence has multiple clarity and grammar issues:
- Grammar error: "room assist" should be "room to assist"
- Unclear structure: The phrase "in a New Expensify workspace #admins room" is confusing - consider "in your workspace's #admins room"
- Awkward flow: The entire sentence is difficult to parse
Suggested rewrite: "- Notify you in your workspace's #admins room when company cards, business bank accounts, or accounting integration connections break"
This version is clearer, more concise, and easier to scan.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single line to the Concierge Basics documentation to describe a new proactive notification feature. The change expands the "What can Concierge do?" section with information about automated alerts for workspace admins when critical connections break. Scores Summary
Key FindingsCritical Issues:
Specific Problems:
Positive Aspects:
RecommendationsPriority 1 - Must Fix: Priority 2 - Should Consider:
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://1ab684e7.helpdot.pages.dev ⚡️ Updated articles: |
|
@Christinadobrzyn adding you as an approver because merging is blocked due to, |
|
🚀 Deployed to staging by https://github.com/Christinadobrzyn in version: 9.3.25-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀
|
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/590858
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari