Remove unnecessary call openWorkspaceMembersPage in WorkspaceCompanyCardsPage.tsx#82055
Conversation
…and update related function
…ls in openPolicyCompanyCardsFeed call
|
@fedirjh I don't think the failing test is related, try merging main? |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Is this ready to review Fedi? |
…related function calls to simplify API usage.
emailList to openPolicyCompanyCardsFeed and remove extra openWorkspaceMembersPage callopenWorkspaceMembersPage in WorkspaceCompanyCardsPage.tsx
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-12.at.03.19.36.movAndroid: mWeb ChromeScreen.Recording.2026-02-12.at.03.15.37.moviOS: HybridAppScreen.Recording.2026-02-12.at.03.18.45.moviOS: mWeb SafariScreen.Recording.2026-02-12.at.03.14.21.movMacOS: Chrome / SafariScreen.Recording.2026-02-12.at.03.13.21.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9555ec4d48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chrispader
left a comment
There was a problem hiding this comment.
LGTM! Let's remove the unnecessary API call 👍🏼
openWorkspaceMembersPage in WorkspaceCompanyCardsPage.tsxopenWorkspaceMembersPage in WorkspaceCompanyCardsPage.tsx
|
@fedirjh some failing checks. |
|
@fedirjh conflicts here, just so we're ready to merge once web-e deploys. 🥳 |
openWorkspaceMembersPage in WorkspaceCompanyCardsPage.tsxopenWorkspaceMembersPage in WorkspaceCompanyCardsPage.tsx
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.24-1 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀
|
|
BZ checklist |
Explanation of Change
The Company Cards page previously made two separate API calls when loading a card feed:
openWorkspaceMembersPage— to sync the policy's employee list (emails + roles)openPolicyCompanyCardsFeed— to get the card feed data (domain settings + cards)This PR removes the extra
openWorkspaceMembersPagecall introduced to cover the invite user during the assign card flow. It has been observed that the inviter flow is working as expected and is updating the frontend with the neededpersonalDetailsdata for the newly added user. Therefore, the separate call for syncing the employee list is no longer required, streamlining the loading process for the card feed.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/583683
PROPOSAL: https://github.com/Expensify/Expensify/issues/583683#issuecomment-3813238448
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
CleanShot.2026-02-11.at.19.17.26.mp4
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari