Revert "Fix: Remove accessible={false} blocking Appium automation"#82127
Revert "Fix: Remove accessible={false} blocking Appium automation"#82127situchan wants to merge 1 commit intoExpensify:mainfrom
Conversation
|
Going to trigger an Adhoc build of this PR to test/confirm whether it fixes both regressions. |
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d94520c0cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Show resolved
Hide resolved
|
It fixed for me. main: Screen.Recording.2026-02-11.at.8.10.17.PM.movadhoc build: Screen.Recording.2026-02-11.at.8.12.50.PM.mov |
|
I just checked again and the issue is already fixed on main. And consequently on staging too. |
Fixed.on.main.and.staging.mp4 |
|
I am still able to reproduce both issues on main and staging v9.3.17-1 If you see OP video in #82124, the bug is that |
|
@situchan I know. Could you send a video of you replicating the bug in staging v9.3.17-1? |
|
Here's staging vs production: Screen.Recording.2026-02-11.at.8.29.34.PM.mov |
|
Ooooh, I see what you mean. Odd that we would want |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Product review isn't required.
Explanation of Change
Reverts #78527
Fixed Issues
$ #82095
$ #82124
Tests
Follow test steps in above linked issues
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari