Skip to content

Revert "Refactor subscription size page to use useSubPage hook"#82136

Merged
arosiclair merged 1 commit intomainfrom
revert-80620-chore/refactor-subscription-size-to-use-usesubpage
Feb 11, 2026
Merged

Revert "Refactor subscription size page to use useSubPage hook"#82136
arosiclair merged 1 commit intomainfrom
revert-80620-chore/refactor-subscription-size-to-use-usesubpage

Conversation

@arosiclair
Copy link
Contributor

@arosiclair arosiclair commented Feb 11, 2026

Reverts #80620

$ #82096

@arosiclair arosiclair self-assigned this Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/ROUTES.ts 12.86% <0.00%> (+0.04%) ⬆️
...s/settings/Subscription/SubscriptionSize/index.tsx 0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes

@arosiclair arosiclair marked this pull request as ready for review February 11, 2026 14:51
@arosiclair arosiclair requested review from a team as code owners February 11, 2026 14:51
@melvin-bot melvin-bot bot requested review from heyjennahay and mollfpr and removed request for a team February 11, 2026 14:52
@melvin-bot
Copy link

melvin-bot bot commented Feb 11, 2026

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@arosiclair arosiclair merged commit 416bdf8 into main Feb 11, 2026
32 of 35 checks passed
@arosiclair arosiclair deleted the revert-80620-chore/refactor-subscription-size-to-use-usesubpage branch February 11, 2026 14:57
@melvin-bot
Copy link

melvin-bot bot commented Feb 11, 2026

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Feb 11, 2026
@arosiclair
Copy link
Contributor Author

arosiclair commented Feb 11, 2026

straight revert

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Feb 11, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f48d1958c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/settings/Subscription/SubscriptionSize/index.tsx
const onFinished = () => {
updateSubscriptionSize(subscriptionSizeFormDraft ? Number(subscriptionSizeFormDraft[INPUT_IDS.SUBSCRIPTION_SIZE]) : 0, privateSubscription?.userCount ?? 0);
Navigation.goBack(ROUTES.SETTINGS_SUBSCRIPTION_SETTINGS_DETAILS);
Navigation.goBack();
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep a fallback route when finishing subscription resize

Switching onFinished to Navigation.goBack() makes the save flow a no-op when this screen is opened directly (for example from a bookmarked/deep link URL) because goBack() returns early when there is no back stack (src/libs/Navigation/Navigation.ts, !canGoBack() branch). The previous goBack(ROUTES.SETTINGS_SUBSCRIPTION_SETTINGS_DETAILS) ensured users always land on subscription settings after saving, so this change can leave users stuck on the confirmation page after pressing Save.

Useful? React with 👍 / 👎.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 11, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Feb 11, 2026
@arosiclair @OSBotify
Merge pull request #82136 from Expensify/revert-80620-chore/refactor-…
1922387 
…subscription-size-to-use-usesubpage

Revert "Refactor subscription size page to use useSubPage hook"

(cherry picked from commit 416bdf8)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 11, 2026
@OSBotify OSBotify mentioned this pull request Feb 11, 2026
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Feb 11, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.17-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 12, 2026

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Feb 12, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Feb 13, 2026
@bernhardoj
Revert "Merge pull request Expensify#82136 from Expensify/revert-8062…
b5fe5dc 
…0-chore/refactor-subscription-size-to-use-usesubpage"

This reverts commit 416bdf8, reversing
changes made to c118dd9.
@OSBotify
Copy link
Contributor

OSBotify commented Feb 13, 2026

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify OSBotify mentioned this pull request Feb 19, 2026
Closed
41 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Feb 19, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.23-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 20, 2026

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@JS00001 JS00001 JS00001 approved these changes

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

@mollfpr mollfpr Awaiting requested review from mollfpr

Assignees

@arosiclair arosiclair

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arosiclair @OSBotify @JS00001