[No QA] Improve short delay before showing Concierge suggested response answer by jmusial · Pull Request #82154 · Expensify/App

jmusial · 2026-02-11T16:20:10Z

Explanation of Change

This PR refactors the way in which delayed response is processed in the app to make it more suitable for longer timeouts. It increases the response time to 4 seconds as well.

[No QA] added because this is just a refactor.

Fixed Issues

$ #81749
PROPOSAL:

Tests

Open a workspace in New Expensify with Concierge suggested responses enabled (beta)
Interact with Concierge until suggested response buttons appear
Click one of the suggested response buttons
After clicking a suggested response button, there should be a brief delay (~4 seconds) before Concierge's answer appears, to make the interaction feel more natural and conversational, as if Concierge is thinking before responding.

Expected

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-02-13.at.19.22.38.mov

codecov · 2026-02-11T16:27:15Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/hooks/usePendingConciergeResponse.ts	`100.00% <100.00%> (ø)`
src/libs/actions/Report/SuggestedFollowup.ts	`96.00% <100.00%> (+0.16%)`	⬆️
src/pages/inbox/report/ReportActionsView.tsx	`71.18% <100.00%> (+0.24%)`	⬆️
... and 6 files with indirect coverage changes

jmusial · 2026-02-13T18:24:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26e90ed5b3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-13T18:40:17Z

src/libs/actions/Report/SuggestedFollowup.ts

+            onyxMethod: Onyx.METHOD.SET,
+            key: `${ONYXKEYS.COLLECTION.PENDING_CONCIERGE_RESPONSE}${reportID}`,
+            value: {


Queue pending concierge responses instead of overwriting

Storing each delayed Concierge reply at a single key (pendingConciergeResponse_<reportID>) means a second pre-generated followup selected within the same 4s window replaces the first pending action. Because the hook re-subscribes on key changes, the first timer is cleared and only the most recent response is ever applied, so earlier optimistic Concierge replies can be silently dropped in reports where multiple followups are resolved quickly.

Useful? React with 👍 / 👎.

There should be only one follow up for the report in that 4s window.

melvin-bot · 2026-02-13T18:43:27Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26e90ed5b3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-13T19:02:44Z

src/hooks/usePendingConciergeResponse.ts

+        if (remaining < -STALE_THRESHOLD_MS) {
+            discardPendingConciergeAction(reportID);


Avoid discarding queued response after routine navigation

The stale guard drops pending responses whenever displayAfter is more than 10s old, but this path is also hit during normal navigation (not just app restarts): useEffect clears the timer on unmount, so if a user leaves the report and comes back after ~10s, the queued Concierge reply is discarded instead of shown. This regresses the delayed-response flow for active sessions and can make a selected follow-up appear to have no Concierge answer.

Useful? React with 👍 / 👎.

if a user leaves the report and comes back after ~10s, the queued Concierge reply is discarded instead of shown. This regresses the delayed-response flow for active sessions and can make a selected follow-up appear to have no Concierge answer.

Is this expected?

The optimistic follow up is later replaced by actual response that comes from Concierge on BE. I think that if the user comes back after 10 s it's ok to just wait for the actual one. What do you think @marcochavezf ?

jmusial · 2026-02-20T11:02:55Z

@mkhutornyi kind bump here :)

heyjennahay

Refactor. Product review not required

mkhutornyi · 2026-02-20T11:04:52Z

I was waiting for #82154 (comment)

jmusial · 2026-02-20T11:17:16Z

I was waiting for #82154 (comment)

Clearing is just a small part of the refactor, one that can be easily removed / updated. Not sure if that should hold the review wdyt ?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f960fcde10

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-20T15:58:26Z

src/libs/actions/Report/SuggestedFollowup.ts

+            onyxMethod: Onyx.METHOD.SET,
+            key: `${ONYXKEYS.COLLECTION.PENDING_CONCIERGE_RESPONSE}${reportID}`,
+            value: {


Preserve all pending Concierge replies per report

addOptimisticConciergeActionWithDelay() writes the delayed response with Onyx.METHOD.SET to a single PENDING_CONCIERGE_RESPONSE_<reportID> entry, so a second suggested-followup selected in the same report before the first 4s delay expires will overwrite the first pending action. In that case the hook can only apply the latest item, and the earlier optimistic Concierge reply is dropped instead of being shown, which is a user-visible regression when multiple unresolved followups are tapped in quick succession.

Useful? React with 👍 / 👎.

mkhutornyi · 2026-02-20T16:15:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-20.at.4.13.38.pm.mov

mkhutornyi · 2026-02-20T16:15:44Z

Please check bot reviews above

melvin-bot · 2026-02-20T16:27:31Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #81749 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

deetergp · 2026-02-21T23:17:28Z

I don't think there's anything here for @heyjennahay needs to review, so I'm going to go ahead and merge it.

github-actions · 2026-02-21T23:18:27Z

🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-21T23:21:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82154.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-97b8ca7-08338eb-dcfabce0c3332c6a8d570fd85d35a211b2ffac88/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-97b8ca7-08338eb-67ab6d4dd02b5bf2e1035bea9eddce420de8fb0b/index.html

Web 🕸️
https://82154.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-21T23:24:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-24T01:17:35Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-25T15:51:09Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add concierge pending response improvement poc

5af8b4e

melvin-bot bot assigned jmusial Feb 11, 2026

jmusial added 3 commits February 13, 2026 18:28

cleanup

840ebf0

refactor

178d253

update timeout to 4s

26e90ed

jmusial changed the title ~~Improve short delay before showing Concierge suggested response answer~~ [No QA] Improve short delay before showing Concierge suggested response answer Feb 13, 2026

chatgpt-codex-connector bot reviewed Feb 13, 2026

View reviewed changes

jmusial marked this pull request as ready for review February 13, 2026 18:43

jmusial requested review from a team as code owners February 13, 2026 18:43

melvin-bot bot requested review from heyjennahay and mkhutornyi February 13, 2026 18:43

melvin-bot bot removed request for a team February 13, 2026 18:43

chatgpt-codex-connector bot reviewed Feb 13, 2026

View reviewed changes

Merge branch 'main' into feat/improve-convierge-delayed-response

22166d9

Merge branch 'main' into feat/improve-convierge-delayed-response

f960fcd

heyjennahay reviewed Feb 20, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

mkhutornyi approved these changes Feb 20, 2026

View reviewed changes

melvin-bot bot requested a review from deetergp February 20, 2026 16:27

deetergp approved these changes Feb 21, 2026

View reviewed changes

deetergp merged commit 97b8ca7 into Expensify:main Feb 21, 2026
31 of 32 checks passed

jmusial mentioned this pull request Feb 23, 2026

[Due for payment 2026-03-04] Add a short delay before showing Concierge suggested response answer #81749

Closed

7 tasks

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

		if (remaining < -STALE_THRESHOLD_MS) {
		discardPendingConciergeAction(reportID);

Conversation

jmusial commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 11, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmusial Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial commented Feb 20, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Feb 20, 2026

Uh oh!

jmusial commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi commented Feb 20, 2026

Uh oh!

melvin-bot bot commented Feb 20, 2026

Uh oh!

deetergp commented Feb 21, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

OSBotify commented Feb 21, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

jmusial commented Feb 11, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited by github-actions bot

Loading

mkhutornyi Feb 15, 2026 •

edited

Loading

mkhutornyi commented Feb 20, 2026 •

edited

Loading