fix: Start all New Expensify users on Reports > Reports#82217
fix: Start all New Expensify users on Reports > Reports#82217marcaaron merged 9 commits intoExpensify:mainfrom
Conversation
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@daledah please address the comments, and fix the automated tests. |
Please add a QA test for this part of the OP. |
|
@daledah could provide an estimate time here please. |
|
I'll give an update today |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ChavdaSachin i updated |
|
@daledah it looks good, just address the recent comments and update the test videos to reflect updated tests in Author checklist. |
|
And please rename the PR title to |
|
Hi there - what else is needed to get this one over the finish line? |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Feels pretty good to me 👍 |
|
Functionally it's ready, but from code infra perspective waiting for @daledah to complete some tweaks. |
|
@ChavdaSachin i updated |
|
Let's try to get this one merged today if we can! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-26.at.11.15.14.AM.movAndroid: mWeb ChromeUploading Screen Recording 2026-02-26 at 11.21.55 AM.mov… iOS: HybridAppScreen.Recording.2026-02-26.at.11.26.36.AM.moviOS: mWeb SafariScreen.Recording.2026-02-26.at.11.29.01.AM.movMacOS: Chrome / SafariScreen.Recording.2026-02-26.at.10.48.13.AM.mov |
This comment was marked as resolved.
This comment was marked as resolved.
|
@shawnborton the last search query is being preserved even after logging out and login again(even for different account). cc. @daledah |
|
Yeah that is normal, right? We always remember where you left off last? |
|
Maybe @JmillsExpensify or @Expensify/design can confirm though. |
I'm honestly not sure. Do we do this even when you log out? I would definitely expect it to remember my spot if I was cruising around through the app, but personally would not expect it to remember if I logged out. |
@JS00001 has been working on this recently. Are we saving the last-used filters even after sign-out? |
|
@JmillsExpensify No I dont believe so, it would just be when logged in |
This comment was marked as resolved.
This comment was marked as resolved.
|
I don't think I am quite following - but it sounds like that's a separate bug that already exists on main? |
|
Testing on staging... I don't think it's anchoring to your last place on the Reports page per se, but rather re-setting you to the 2026-02-25_23-09-32.mp4I think that's probably as a result of the changes made in this issue and PR last year. I feel like that's in scope to unwind as part of this PR to change everyone to Reports > Reports, isn't it? |
|
Checking once more |
|
@ChavdaSachin i updated, please check again |
|
Looking in right now. |
|
🚧 @marcaaron has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Explanation of Change
Fixed Issues
$ #82007
PROPOSAL: #82007 (comment)
Tests
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari