Fix default ordering of data when switching between views and group-bys by mateuuszzzzz · Pull Request #82264 · Expensify/App

mateuuszzzzz · 2026-02-12T15:24:17Z

Explanation of Change

Previously, chart view defaults (groupBy, sortOrder) were computed outside the parser in getChartViewDefaults() and applied via Object.assign. This worked but was inconsistent with how other defaults (e.g. sortBy/sortOrder for groupBy changes) are handled, those live in the parser's updateDefaultValues.

This PR:

Moves chart view default logic into the parser's updateDefaultValues, when a non-table view is set, the parser derives default groupBy, sortBy, and sortOrder directly
Defaults sortOrder to asc for all non-table views with time-based groupBy (week, month, year, quarter). Nevertheless, it won't impact PieChart as it internally sorts data by group's absolute value to show pie slices in decreasing angle order. I.e. PieChart always ignores sort-order no matter if it's desc or asc.
Simplifies shouldResetSortOrder to trigger on any view or groupBy change, ensuring each context gets its correct default
Fixes token ordering in buildQueryStringFromFilterFormValues,groupBy/view now come before sortBy/sortOrder, which ensures correct parser defaults for UI-constructed queries

Fixed Issues

$ #82265
PROPOSAL:

Tests

Defaults for chart views (new behavior: all non-table views with time-based groupBy default to sortOrder:asc):

Type type:expense view:bar in Search — verify the results are sorted ascending
Type type:expense view:line in Search — verify the chart shows data ascending
Type type:expense view:bar groupBy:week — verify results are sorted ascending
Type type:expense view:bar groupBy:withdrawal-id — verify results are sorted descending (non-time groupBy keeps its natural default)

View transitions via SearchFiltersBar (quick selectors):
5. Type type:expense view:bar — verify sortOrder is asc, groupBy defaults to category, sortBy defaults to groupCategory
6. Switch to line view — verify sortOrder stays asc, groupBy stays category, sortBy stays groupCategory
7. Switch back to table view — verify sortOrder stays asc, sortBy stays groupCategory (groupBy:category persists)
8. In table view, manually set sortOrder to desc. Switch to bar view — verify sortOrder resets to asc (not inherited from table)
9. In table view, manually set sortOrder to asc. Switch to bar view — verify sortOrder stays asc

GroupBy transitions via SearchFiltersBar:
10. In bar view, change groupBy from category to week — verify sortOrder stays asc, sortBy changes to groupweek
11. Change groupBy to withdrawal-id — verify sortOrder changes to desc, sortBy changes to groupWithdrawn
12. Change groupBy back to month — verify sortOrder changes to asc, sortBy changes to groupmonth

View transitions via Advanced Search Filters:
13. Open Advanced Search Filters
14. Set view to line — verify sortOrder is asc, groupBy is month, sortBy is groupmonth
15. Change view to bar — verify sortOrder stays asc, groupBy stays month, sortBy stays groupmonth
16. Change view to table — verify sortOrder resets to desc, sortBy stays groupmonth

GroupBy transitions via Advanced Search Filters:
17. Set view to bar, groupBy to week — verify sortOrder is asc, sortBy is groupweek
18. Change groupBy to category — verify sortOrder is asc (category's natural default), sortBy changes to groupCategory
19. Change groupBy to withdrawal-id — verify sortOrder changes to desc, sortBy changes to groupWithdrawn

Explicit sortOrder is respected:
20. Type type:expense view:line sortOrder:desc — verify data is sorted descending (newest first), not overridden to asc
21. Type type:expense view:bar groupBy:week sortOrder:desc — verify data is sorted descending

Table view unchanged:
22. Type type:expense groupBy:week (no view, defaults to table) — verify sortOrder is desc
23. Type type:expense groupBy:category (table view) — verify sortOrder is asc (category's natural default, same as on main)

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…for line charts

…already handles it

mateuuszzzzz

I changed initial approach so now it resets sort order when we change group-by or view param.

…e that UI passes query params in valid order

codecov · 2026-02-18T12:54:02Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/SearchParser/searchParser.js	`83.10% <100.00%> (+0.07%)`	⬆️
src/libs/SearchQueryUtils.ts	`71.58% <100.00%> (+0.06%)`	⬆️
...ts/Search/SearchPageHeader/useSearchFiltersBar.tsx	`72.09% <0.00%> (+0.82%)`	⬆️
src/pages/Search/AdvancedSearchFilters.tsx	`0.00% <0.00%> (ø)`
... and 9 files with indirect coverage changes

mhawryluk

awesome!

src/libs/SearchQueryUtils.ts

melvin-bot · 2026-02-19T08:11:22Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9123ff4a6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/SearchQueryUtils.ts

src/pages/Search/AdvancedSearchFilters.tsx

joekaufmanexpensify

Good for product

ShridharGoel · 2026-02-23T15:16:50Z

src/libs/SearchQueryUtils.ts

+/**
+ * Determines whether sortOrder should be reset (not passed to query builder) when filters change.
+ * Line view uses sortOrder:asc for time-based groupBy, which differs from other views.
+ * When crossing the line/non-line boundary or changing groupBy within line view,


This might need an update, since it now resets on any view or groupBy change

github-actions · 2026-03-03T10:48:59Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-03T11:10:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82264.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a9a4648-b2bae8a-376725ccc79aaf156be87af27f0395e13a6755c7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a9a4648-b2bae8a-1b63489067625e3911313ab3c7cbbf988fc53967/index.html

Web 🕸️
https://82264.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mateuuszzzzz · 2026-03-04T11:36:40Z

I resolved the merge conflicts since there was a larger search refactor in the meantime.
@ShridharGoel, we discussed in the Slack group, it’s currently difficult to determine whether certain parameters were explicitly set by the user or if they come from the parser defaults, which limits us somewhat. This caused issue posted by Tom here: Fix default ordering of data when switching between views and group-bys #82264 (comment)
To fix this, I applied a workaround and we now reset sortBy whenever groupBy changes. I wanted to highlight this here so you’re aware of the change. Ideally, if this becomes a problem in the long term, we should reconsider our current UI search filters, but that’s outside the scope of this PR.

ShridharGoel · 2026-03-04T11:56:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.5.16.12.PM.mov

Screen.Recording.2026-03-04.at.5.14.33.PM.mov

Screen.Recording.2026-03-04.at.5.13.16.PM.mov

Screen.Recording.2026-03-04.at.5.09.01.PM.mov

ShridharGoel · 2026-03-04T12:15:49Z

Bug: resetSort becomes true even when user did not change view/grouping filters (but some other filter), so sortBy/sortOrder are dropped and go back to defaults.

Screen.Recording.2026-03-04.at.5.44.12.PM.mov

mateuuszzzzz · 2026-03-04T13:17:06Z

Bug: resetSort becomes true even when user did not change view/grouping filters (but some other filter), so sortBy/sortOrder are dropped and go back to defaults.

Fixed this one

ShridharGoel · 2026-03-04T13:24:37Z

Can we add a test to cover this in shouldResetSortOrder tests?

melvin-bot · 2026-03-04T13:24:52Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #82265 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mateuuszzzzz · 2026-03-04T13:26:22Z

Can we add a test to cover this in shouldResetSortOrder tests?

Agree! I'll do that shortly

Also I noticed failing jest tests: https://github.com/Expensify/App/actions/runs/22669907700/job/65711007591?pr=82264

It looks like it's not coming from our PR so I will merge latest main and hopefully it will fix the issue

src/libs/SearchParser/searchParser.js

src/libs/SearchParser/searchParser.peggy

src/libs/SearchParser/searchParser.js

src/libs/SearchParser/searchParser.peggy

tests/unit/SearchParserTest.ts

github-actions · 2026-03-05T16:07:40Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-05T16:10:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

stitesExpensify

Nice, looks great!

github-actions · 2026-03-05T16:14:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82264.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-af38435-4f7f7ed-bf646305d72912783145ab3ef089a1509859bb9e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-af38435-4f7f7ed-2531e3e28280e37c44624fc7675c94c51133c502/index.html

Web 🕸️
https://82264.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:14:09Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:43:22Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Move chart-specific default directly to parser and change sort order …

1d441a3

…for line charts

melvin-bot bot assigned mateuuszzzzz Feb 12, 2026

mateuuszzzzz added 2 commits February 12, 2026 16:45

Make sure we don't assign any default in application layer as parser …

5c999d2

…already handles it

Prevent ignoring parser default order

b7190e3

mateuuszzzzz commented Feb 17, 2026

View reviewed changes

mateuuszzzzz added 3 commits February 18, 2026 13:34

Move all logic from applyDefaults to updateDefaultValues and make sur…

7d615ee

…e that UI passes query params in valid order

Merge branch 'main' into parser-chart-defaults

7d0df82

Fix unit tests

5b99e2e

mateuuszzzzz added 2 commits February 18, 2026 13:54

Fix spellcheck

48cbe76

Fix cspell properly

d9123ff

mateuuszzzzz changed the title ~~Fix default ordering of data when view:line is used~~ Fix default ordering of data when switching between views and group-bys Feb 18, 2026

mhawryluk approved these changes Feb 18, 2026

View reviewed changes

src/libs/SearchQueryUtils.ts Outdated Show resolved Hide resolved

mateuuszzzzz marked this pull request as ready for review February 19, 2026 08:11

mateuuszzzzz requested review from a team as code owners February 19, 2026 08:11

melvin-bot bot requested a review from ShridharGoel February 19, 2026 08:11

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team February 19, 2026 08:11

chatgpt-codex-connector bot reviewed Feb 19, 2026

View reviewed changes

src/libs/SearchQueryUtils.ts Outdated Show resolved Hide resolved

src/pages/Search/AdvancedSearchFilters.tsx Outdated Show resolved Hide resolved

mateuuszzzzz added 3 commits February 19, 2026 10:06

Fix bug with stale sortBy and add unit test that checks this case

95f928a

Do not rely on values from previous render but from current JSON query

40dd83c

Use object instead of string arguments in shouldResetSortOrder

4c6ce7b

joekaufmanexpensify previously approved these changes Feb 19, 2026

View reviewed changes

Resolve conflicts

fdc52bc

mateuuszzzzz dismissed joekaufmanexpensify’s stale review via fdc52bc February 23, 2026 13:59

Merge branch 'main' into parser-chart-defaults

f176dff

ShridharGoel reviewed Feb 23, 2026

View reviewed changes

Resolve conflicts

a9a4648

Resolve conflicts

96f4f80

Fix resetSort bug

35a499f

ShridharGoel approved these changes Mar 4, 2026

View reviewed changes

melvin-bot bot requested a review from stitesExpensify March 4, 2026 13:25

mateuuszzzzz added 2 commits March 4, 2026 14:37

Merge branch 'main' into parser-chart-defaults

330a665

Add test that covers recent bug with sort reset

d03f36f

puneetlath requested changes Mar 4, 2026

View reviewed changes

mateuuszzzzz added 2 commits March 5, 2026 09:41

Address review

e38fee7

Merge branch 'main' into parser-chart-defaults

c13cadf

puneetlath approved these changes Mar 5, 2026

View reviewed changes

puneetlath merged commit af38435 into Expensify:main Mar 5, 2026
30 checks passed

stitesExpensify reviewed Mar 5, 2026

View reviewed changes

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

jponikarchuk mentioned this pull request Mar 9, 2026

Reports - Bar chart hides some category labels when multiple categories exist in reports #84537

Open

7 tasks

mateuuszzzzz mentioned this pull request Mar 16, 2026

[Insights] Ensure that search uses asc as the default sort order when view:line is combined with time-based group-by #82265

Open

Conversation

mateuuszzzzz commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mateuuszzzzz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 18, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mhawryluk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

mateuuszzzzz commented Mar 4, 2026

Uh oh!

ShridharGoel commented Mar 4, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateuuszzzzz commented Mar 4, 2026

Uh oh!

ShridharGoel commented Mar 4, 2026

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

mateuuszzzzz commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

mateuuszzzzz commented Feb 12, 2026 •

edited

Loading

mateuuszzzzz left a comment •

edited

Loading

codecov bot commented Feb 18, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Mar 4, 2026 •

edited

Loading