Skip to content

fix: the focus is not moved when activating the link#82299

Merged
grgia merged 4 commits intoExpensify:mainfrom
daledah:fix/77337-1
Mar 2, 2026
Merged

fix: the focus is not moved when activating the link#82299
grgia merged 4 commits intoExpensify:mainfrom
daledah:fix/77337-1

Conversation

@daledah
Copy link
Contributor

@daledah daledah commented Feb 12, 2026

Explanation of Change

Fixed Issues

$ #77337
PROPOSAL: #77337 (comment)

Tests

Precondition: The User should be logged in

  1. Using Android TalkBack or iOS VoiceOver, open the Expensify app
  2. Start the onboarding flow
  3. Swipe to one of the options and double-tap to activate
  4. Swipe to the 'Continue' button and double-tap to activate
  5. Swipe to the 'fix the errors' link and double-tap
  6. Note where the focus is moved.
  7. Verify that: When the link is activated, the focus should move immediately and directly to the first input field that requires correction, allowing the user to begin fixing the form without losing context.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot
Copy link

melvin-bot bot commented Feb 12, 2026

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@daledah daledah marked this pull request as ready for review February 12, 2026 18:24
@daledah daledah requested review from a team as code owners February 12, 2026 18:24
@melvin-bot melvin-bot bot requested review from Krishna2323 and trjExpensify and removed request for a team February 12, 2026 18:24
@melvin-bot
Copy link

melvin-bot bot commented Feb 12, 2026

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Feb 12, 2026

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 12, 2026 18:24
@daledah
Copy link
Contributor Author

daledah commented Feb 12, 2026

I tested it with Accessibility Inspector, but it doesn't seem to work with the expected results. I want to open PR so we can build our own ad hoc site, and I'll test it on a real device.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/Form/FormWrapper.tsx 80.00% <0.00%> (-1.64%) ⬇️
... and 10 files with indirect coverage changes

Copy link
Contributor

@trjExpensify trjExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessibility project PR. 👍

@Krishna2323
Copy link
Contributor

@grgia could we please trigger adhoc build for this? Thanks!

Copy link
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggered @Krishna2323 !

@github-actions
Copy link
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@Krishna2323
Copy link
Contributor

@daledah could you please provide updates here? Thanks!

@grgia
Copy link
Contributor

grgia commented Feb 17, 2026

@Krishna2323 what update?

@Krishna2323
Copy link
Contributor

what update?

@daledah was waiting to test the solution on a real device: #82299 (comment)

@daledah
Copy link
Contributor Author

daledah commented Feb 19, 2026

image

i can't run adhoc on my ios device. It seems I've been deprived of something. I don't have an Android device, but I'll try to borrow one. In the meantime, @Krishna2323 could you test it on your end?

@daledah
Copy link
Contributor Author

daledah commented Feb 25, 2026

@Krishna2323 could you test it on your end?

@Krishna2323 friendly bump here

@Krishna2323
Copy link
Contributor

I'll check this today.

@Krishna2323
Copy link
Contributor

Testing...

@Krishna2323
Copy link
Contributor

@daledah the solutions seems to be working on my end:

WhatsApp.Video.Feb.27.2026.mp4

@daledah
Copy link
Contributor Author

daledah commented Feb 27, 2026

@daledah the solutions seems to be working on my end:

It seems to have worked with real devices. @Krishna2323 Are you using Android or iOS here? I haven't been able to borrow an Android device to test yet (I'll try to test it by the end of this week). If it's iOS, could you guide me on how to test it?

@Krishna2323
Copy link
Contributor

Are you using Android or iOS here

Tested on android

@daledah
Copy link
Contributor Author

daledah commented Feb 27, 2026

Tested on android

@Krishna2323 We just need to build with the PR code above, right?

@Krishna2323
Copy link
Contributor

@daledah I used the adhoc build for testing, could you please ask in open-source channel about the issue you're facing while attempting to install the adhoc build on iOS?

@daledah
Copy link
Contributor Author

daledah commented Feb 27, 2026

@Krishna2323 i'm asking here

@daledah
Copy link
Contributor Author

daledah commented Mar 2, 2026

no.audito.mov

@Krishna2323 It also works well on my real Android device. For iOS, I think we can ask QA for help.

@grgia
Copy link
Contributor

grgia commented Mar 2, 2026

Merging to have QA test

@grgia grgia merged commit 9285389 into Expensify:main Mar 2, 2026
28 of 29 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Krishna2323
Copy link
Contributor

Sorry for the confusion @grgia, this was not reviewed by me yet -- we were stuck at the testing phase. The code has several workarounds that shouldn't be kept in the app and needs a follow-up PR to clean up:

  1. Excessive type-safety bypasses: A single line has 4 eslint-disable rules (no-explicit-any, no-unsafe-assignment, no-unsafe-call, no-unsafe-member-access) plus another line disabling no-unsafe-argument. Instead of casting to any to call getNativeRef(), the InputComponentBaseProps type should be extended with an optional getNativeRef method so this can be done in a type-safe way.

  2. getNativeRef() is an undocumented internal React Native API: Relying on it is fragile. If React Native changes the internal implementation, this breaks silently. And when getNativeRef() doesn't exist (non-TextInput components), the fallback to focusInput likely doesn't work correctly — on native, AccessibilityInfo.sendAccessibilityEvent expects a native component handle, not an InputComponentBaseProps instance. On web, the moveAccessibilityFocus implementation calls ref.current.focus(), but the fallback focusInput is already the .current value of a ref (not a ref object itself), so ref.current would be undefined and the call becomes a no-op.

  3. InteractionManager.runAfterInteractions is unnecessary and deprecated: The comment says it ensures accessibility focus happens after the scroll animation completes, but scrollTo on line 132 already uses animated: false — there is no animation to wait for. The InteractionManager wrapper can be removed and the focus calls can remain synchronous.

  4. Missing eslint-disable justifications: The automated reviewer flagged all three eslint-disable comments as lacking justification (CONSISTENCY-5). This was requested to be addressed but wasn't before merge.

@daledah Could you please open a follow-up PR to address these issues?

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2026

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.28-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.30-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants