fix: the focus is not moved when activating the link#82299
fix: the focus is not moved when activating the link#82299grgia merged 4 commits intoExpensify:mainfrom
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 similar comment
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I tested it with Accessibility Inspector, but it doesn't seem to work with the expected results. I want to open PR so we can build our own ad hoc site, and I'll test it on a real device. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
trjExpensify
left a comment
There was a problem hiding this comment.
Accessibility project PR. 👍
|
@grgia could we please trigger adhoc build for this? Thanks! |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@daledah could you please provide updates here? Thanks! |
|
@Krishna2323 what update? |
@daledah was waiting to test the solution on a real device: #82299 (comment) |
i can't run adhoc on my ios device. It seems I've been deprived of something. I don't have an Android device, but I'll try to borrow one. In the meantime, @Krishna2323 could you test it on your end? |
@Krishna2323 friendly bump here |
|
I'll check this today. |
|
Testing... |
|
@daledah the solutions seems to be working on my end: WhatsApp.Video.Feb.27.2026.mp4 |
It seems to have worked with real devices. @Krishna2323 Are you using Android or iOS here? I haven't been able to borrow an Android device to test yet (I'll try to test it by the end of this week). If it's iOS, could you guide me on how to test it? |
Tested on android |
@Krishna2323 We just need to build with the PR code above, right? |
|
@daledah I used the adhoc build for testing, could you please ask in open-source channel about the issue you're facing while attempting to install the adhoc build on iOS? |
|
@Krishna2323 i'm asking here |
no.audito.mov@Krishna2323 It also works well on my real Android device. For iOS, I think we can ask QA for help. |
|
Merging to have QA test |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Sorry for the confusion @grgia, this was not reviewed by me yet -- we were stuck at the testing phase. The code has several workarounds that shouldn't be kept in the app and needs a follow-up PR to clean up:
@daledah Could you please open a follow-up PR to address these issues? |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.28-0 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|

Explanation of Change
Fixed Issues
$ #77337
PROPOSAL: #77337 (comment)
Tests
Precondition: The User should be logged in
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari