Fix ManualSendMessage metrics measurements by cristipaval · Pull Request #82321 · Expensify/App

cristipaval · 2026-02-12T20:49:55Z

The ManualSendMessage Sentry span was unreliable — it used a single global span ID, so any TextCommentFragment rendering (incoming messages, other pane re-renders) could end someone else's span. If the user scrolled up when sending, the message rendered off-screen, and the span could stay open for tens of seconds until something else accidentally closed it.

Explanation of Change

Each send-message span now includes the reportActionID in its ID (ManualSendMessage_), so only the fragment for that exact message can end it.
The span only starts when the chat is scrolled to the bottom. If you're scrolled up, we skip measurement entirely since we can't reliably detect when the message becomes visible.
Encapsulated ActionListContext value creation into the new useActionListContextValue hook, removing boilerplate from ReportScreen and SearchMoneyRequestReportPage. Added the scrollOffsetRef to it to help with the previous bullet.
Added cancelSpansByPrefix to clean up any orphaned send-message spans when navigating away from a report.

Fixed Issues

Part of #77176
PROPOSAL:

Tests

Tested that message sending works as expected.

1. Basic send message (scrolled to bottom)

Open any 1:1 chat (scrolled to bottom)
Send a message
Verify the message appears and chat stays scrolled to bottom
Verify no console errors

2. Send message while scrolled up

Open a chat with long history
Scroll up significantly (past the 250px threshold)
Send a message
Verify the message is sent successfully

3. Send message in RHP

Open a chat in the central pane
Open the same chat's thread or the chat itself in the RHP
Send a message from the RHP
Verify the message appears in both panes

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-16.at.20.16.10.mov

melvin-bot · 2026-02-12T20:50:35Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/inbox/report/comment/TextCommentFragment.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87b4c9717a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx

codecov · 2026-02-12T21:09:56Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useActionListContextValue.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/ReportScreen.tsx	`66.58% <100.00%> (-0.08%)`	⬇️
src/pages/inbox/ReportScreenContext.ts	`100.00% <100.00%> (ø)`
...pages/inbox/report/comment/TextCommentFragment.tsx	`71.79% <100.00%> (+2.35%)`	⬆️
src/hooks/useReportScrollManager/index.native.ts	`70.00% <83.33%> (ø)`
src/libs/actions/Report/index.ts	`61.34% <83.33%> (-0.02%)`	⬇️
src/pages/inbox/report/ReportActionsList.tsx	`75.74% <80.00%> (ø)`
src/pages/inbox/report/ReportFooter.tsx	`50.53% <0.00%> (ø)`
...equestReportView/MoneyRequestReportActionsList.tsx	`0.68% <0.00%> (-0.01%)`	⬇️
src/libs/telemetry/activeSpans.ts	`83.33% <50.00%> (-5.13%)`	⬇️
... and 3 more
... and 24 files with indirect coverage changes

…-metrics

src/pages/inbox/ReportScreen.tsx

mkhutornyi · 2026-02-13T14:43:02Z

I can help if this requires C+ review

cristipaval · 2026-02-13T14:49:56Z

@codex review
@claude review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5988646ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx

src/pages/inbox/ReportScreen.tsx

JmillsExpensify

No product review required on this one.

mkhutornyi · 2026-02-16T18:41:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-16.at.6.53.32.pm.mov

melvin-bot · 2026-02-16T19:05:15Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-16T19:05:18Z

🎯 @mkhutornyi, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #82589.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27219ed2c0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx

roryabraham

LGTM 👍🏼

tgolen · 2026-02-17T19:42:15Z

This PR picked up a conflict

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx

…-metrics Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

mountiny

LGTM, can you make sure to go through all the comments pending and address/ resolve them please

roryabraham · 2026-02-19T17:39:26Z

Seems like all the threads and addressed or resolved, so I'm going to go ahead and merge this.

OSBotify · 2026-02-19T17:46:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-19T19:04:27Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-19T19:08:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82321.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-096d945-1fe8027-9f4bae31f0820d093e22a2b27ecdb8bdf6cea757/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-096d945-1fe8027-8970d98e20f59e4f456faea2d2ac963d5f0195ce/index.html

Web 🕸️
https://82321.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-20T16:43:04Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-02-20T16:46:59Z

Hi @cristipaval. Does this PR apply only to Web?

tgolen · 2026-02-20T18:42:58Z

I don't believe it does, no. I think it applies to all platforms.

OSBotify · 2026-02-23T21:44:46Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

cristipaval added 5 commits February 12, 2026 22:01

Pass optimistic reportActionID to onSubmit

e049759

Measure only when the chat is scrolled to the bottom

8b06a71

Add reportActionID to the spanID

447467a

Cleanup orphaned spans

e79e241

Prettier

87b4c97

cristipaval requested review from mountiny, rlinoz and tgolen February 12, 2026 20:49

cristipaval self-assigned this Feb 12, 2026

cristipaval requested review from a team as code owners February 12, 2026 20:49

melvin-bot bot requested review from JmillsExpensify and MonilBhavsar and removed request for a team February 12, 2026 20:50

melvin-bot bot removed the request for review from a team February 12, 2026 20:50

github-actions bot reviewed Feb 12, 2026

View reviewed changes

src/pages/inbox/report/comment/TextCommentFragment.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx Outdated Show resolved Hide resolved

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx Outdated Show resolved Hide resolved

cristipaval added 3 commits February 13, 2026 16:30

Refactor the ActionListContext

506c5a5

send-message span into a separate useEffect

f756382

Merge remote-tracking branch 'origin/main' into fix-ManualSendMessage…

567daab

…-metrics

cristipaval commented Feb 13, 2026

View reviewed changes

src/pages/inbox/ReportScreen.tsx Show resolved Hide resolved

cristipaval requested a review from roryabraham February 13, 2026 14:44

Fix ts and lint checks

b598864

chatgpt-codex-connector bot reviewed Feb 13, 2026

View reviewed changes

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx Outdated Show resolved Hide resolved

src/pages/inbox/ReportScreen.tsx Show resolved Hide resolved

JmillsExpensify reviewed Feb 13, 2026

View reviewed changes

Cleanup spans in SearchMoneyRequestReportPage

9f5a0fd

mkhutornyi approved these changes Feb 16, 2026

View reviewed changes

melvin-bot bot requested a review from marcochavezf February 16, 2026 19:05

melvin-bot bot mentioned this pull request Feb 16, 2026

Payment issue for E/App PR#82321 #82589

Closed

chatgpt-codex-connector bot reviewed Feb 16, 2026

View reviewed changes

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx Outdated Show resolved Hide resolved

cristipaval mentioned this pull request Feb 16, 2026

[Metrics] Improve ManualSendMessage #77176

Open

roryabraham previously approved these changes Feb 17, 2026

View reviewed changes

tgolen requested changes Feb 17, 2026

View reviewed changes

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into fix-ManualSendMessage…

8ebbe4e

…-metrics Co-authored-by: Cursor <cursoragent@cursor.com>

cristipaval dismissed roryabraham’s stale review via 8ebbe4e February 18, 2026 22:34

cristipaval and others added 2 commits February 19, 2026 00:36

Add clarifying comment for pre-generated reportActionID

d8716a8

Co-authored-by: Cursor <cursoragent@cursor.com>

Rename reportActionID to optimisticReportActionID in composer

106a45d

Co-authored-by: Cursor <cursoragent@cursor.com>

cristipaval requested a review from tgolen February 19, 2026 10:48

tgolen approved these changes Feb 19, 2026

View reviewed changes

mountiny approved these changes Feb 19, 2026

View reviewed changes

roryabraham approved these changes Feb 19, 2026

View reviewed changes

roryabraham merged commit 096d945 into main Feb 19, 2026
35 of 37 checks passed

roryabraham deleted the fix-ManualSendMessage-metrics branch February 19, 2026 17:39

OSBotify mentioned this pull request Feb 20, 2026

Deploy Checklist: New Expensify 2026-02-20 #83077

Closed

67 tasks

Conversation

cristipaval commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. Basic send message (scrolled to bottom)

2. Send message while scrolled up

3. Send message in RHP

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mkhutornyi commented Feb 13, 2026

Uh oh!

cristipaval commented Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 16, 2026

Uh oh!

melvin-bot bot commented Feb 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen commented Feb 17, 2026

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Feb 19, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

IuliiaHerets commented Feb 20, 2026

Uh oh!

tgolen commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 23, 2026

cristipaval commented Feb 12, 2026 •

edited

Loading

codecov bot commented Feb 12, 2026 •

edited by github-actions bot

Loading

mkhutornyi commented Feb 16, 2026 •

edited

Loading