[No QA] Update Pay-Expenses.md#82337
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @muttmuure |
|
@muttmuure Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.md
Outdated
Show resolved
Hide resolved
|
|
||
| - If you're paying from a **personal bank account** and the payment is **under $100**, it will process in **one business day**. | ||
| - If you're paying from a **business bank account**, and your total withdrawals in the past 24 hours are **under $10,000**, the payment will also process in **one business day**. | ||
| If the payment is **under $100**, and your total withdrawals in the past 24 hours are **under $10,000**, the payment will process in **one business day**. Please note, this only applies to ACH payments within the US. |
There was a problem hiding this comment.
Formatting violation: Missing period at the end of the sentence. The sentence should end with proper punctuation.
There was a problem hiding this comment.
There is a period at the end of the sentence.
|
|
||
| - If you're paying from a **personal bank account** and the payment is **under $100**, it will process in **one business day**. | ||
| - If you're paying from a **business bank account**, and your total withdrawals in the past 24 hours are **under $10,000**, the payment will also process in **one business day**. | ||
| If the payment is **under $100**, and your total withdrawals in the past 24 hours are **under $10,000**, the payment will process in **one business day**. Please note, this only applies to ACH payments within the US. |
There was a problem hiding this comment.
Clarity violation: The combined conditions create ambiguity. Using "and" between "under $100" and "under $10,000" suggests BOTH conditions must be met, but based on the original text, these appear to be separate criteria (one for personal accounts, one for business accounts). Consider restructuring to clearly indicate when each condition applies, or clarify if both must be met simultaneously.
There was a problem hiding this comment.
The original text is wrong, it's correct that both conditions must be met.
|
|
||
| - If you're paying from a **personal bank account** and the payment is **under $100**, it will process in **one business day**. | ||
| - If you're paying from a **business bank account**, and your total withdrawals in the past 24 hours are **under $10,000**, the payment will also process in **one business day**. | ||
| If the payment is **under $100**, and your total withdrawals in the past 24 hours are **under $10,000**, the payment will process in **one business day**. Please note, this only applies to ACH payments within the US. |
There was a problem hiding this comment.
Style violation: "Please note," is unnecessarily formal. For Expensify's casual yet professional tone, consider rephrasing to something like "This only applies to US-based payments" or integrate this information more naturally into the sentence.
There was a problem hiding this comment.
Tweaked this!
HelpDot Documentation ReviewOverall AssessmentThis PR simplifies the explanation of rapid reimbursement criteria by consolidating two bullet points into a single statement and adding geographic scope clarification. The change is well-intentioned but introduces some clarity and accuracy issues that need to be addressed. Scores Summary
Key FindingsIssues Requiring Attention:
Positive Aspects:
RecommendationsPriority 1 (Must Address):
Suggested Revision: If you're paying from a **US-based bank account**, rapid processing (one business day) applies when:
- The payment is **under $100** (for personal bank accounts), OR
- Your total withdrawals in the past 24 hours are **under $10,000** (for business bank accounts)
Otherwise, standard bank transfer times apply, and the recipient will receive their funds within **4–5 business days**.Alternative Minimal Fix: For **US-based payments**, if the payment is **under $100** or your total withdrawals in the past 24 hours are **under $10,000**, the payment will process in **one business day**.
Otherwise, standard bank transfer times apply, and the recipient will receive their funds within **4–5 business days**.Final VerdictRequest Changes - While the geographic clarification is valuable, the current implementation reduces clarity and may confuse users about which criteria apply to their situation. The sentence structure needs revision to maintain the precision of the original documentation. Note: This is a summary assessment. The specific issues noted above should be addressed before merging. |
|
A preview of your ExpensifyHelp changes have been deployed to https://0dd09af0.helpdot.pages.dev ⚡️ Updated articles: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.22-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
Explanation of Change
Clarifies the rapid reimbursement criteria
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/599907
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari