[No QA] Remove Firebase Crashlytics, use Sentry instead by roryabraham · Pull Request #82370 · Expensify/App

roryabraham · 2026-02-13T07:54:06Z

Explanation of Change

Remove Firebase Crashlytics from the App, replacing it with Sentry (which is already integrated). This also updates the deploy checklist to link to Sentry instead of Firebase Crashlytics.

Firebase Analytics and the web SDK are kept for Google Tag Manager.

Deploy checklist:

Rename isFirebaseChecked to isSentryChecked
Replace Firebase Crashlytics links with release-specific Sentry URLs
Add previousTag parameter so the checklist links to the exact previous Sentry release
Add explanation that checking the previous release matters because mobile deploys use a phased rollout

App source:

Replace Crashlytics usage with Sentry equivalents in ErrorBoundary, testCrash, and platformSetup
Delete setCrashlyticsUserId (redundant with Sentry.setUser())
Remove @react-native-firebase/crashlytics dependency

Native build config:

Remove crashlytics Gradle plugins and dependencies
Delete firebase.json (only contained crashlytics config)
Remove firebase.json 1Password download steps and cache key references from CI workflows

Depends on: https://github.com/Expensify/Mobile-Expensify/pull/13849 (Mobile-Expensify crashlytics removal -- submodule bump needed after merge)

Fixed Issues

$

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A - [No QA]

PR Author Checklist

Screenshots/Videos

N/A - no UI changes

- Rename isFirebaseChecked to isSentryChecked throughout the checklist generation and parsing code - Replace Firebase Crashlytics links with release-specific Sentry URLs (current release filtered to staging environment, previous release without environment filter) - Add previousTag parameter to generateStagingDeployCashBodyAndAssignees so the checklist can link to the specific previous Sentry release - Add explanation that the previous release check matters because mobile deploys use a phased rollout and completing the checklist deploys the previous version to 100% of users - Update tests and rebuild GH Actions bundles Co-authored-by: Cursor <cursoragent@cursor.com>

- Replace Crashlytics error recording with Sentry.captureException in ErrorBoundary - Replace Crashlytics logging with no-op in Firebase/index.native.ts - Remove setCrashlyticsCollectionEnabled from platformSetup - Replace Crashlytics crash() with Sentry.nativeCrash() in testCrash - Remove setCrashlyticsUserId (Sentry.setUser already handles this) - Update TestCrash component to not depend on firebase.json config - Remove @react-native-firebase/crashlytics from package.json Co-authored-by: Cursor <cursoragent@cursor.com>

- Delete firebase.json (only contained crashlytics config) - Remove firebase-crashlytics-gradle classpath from android/build.gradle - Remove firebase-crashlytics dependency and plugin from android/app/build.gradle - Remove firebase.json 1Password download steps from deploy.yml - Remove firebase.json from Pods cache keys in deploy.yml and verifyHybridApp.yml Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot · 2026-02-13T07:54:12Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

melvin-bot · 2026-02-13T07:54:41Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

- Regenerate package-lock.json after removing @react-native-firebase/crashlytics - Remove patches/@react-native-firebase/crashlytics/ (patch-package patch no longer needed) - Note: ios/Podfile.lock and Mobile-Expensify/iOS/Podfile.lock will be updated by CI when pod install runs during the build. Local CocoaPods version (1.12.1) doesn't support visionos syntax in dependencies. Co-authored-by: Cursor <cursoragent@cursor.com>

pod install removes RNFBCrashlytics, FirebaseCrashlytics, and their transitive dependencies from the lockfile. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove the import and setCrashlyticsCollectionEnabled call that was missed in the initial Crashlytics removal. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham · 2026-02-13T08:26:31Z

@codex review

- Refactor generateStagingDeployCashBodyAndAssignees to use an options object for isSentryChecked, isGHStatusChecked, and previousTag (fixes @typescript-eslint/max-params violation) - Use early return in platformSetup/index.native.ts (fixes rulesdir/prefer-early-return) - Rename remaining isFirebaseChecked to isSentryChecked in test mock objects (fixes typecheck) - Rebuild GH Actions bundles Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1455e220b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/Firebase/index.native.ts

- Replace Firebase.log() no-op with Sentry.addBreadcrumb() in Firebase/index.native.ts (addresses review comment about losing navigation breadcrumbs) - Fix test: use version 1.0.2-2 in the version-bump test scenario (the Sentry URL must match the bumped version) - Rebuild GH Actions bundles from clean install Co-authored-by: Cursor <cursoragent@cursor.com>

- Firebase/index.native.ts: Replace crashlytics with Sentry.addBreadcrumb (this file was missed in the original commit) - testCrash/index.native.ts: Replace with Sentry.nativeCrash() - TestCrash/index.native.tsx: Remove firebase.json dependency - GithubUtilsTest.ts: Update Firebase verification constants to Sentry (these were missed in the earlier test update) Co-authored-by: Cursor <cursoragent@cursor.com>

codecov · 2026-02-13T09:17:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONFIG.ts	`83.87% <ø> (ø)`
src/Expensify.tsx	`83.24% <ø> (-0.35%)`	⬇️
src/components/TestCrash/index.native.tsx	`100.00% <100.00%> (ø)`
src/libs/Navigation/NavigationRoot.tsx	`78.02% <100.00%> (ø)`
src/components/ErrorBoundary/index.native.tsx	`40.00% <0.00%> (-2.86%)`	⬇️
src/libs/testCrash/index.native.ts	`50.00% <0.00%> (-16.67%)`	⬇️
src/setup/platformSetup/index.native.ts	`75.00% <66.66%> (-8.34%)`	⬇️
... and 6 files with indirect coverage changes

Delete the upload_dsyms and upload_dsyms_hybrid fastlane lanes that uploaded dSYM files to Firebase Crashlytics. Sentry handles debug symbol uploads via its own Xcode build phase and Gradle plugin. Also remove the "Upload DSYMs to Firebase for HybridApp" step from deploy.yml that called the now-deleted lane. Co-authored-by: Cursor <cursoragent@cursor.com>

Add environment=production to the previous release Sentry URL so deployers see only production crashes for the version being rolled out to 100% of users. Co-authored-by: Cursor <cursoragent@cursor.com>

The Firebase lib was a thin wrapper that only called Sentry.addBreadcrumb on native and was a no-op on web. Replace the single usage in NavigationRoot with a direct Sentry.addBreadcrumb call that works on all platforms, delete the now-unused Firebase lib, its dead web config, and the @firebase/app dependency. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham · 2026-02-20T18:03:15Z

@Julesssss ready for review

github-actions · 2026-02-20T18:48:25Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

Julesssss · 2026-02-20T20:11:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Julesssss · 2026-02-20T20:32:59Z

Seems like something still expects Firebase to exist in the iOS build. Mayyybe will be resolved and is an outdated run? I'll try a test build

fatal error: 'FirebaseCrashlytics/FirebaseCrashlytics.h' file not found

github-actions · 2026-02-20T20:34:43Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-20T20:38:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82370.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0fd785c-08338eb-d32373fa7d24fd22a04c4864da9bb755c990fa8b/index.html
The build for Android was skipped

Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2026-02-20T22:13:54Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-02-20T22:23:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-20T22:25:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82370.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1ea1155-08338eb-9a2a06cd250d39e325e1bc3e12dc37f40ccfa0e0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1ea1155-08338eb-d32373fa7d24fd22a04c4864da9bb755c990fa8b/index.html

Web 🕸️
https://82370.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-24T01:17:47Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-25T15:51:21Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

roryabraham and others added 3 commits February 12, 2026 23:49

roryabraham requested review from a team as code owners February 13, 2026 07:54

melvin-bot bot assigned roryabraham Feb 13, 2026

melvin-bot bot requested review from JmillsExpensify and Julesssss and removed request for a team February 13, 2026 07:54

melvin-bot bot removed the request for review from a team February 13, 2026 07:54

This comment was marked as resolved.

Sign in to view

Regenerate ios/Podfile.lock after removing Crashlytics

a340133

pod install removes RNFBCrashlytics, FirebaseCrashlytics, and their transitive dependencies from the lockfile. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham changed the title ~~[No QA] Remove Firebase Crashlytics, use Sentry instead~~ [WIP][No QA] Remove Firebase Crashlytics, use Sentry instead Feb 13, 2026

Remove FirebaseCrashlytics from MainApplication.kt

f1455e2

Remove the import and setCrashlyticsCollectionEnabled call that was missed in the initial Crashlytics removal. Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector bot reviewed Feb 13, 2026

View reviewed changes

src/libs/Firebase/index.native.ts Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Feb 13, 2026

Investigate workflow job failing on main: build (Expensify Dev, Debug, true) #82380

Closed

roryabraham and others added 2 commits February 13, 2026 01:03

github-actions bot mentioned this pull request Feb 13, 2026

Investigate workflow job failing on main: build (Expensify Dev, Debug, true) #82381

Closed

This comment was marked as resolved.

Sign in to view

roryabraham and others added 2 commits February 13, 2026 01:35

Scope previous release Sentry link to production environment

7fd3c93

Add environment=production to the previous release Sentry URL so deployers see only production crashes for the version being rolled out to 100% of users. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions bot mentioned this pull request Feb 13, 2026

Investigate workflow job failing on main: build (Expensify Dev, Debug, true) #82394

Closed

This comment was marked as outdated.

Sign in to view

neil-marcellini mentioned this pull request Feb 20, 2026

[No QA] Fix failureNotifier creating issues for non-main branch failures #83015

Merged

51 tasks

Merge branch 'main' into rory-remove-crashlytics

e849833

roryabraham changed the title ~~[WIP][HOLD Mobile-Expensify #13849][No QA] Remove Firebase Crashlytics, use Sentry instead~~ [WIP][No QA] Remove Firebase Crashlytics, use Sentry instead Feb 20, 2026

This comment was marked as outdated.

Sign in to view

roryabraham changed the title ~~[WIP][No QA] Remove Firebase Crashlytics, use Sentry instead~~ [No QA] Remove Firebase Crashlytics, use Sentry instead Feb 20, 2026

roryabraham requested a review from Julesssss February 20, 2026 18:03

This comment was marked as outdated.

Sign in to view

Julesssss approved these changes Feb 20, 2026

View reviewed changes

This comment was marked as off-topic.

Sign in to view

Merge remote-tracking branch 'origin/main' into rory-remove-crashlytics

2f1028a

roryabraham merged commit 1ea1155 into main Feb 20, 2026
39 checks passed

roryabraham deleted the rory-remove-crashlytics branch February 20, 2026 22:13

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

Conversation

roryabraham commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 13, 2026

Uh oh!

melvin-bot bot commented Feb 13, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

roryabraham commented Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Feb 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

roryabraham commented Feb 20, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Feb 20, 2026

Uh oh!

This comment was marked as off-topic.

Julesssss commented Feb 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Julesssss commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roryabraham commented Feb 13, 2026 •

edited

Loading

codecov bot commented Feb 13, 2026 •

edited by github-actions bot

Loading

Julesssss commented Feb 20, 2026 •

edited

Loading