[No QA] Update Set-Up-and-Manage-the-Expensify-Card.md

[zanyrenney]

We have rolled out additional features to the Expensify Card for Single use and expire by cards, so let's update our Set up and manage cards page for this

Explanation of Change

Fixed Issues

https://github.com/Expensify/Expensify/issues/567835

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

AI Readiness violation: This bullet point is outdated and doesn't reflect the new limit types. The line should be updated to match line 12 in the new version: "Individual Smart, Monthly, Fixed, or Single-use spend limits"

[github-actions]

Readability violation: "Capped monthly spend" is less clear than the new version "Limit renews monthly". The new version better explains the behavior from the user's perspective.

[github-actions]

Readability violation: "One-time cap, card closes when reached" is unclear. The new version "Spend until the limit is reached" is more direct and easier to understand.

[github-actions]

Readability violation: The nested bullet structure here makes the information harder to scan. Consider reformatting as a simple note or using a clearer structure without the "When enabled:" sub-section.

[github-actions]

Readability violation: These two sentences should be separated with a blank line or combined into a more cohesive paragraph. The abrupt transition between Single-use card behavior and expiration date behavior makes them harder to scan.

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR updates the Expensify Card documentation to reflect two new features: Single-use virtual cards and optional expiration dates for cards. The changes are focused on a single file and add important functionality documentation that enhances the completeness of the Expensify Card setup guide.

The documentation successfully introduces both features with clear explanations and integrates them into the existing card issuance workflow. The additions maintain consistency with the existing writing style and structure while providing practical context through use cases and automatic deactivation behaviors.

Scores Summary

• Readability: 8/10 - Clear, well-structured content with logical flow. Minor issues with nested bullet formatting and some sentences that could be more concise.
• AI Readiness: 9/10 - Excellent descriptive headings, proper context, and FAQ structure. The document maintains clear terminology and consistent hierarchy throughout.
• Style Compliance: 8.5/10 - Strong adherence to Expensify documentation standards with proper YAML metadata, appropriate terminology, and good FAQ integration. Minor inconsistencies in formatting patterns.

Key Findings

Strengths:

• Well-integrated feature additions that fit naturally into the existing workflow
• Clear use cases provided for Single-use cards (flights, vendor payments, event registration)
• Explicit timing information for expiration dates (12:00 AM start, 11:59 PM end, local time)
• Automatic deactivation behaviors clearly documented
• FAQ entries appropriately placed and answer predictable questions
• Consistent use of workspace terminology and proper button labels

Areas for Improvement:

• The nested bullet structure under step 7 uses inconsistent indentation patterns (mixture of 3-space and standard indentation)
• The sentence "When enabled: - Both dates are required" creates an awkward list-within-a-list structure
• Two separate paragraphs about automatic deactivation (lines 93-94) could potentially be consolidated or better positioned
• The limit type descriptions in step 5 gained trailing spaces on some lines, which while not critical, show minor formatting inconsistency

Technical Accuracy:

• The documentation correctly reflects the feature behavior based on the linked issue
• Time zone handling is appropriately specified (local time)
• Single-use card behavior is precisely defined (first successful authorization)
• The expiration date requirements are clear (both start and end dates required when enabled)

Recommendations

Priority Actions:

1. Review the nested bullet formatting under step 7 for consistency - consider using a cleaner list structure or reformatting as a note/callout box
2. Consider repositioning the automatic deactivation paragraphs (lines 93-94) - they might fit better within Step 3 or in a dedicated "Card Lifecycle" section

Enhancement Suggestions:

1. Add a screenshot or visual indicator showing the "Set expiration date" toggle in the UI
2. Consider adding a table summarizing the four limit types with their renewal/expiration behaviors for quick reference
3. The FAQ entries are good but could include an example scenario (e.g., "If you set a card to expire on March 31, 2026, the last transaction that can be made is at 11:59 PM local time on March 31")

Maintain:

• The clear, concise writing style
• The logical step-by-step structure
• The practical use case examples
• The FAQ placement and content

Files Reviewed

• /docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md: Updated with Single-use card type and expiration date features. Overall high quality with minor formatting considerations.

---

Overall Recommendation: Approve with minor suggestions. The documentation successfully introduces important new features with clarity and maintains consistency with existing standards. The suggested improvements are primarily formatting refinements that would enhance readability but do not block the PR from providing value to users.

[github-actions]

Readability violation: The sentence "If no expiration date is set, the card does not expire automatically" is somewhat confusing. Consider rephrasing to be more direct, such as: "Cards without an expiration date remain active until manually deactivated."

[github-actions]

AI Readiness violation: "A Single-use virtual card" - consider adding "Expensify Card" after "Single-use" for clarity and to reinforce the full feature name: "A Single-use Expensify Card automatically deactivates..."

[github-actions]

Readability violation: After adding the expiration date steps (7), this step number should be updated from "7" to "8" to maintain proper sequence.

[zanyrenney]

Gonna whip up a design issues to get the images updated cc @stephanieelliott

[github-actions]

Readability violation: "Both dates are required" could be more specific. Consider: "You must set both Start date and End date when expiration is enabled."

[github-actions]

Readability violation: The phrase "after its first successful authorization" uses technical jargon. Consider simpler language: "after the first transaction completes" to match 8th-grade reading level.

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://84614be7.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card

[stephanieelliott]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[OSBotify]

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

[zanyrenney]

@MelvinBot can you recreate this PR for me? I ended up reverting it but want it to be rebuilt.

[MelvinBot]

🤖 Recreated! I've opened a new PR with the same documentation changes from this PR:

#84862

The new PR includes all the original changes:

• Single-use virtual card limit type
• Optional expiration dates for virtual cards
• Updated limit type descriptions
• FAQ entries for Single-use cards and expiration behavior
• Automatic deactivation notes

Please mark it as "Ready for review" when it looks good.