[No QA] Update Login-Troubleshooting.md#82444
Conversation
broken link to OldDot article, updating to NewDot article equivalent
HelpDot Documentation ReviewOverall AssessmentThis PR updates a broken link reference from an outdated Expensify Classic article ("Two-Factor-Authentication-Overview") to the correct New Expensify article ("Two-Factor-Authentication"). The change is simple, focused, and appropriate for the context. The file maintains good overall quality with clear structure, helpful troubleshooting guidance, and user-focused content. Scores Summary
Key FindingsPositive Aspects:
Minor Observations:
Recommendations
Files Reviewed
Recommendation: APPROVE - This is a straightforward documentation fix that improves user experience by correcting a broken link reference. |
HelpDot Documentation ReviewI reviewed this PR for HelpDot documentation violations. The change on line 60 (updating the OldDot link to NewDot) is correct and follows HelpDot standards. However, I noticed the following issues in the broader file that are not part of this PR but should be addressed in future updates: Mixed OldDot/NewDot ReferencesThe document still contains several OldDot (expensify-classic) links that should eventually be migrated to NewDot equivalents:
Terminology Inconsistency
For this specific PR: ✅ No violations found in the changed line. The update from OldDot to NewDot is appropriate and follows HelpDot standards. |
|
A preview of your ExpensifyHelp changes have been deployed to https://80244c1e.helpdot.pages.dev ⚡️ Updated articles: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.22-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
broken link to OldDot article, updating to NewDot article equivalent
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari