fix:78356: Back button on Validate your bank account page does nothing by Eskalifer1 · Pull Request #82453 · Expensify/App

Eskalifer1 · 2026-02-13T19:15:10Z

Explanation of Change

This PR fixes a bug where the user tried to click the back button during the validation step and nothing happened.

Fixed Issues

Tests

Precondition:
Have disabled validation on account(Many unsuccessful attempts to pass validation when adding a bank account, resulting in the addition of this bank being blocked)

Go to WS > Expensify Cards
Click on Finish setup(Or, in some cases, it may be Issue new Card and select Add a new bank account, after which you will be automatically redirected to the validation step.)
Tap on the back button
Make sure navigation happens(app is not freezed and user can go back)

Verify that no errors appear in the JS console

Offline tests

No offline steps since realted to Bank account + data from BE

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

78356-android-native.mov

Android: mWeb Chrome

78356-android-web.mov

iOS: Native

78356-ios-native.mov

iOS: mWeb Safari

78356-ios-web.mov

MacOS: Chrome / Safari

78356-web.mov

melvin-bot · 2026-02-13T19:15:17Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1 · 2026-02-13T19:18:39Z

Hi @abzokhattab! PR is ready, lets discuss approach!

I used the main solution from the proposal because I think it really solves the problem, rather than just being a workaround as an alternative solution.

I reviewed the current logic, and it seems that achData.currentStep should be the same as the step that is displayed, but the parameter achData.currentStep itself is the main one, and it determines which step should be rendered, and it seems that this synchronization logic is located here:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

Lines 232 to 236 in c8097f3

    
           // Sync USDBankAccountStep state with achData.currentStep when backend data changes. 
        
           // This keeps state updated for legitimate step transitions while preventing flicker during transient re-renders. 
        
           if (!isNonUSDWorkspace && USDBankAccountStep !== null && achData?.currentStep && achData.currentStep !== USDBankAccountStep) { 
        
               setUSDBankAccountStep(achData.currentStep); 
        
           }

I also compared how it is used in other places when we set USDBankAccountStep ourselves, which is not equal to null, and noticed that in other places (in most cases) two functions are called at once, one sets the step, and the other changes Onyx. Here are the examples I found:

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 118 to 128 in c8097f3

    
               /** 
        
                * Prepares and redirects user to next step in the USD flow 
        
                */ 
        
               const prepareNextStep = useCallback( 
        
                   (setupType: ValueOf<typeof CONST.BANK_ACCOUNT.SETUP_TYPE>) => { 
        
                       setBankAccountSubStep(setupType); 
        
                       setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.COUNTRY); 
        
                       goToWithdrawalAccountSetupStep(CONST.BANK_ACCOUNT.STEP.COUNTRY); 
        
                   }, 
        
                   [setUSDBankAccountStep], 
        
               );

App/src/pages/ReimbursementAccount/USD/ConnectBankAccount/components/FinishChatCard.tsx

Lines 63 to 68 in c8097f3

    
           onPress={() => { 
        
               setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL).then(() => { 
        
                   setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.REQUESTOR); 
        
                   goToWithdrawalAccountSetupStep(CONST.BANK_ACCOUNT.STEP.REQUESTOR); 
        
               }); 
        
           }}

App/src/pages/ReimbursementAccount/USD/Country/index.tsx

Lines 21 to 28 in c8097f3

    
           const submit = () => { 
        
               if (!setUSDBankAccountStep) { 
        
                   return; 
        
               } 
        
               setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT); 
        
               goToWithdrawalAccountSetupStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT); 
        
           };

Although I agree with you, since this flow is linked and used in different cases, this fix is more risky. You can test it yourself and check if everything works for you. Perhaps, since it may affect a large part of the functionality, you may want to ask(cuz i have no idea who this can be :) ) someone who understands this functionality(maybe someone from external or internal developers) which fix is better to use, one (the main one from the proposal) or the other (the alternative one).

Let me know what you think about it. Thank you!

codecov · 2026-02-13T19:22:05Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../ReimbursementAccount/ReimbursementAccountPage.tsx	`0.00% <0.00%> (ø)`
... and 17 files with indirect coverage changes

abzokhattab · 2026-02-17T02:39:59Z

thanks .. i will be revewing later today

heyjennahay

Bug fix. Product review not required

abzokhattab · 2026-02-23T23:20:50Z

Looks good to me I tested the changes and I couldn't find any regression with this approach

adding the checklist

abzokhattab · 2026-02-24T05:11:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-24.at.06.09.54.mov

Android: mWeb Chrome

Screen.Recording.2026-02-24.at.06.07.50.mov

iOS: HybridApp

Screen.Recording.2026-02-24.at.06.08.44.mov

iOS: mWeb Safari

Screen.Recording.2026-02-24.at.06.07.03.mov

MacOS: Chrome / Safari

Before

Screen.Recording.2026-02-24.at.06.04.14.mov

After

Screen.Recording.2026-02-24.at.06.05.41.mov

abzokhattab

LGTM

abzokhattab · 2026-03-03T15:30:15Z

Kind reminder @AndrewGable

OSBotify · 2026-03-05T18:51:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-05T18:52:31Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-05T19:05:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82453.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-277fec8-3658edd-f4a310d696b7416ba66b2272ab0c2cf35cbe7aad/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-277fec8-3658edd-7e1542b1fc3faf2d38f7ce01e6199dcf460b0d37/index.html

Web 🕸️
https://82453.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:14:12Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:43:25Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Eskalifer1 added 2 commits February 13, 2026 21:02

fix:78356: Back button on Validate your bank account page does nothing

f5a4c51

remove console.log

972e246

Eskalifer1 requested review from a team as code owners February 13, 2026 19:15

melvin-bot bot assigned Eskalifer1 Feb 13, 2026

melvin-bot bot requested review from abzokhattab and heyjennahay and removed request for a team February 13, 2026 19:15

melvin-bot bot removed the request for review from a team February 13, 2026 19:15

Eskalifer1 changed the title ~~Fix/78356~~ fix:78356: Back button on Validate your bank account page does nothing Feb 18, 2026

heyjennahay reviewed Feb 20, 2026

View reviewed changes

abzokhattab approved these changes Feb 24, 2026

View reviewed changes

melvin-bot bot requested a review from AndrewGable February 24, 2026 05:11

AndrewGable approved these changes Mar 5, 2026

View reviewed changes

AndrewGable merged commit 277fec8 into Expensify:main Mar 5, 2026
32 of 33 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Conversation

Eskalifer1 commented Feb 13, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 13, 2026

Uh oh!

Eskalifer1 commented Feb 13, 2026

Uh oh!

codecov bot commented Feb 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

abzokhattab commented Feb 17, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Feb 24, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Mar 3, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Feb 13, 2026 •

edited by github-actions bot

Loading

abzokhattab commented Feb 23, 2026 •

edited

Loading