[HOLD] Move deleteReport to a separate file and use Onyx.connectWithoutView by bernhardoj · Pull Request #82481 · Expensify/App

bernhardoj · 2026-02-14T05:46:00Z

Explanation of Change

Fixed Issues

$ #73651
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Turn on Simulate failing network request
Create an expense for a new user that you never chatted with before
Since we turn on Simulate failing network request, the new report creating will fail
Press the error close button
Verify you are redirected to concierge

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-02-14T05:46:06Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-14T05:46:11Z

@brunovjk @MarioExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-02-14T05:47:11Z

I believe @eVoloshchak will review this

codecov · 2026-02-14T05:54:56Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Report/index.ts	`64.80% <ø> (-0.13%)`	⬇️
src/libs/actions/ReportActions.ts	`79.06% <ø> (ø)`
src/libs/actions/Report/DeleteReport.ts	`95.83% <95.83%> (ø)`
... and 14 files with indirect coverage changes

eVoloshchak · 2026-02-17T10:30:11Z

tests/unit/DeleteReportTest.ts

+import deleteReport from '@libs/actions/Report/DeleteReport';
+import CONST from '@src/CONST';
+import ONYXKEYS from '@src/ONYXKEYS';
+import {ReportAction} from '@src/types/onyx';


Suggested change

import {ReportAction} from '@src/types/onyx';

import type {ReportAction} from '@src/types/onyx';

MarioExpensify

Awesome, thank you!

MarioExpensify · 2026-02-18T11:09:23Z

Woops, @eVoloshchak can you proceed with reviewer checklist please?

eVoloshchak · 2026-02-18T11:28:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2026-02-18.at.12.53.08.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-02-18.at.12.50.00.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-18.at.12.45.24.mov

eVoloshchak · 2026-02-18T11:58:33Z

Turn on Simulate failing network request

Create an expense for a new user that you never chatted with before

Since we turn on Simulate failing network request, the new report creating will fail

Press the error close button

Verify you are redirected to concierge

@bernhardoj, this doesn't work on native (both iOS and Android), you're not redirected to Concierge.
Works properly on mWeb, though

Screen.Recording.2026-02-18.at.12.56.01.mov

Screen.Recording.2026-02-18.at.12.48.41.mov

MarioExpensify · 2026-02-18T12:11:34Z

@bernhardoj please address @eVoloshchak's comments, also, please don't forget to add proper screenshots/videos for each platform.

bernhardoj · 2026-02-18T15:30:45Z

this doesn't work on native (both iOS and Android)

Hmm, this is because inlineRequires, which imports the file/module when the function is called for the first time. So, when it's called for the first time, the report collection is empty.

eVoloshchak · 2026-02-18T23:19:42Z

Confirmed this is also the case on the current staging/main, doesn't seem related to this PR.
But I suspect we still would want to fix this to make sure behaviour is consistent across platforms? As part of this PR or as a follow-up?

bernhardoj · 2026-02-19T02:57:26Z

Confirmed this is also the case on the current staging/main

Hmm, I get redirected to concierge though in main.

bernhardoj · 2026-02-19T03:00:05Z

Asked in Slack, but no response yet.

eVoloshchak · 2026-02-19T14:28:46Z

Hmm, I get redirected to concierge though in main.

When building the native app? That's not the case for me, both when building locally or using a staging build (I verified using the Android build from #81778 (comment))

bernhardoj · 2026-02-24T05:50:11Z

I haven't tested the Android, but on iOS, it's not redirected

ios.mp4

eVoloshchak · 2026-02-24T09:44:17Z

I haven't tested the Android, but on iOS, it's not redirected

Same for me, no redirection on both native platforms (either production build or latest main in dev, same behavior). Which means it was not caused by this PR. I don't have access to the slack discussion, waiting on the decision

bernhardoj · 2026-02-24T13:45:53Z

Oh wait, I forgot whether I test it on main or on this branch 🤦. Let me retest again.

heyjennahay

Product review not required

bernhardoj · 2026-02-26T09:31:40Z

@eVoloshchak you're right. It's not being redirected either on main. Let me investigate deeper why for a bit.

bernhardoj · 2026-02-26T10:12:05Z

Hmm, looks like the isOptimisticReport is not set correctly.

bernhardoj · 2026-02-27T12:36:13Z

@eVoloshchak I found the bug. The isOptimisticReports is set correctly initially, but when one of these functions is called, even though we use MERGE, the previous metadata is replaced, so it's a react-native-onyx bug.

App/src/libs/actions/Report/index.ts

Lines 4931 to 4936 in 6ff8eea

    
           function updateLastVisitTime(reportID: string) { 
        
               if (!isValidReportIDFromPath(reportID)) { 
        
                   return; 
        
               } 
        
               Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {lastVisitTime: DateUtils.getDBTime()}); 
        
           }

App/src/libs/actions/Report/index.ts

Lines 1202 to 1210 in 6ff8eea

    
           onyxMethod: Onyx.METHOD.MERGE, 
        
           key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, 
        
           value: { 
        
               isLoadingInitialReportActions: true, 
        
               isLoadingOlderReportActions: false, 
        
               hasLoadingOlderReportActionsError: false, 
        
               isLoadingNewerReportActions: false, 
        
               hasLoadingNewerReportActionsError: false, 
        
           },

I've reported this in Slack. Should we continue with the PR or wait until the bug is fixed?

eVoloshchak · 2026-02-27T14:31:02Z

Should we continue with the PR or wait until the bug is fixed?

I think the most reliable way would be to put this on hold until it's fixed in react-native-onyx, as it's a refactor, changes are not user-facing and the issue is not critical

replace with connectWithoutView

e0c0dfc

bernhardoj requested review from a team as code owners February 14, 2026 05:46

melvin-bot bot assigned bernhardoj Feb 14, 2026

melvin-bot bot requested review from alitoshmatov and heyjennahay February 14, 2026 05:46

melvin-bot bot requested review from a team, MarioExpensify and brunovjk and removed request for a team February 14, 2026 05:46

bernhardoj added 2 commits February 14, 2026 13:48

lint

e9e6333

lint

d092763

bernhardoj added 2 commits February 14, 2026 14:20

prettier

59e41f1

add test

e681c5e

eVoloshchak suggested changes Feb 17, 2026

View reviewed changes

lint

37f7779

MarioExpensify approved these changes Feb 18, 2026

View reviewed changes

MarioExpensify removed the request for review from brunovjk February 18, 2026 11:09

MarioExpensify self-requested a review February 18, 2026 12:10

Merge branch 'main' into chore/73651-use-connect-without-view

e2219c7

heyjennahay reviewed Feb 25, 2026

View reviewed changes

bernhardoj added 2 commits February 26, 2026 18:24

Merge branch 'main' into chore/73651-use-connect-without-view

eb18bcf

Merge branch 'main' into chore/73651-use-connect-without-view

131434f

bernhardoj changed the title ~~Move deleteReport to a separate file and use Onyx.connectWithoutView~~ [HOLD] Move deleteReport to a separate file and use Onyx.connectWithoutView Feb 27, 2026

	import {ReportAction} from '@src/types/onyx';
	import type {ReportAction} from '@src/types/onyx';

Conversation

bernhardoj commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 14, 2026

Uh oh!

melvin-bot bot commented Feb 14, 2026

Uh oh!

bernhardoj commented Feb 14, 2026

Uh oh!

codecov bot commented Feb 14, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eVoloshchak Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MarioExpensify commented Feb 18, 2026

Uh oh!

eVoloshchak commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Feb 18, 2026

Uh oh!

MarioExpensify commented Feb 18, 2026

Uh oh!

bernhardoj commented Feb 18, 2026

Uh oh!

eVoloshchak commented Feb 18, 2026

Uh oh!

bernhardoj commented Feb 19, 2026

Uh oh!

bernhardoj commented Feb 19, 2026

Uh oh!

eVoloshchak commented Feb 19, 2026

Uh oh!

bernhardoj commented Feb 24, 2026

Uh oh!

eVoloshchak commented Feb 24, 2026

Uh oh!

bernhardoj commented Feb 24, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Feb 26, 2026

Uh oh!

bernhardoj commented Feb 26, 2026

Uh oh!

bernhardoj commented Feb 27, 2026

Uh oh!

eVoloshchak commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented Feb 14, 2026 •

edited

Loading

codecov bot commented Feb 14, 2026 •

edited by github-actions bot

Loading

eVoloshchak commented Feb 18, 2026 •

edited

Loading