Force full screen on Not Here page for invalid validate codes#82502
Merged
Gonals merged 4 commits intoExpensify:mainfrom Mar 5, 2026
Merged
Force full screen on Not Here page for invalid validate codes#82502Gonals merged 4 commits intoExpensify:mainfrom
Gonals merged 4 commits intoExpensify:mainfrom
Conversation
7 tasks
melvin-bot
bot
requested review from
joekaufmanexpensify
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <FullPageNotFoundView | ||
| testID="validate-code-not-found" | ||
| shouldShow={!isValidValidateCode(code)} | ||
| shouldForceFullScreen={!isValidValidateCode(code)} |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The expression !isValidValidateCode(code) is now duplicated on consecutive lines (for shouldShow and shouldForceFullScreen). Extract it to a local variable to keep a single source of truth and avoid the repeated function call.
const shouldShowNotFound = !isValidValidateCode(code);
// ...
<FullPageNotFoundView
testID="validate-code-not-found"
shouldShow={shouldShowNotFound}
shouldForceFullScreen={shouldShowNotFound}
shouldShowBackButton={shouldUseNarrowLayout}Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
There was a problem hiding this comment.
@MobileMage Creating a variable in this case makes sense, and it allows us to apply the suggestion to meet consistency rule
suneox
reviewed
Feb 19, 2026
| const signInHere = useCallback(() => signInWithValidateCode(accountID, code, preferredLocale), [accountID, code, preferredLocale]); | ||
| const {translate} = useLocalize(); | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
| const shouldShowNotFound = !isValidValidateCode(code); |
Contributor
There was a problem hiding this comment.
@MobileMage We need to fix eslint rule and update condition bellow
Suggested change
| const shouldShowNotFound = !isValidValidateCode(code); | |
| const isValidCode = isValidValidateCode(code); |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chrome
iOS: HybridAppiOS: mWeb Safari
MacOS: Chrome / Safari
|
suneox
approved these changes
Mar 2, 2026
Gonals
approved these changes
Mar 5, 2026
Contributor
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
92 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.32-0 🚀
|
7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When navigating to an invalid validate login URL (e.g.
/v/1/1), the "Not Here" page rendered byFullPageNotFoundViewdid not cover the full screen on wide layouts. The underlying page was visible behind it becauseshouldForceFullScreenwas not set, so theForceFullScreenViewwrapper did not applyposition: fixedwith an opaque background.This adds
shouldForceFullScreen={!isValidValidateCode(code)}to theFullPageNotFoundViewinValidateCodeModal, so whenever an invalid code triggers the error view, it also gets full-screen coverage with an opaque background that prevents content from showing through.Fixed Issues
$ #80731
PROPOSAL: #80731 (comment)
Tests
/v/1/1in the URL barOffline tests
N/A - This is a purely visual/layout fix with no network dependency.
QA Steps
staging.new.expensify.com/v/1/1PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
80731.mp4