Migrate ShareTab from useOptionsList to useFilteredOptions#82509
Merged
mountiny merged 14 commits intoExpensify:mainfrom Mar 18, 2026
Merged
Migrate ShareTab from useOptionsList to useFilteredOptions#82509mountiny merged 14 commits intoExpensify:mainfrom
mountiny merged 14 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
- Extract searchTerm?.trim() check to isSearching boolean constant - Skip sorting in search mode since all reports are returned anyway - Add comment explaining the sort optimization for search case
- Use optionsOrderBy (heap sort) instead of Array.sort for better efficiency - Add reportSortComparator to work with Report objects and privateIsArchivedMap - Heap sort is more efficient when limiting to top N reports
Remove unnecessary effectiveLimit variable and use direct conditional expression for cleaner code
Contributor
Author
|
@shubham1206agra the failed unit tests aren't related to this PR. I will try to merge main later. |
melvin-bot
bot
requested review from
shubham1206agra
and removed request for
a team
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Since optionsOrderBy already accepts a limit parameter and efficiently returns only the top N items using a heap, the explicit slice operation was unnecessary.
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
heyjennahay
reviewed
Mar 12, 2026
Contributor
heyjennahay
left a comment
heyjennahay
left a comment
There was a problem hiding this comment.
Product review not required
Contributor
Author
|
@shubham1206agra awaiting your review |
Contributor
Author
|
Can you review this PR? @shubham1206agra |
Contributor
|
@hoangzinh Yes, I will review this today. Can you please resolve conflicts? |
Contributor
Author
@shubham1206agra I resolved the conflicts |
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-03-18.at.6.02.40.PM.mov |
shubham1206agra
approved these changes
Mar 18, 2026
Contributor
|
@hoangzinh can you please resolve the conflicts? |
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR migrates ShareTab from
useOptionsListtouseFilteredOptionsand enhancescreateFilteredOptionListto properly handle search mode.Key Changes:
ShareTab Migration
useOptionsListwithuseFilteredOptionshookSearch Mode Optimization
maxRecentReportslimitHeap Sort Implementation
Array.sort()with heap sort for better efficiency when limiting to top N reports => Reduced from384msto333mswithmaxRecentReportsvalue is 500Fixed Issues
$ #82181
PROPOSAL:
Tests
Same as QA
Offline tests
Same as QA
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Native apps only:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-07.at.06.05.58.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-03-07.at.06.12.03.mov
iOS: mWeb Safari
MacOS: Chrome / Safari