[NoQA] Fallback to IOU action childReportID if the report data doesn't exist in the onyx yet by mollfpr · Pull Request #82535 · Expensify/App

mollfpr · 2026-02-16T05:39:19Z

Explanation of Change

We have an edge case when the soft deleted IOU action is exist in the Onyx from OpenReport API but the Search API doesn't attach the IOU action to the transaction, it will go to the flow creating optimistic transaction thread and using the IOU action from earlier OpenReport response, but it will return empty for the tranasction thread report here.

Ideally, if we have an IOU action with transaction thread it will not go this flow, but because the IOU action is soft deleted, the Search API exclude the IOU action to the transaction.

Fixed Issues

$ #81401
PROPOSAL:

Tests

Supportal to the customer account carterb@rescue.com and open the NewDot
Open the report Carter Expense to 2026-02-28
Go to Reports > Expenses page
Search for the transaction with merchant Lyft and amount $13.98 and click to open
Verify it will not showing the not found page and should open the transaction thread

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Tag me to QA this.

Supportal to the customer account carterb@rescue.com and open the NewDot
Open the report Carter Expense to 2026-02-28
Go to Reports > Expenses page
Search for the transaction with merchant Lyft and amount $13.98 and click to open
Verify it will not showing the not found page and should open the transaction thread

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… in the onyx yet

mollfpr · 2026-02-16T05:40:21Z

@codex review

codecov · 2026-02-16T05:45:02Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/SearchUIUtils.ts	`68.15% <100.00%> (+0.11%)`	⬆️
... and 20 files with indirect coverage changes

chatgpt-codex-connector · 2026-02-16T05:47:27Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-02-18T08:14:19Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good for product

src/libs/SearchUIUtils.ts

mountiny · 2026-02-23T17:11:56Z

@mollfpr lets get a C+ for a review here please

situchan · 2026-02-23T17:19:52Z

I can review

deetergp · 2026-02-23T17:58:53Z

Thanks for volunteering @situchan 👍

situchan · 2026-02-23T17:59:29Z

Perf tests failing btw

situchan · 2026-02-23T17:59:35Z

@codex review

chatgpt-codex-connector · 2026-02-23T18:20:30Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…d-transactionThread-reportID

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5de61ae1ff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

tests/unit/Search/SearchUIUtilsTest.ts

mountiny · 2026-02-25T23:31:03Z

@situchan ready

situchan · 2026-02-27T10:08:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector · 2026-02-27T10:24:12Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan

Code looking good and safe change.

But is there any step (even hardcoded) to reproduce and test?

mountiny

Looks good, thank you @mollfpr

mountiny · 2026-02-27T23:28:20Z

@deetergp all yours

melvin-bot · 2026-02-28T02:41:19Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

I am going to merge this to avoid conflicts and taking this much longer since c+ approved and this was ready on Friday already

github-actions · 2026-03-01T21:26:25Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-01T21:32:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82535.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3ad623d-39f6ce2-dc822c6f45aa1f84d81f3ae6196f07a4306afb28/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3ad623d-39f6ce2-5afeda3e9e95dc44f14dcf8311028e47894a4193/index.html

Web 🕸️
https://82535.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:02:02Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:16:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:07:11Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fallback to IOU action childReportID if the report data doesn't exist…

78f92b2

… in the onyx yet

mollfpr self-assigned this Feb 16, 2026

mollfpr added the InternalQA This pull request required internal QA label Feb 16, 2026

mollfpr removed the InternalQA This pull request required internal QA label Feb 18, 2026

mollfpr changed the title ~~Fallback to IOU action childReportID if the report data doesn't exist in the onyx yet~~ [NoQA] Fallback to IOU action childReportID if the report data doesn't exist in the onyx yet Feb 18, 2026

mollfpr requested a review from mountiny February 18, 2026 08:13

mollfpr marked this pull request as ready for review February 18, 2026 08:13

mollfpr requested review from a team as code owners February 18, 2026 08:13

melvin-bot bot requested review from deetergp and joekaufmanexpensify and removed request for a team February 18, 2026 08:13

joekaufmanexpensify previously approved these changes Feb 18, 2026

View reviewed changes

mountiny requested changes Feb 18, 2026

View reviewed changes

src/libs/SearchUIUtils.ts Show resolved Hide resolved

add test verify the childReportID fallback

51490ef

mollfpr dismissed joekaufmanexpensify’s stale review via 51490ef February 23, 2026 17:04

mollfpr requested a review from mountiny February 23, 2026 17:04

deetergp requested a review from situchan February 23, 2026 17:58

Merge branch 'main' of github.com:Expensify/App into mollfpr-undefine…

5de61ae

…d-transactionThread-reportID

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

tests/unit/Search/SearchUIUtilsTest.ts Outdated Show resolved Hide resolved

fixed failing test

bfb7d8a

situchan reviewed Feb 27, 2026

View reviewed changes

mountiny approved these changes Feb 27, 2026

View reviewed changes

situchan approved these changes Feb 28, 2026

View reviewed changes

melvin-bot bot requested a review from dangrous February 28, 2026 02:41

mountiny approved these changes Mar 1, 2026

View reviewed changes

mountiny merged commit 3ad623d into main Mar 1, 2026
32 checks passed

mountiny deleted the mollfpr-undefined-transactionThread-reportID branch March 1, 2026 21:07

github-actions bot mentioned this pull request Mar 1, 2026

[Due for payment 2026-03-11] [$125] Investigate workflow job failing on main: test / test (job 1) #83808

Closed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

melvin-bot bot mentioned this pull request Mar 4, 2026

[Due for payment 2026-03-11] Admin gets “Hmm..it's not here” error when trying to update expense #81401

Closed

7 tasks

Conversation

mollfpr commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mollfpr commented Feb 16, 2026

Uh oh!

codecov bot commented Feb 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot commented Feb 16, 2026

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented Feb 23, 2026

Uh oh!

situchan commented Feb 23, 2026

Uh oh!

deetergp commented Feb 23, 2026

Uh oh!

situchan commented Feb 23, 2026

Uh oh!

situchan commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mountiny commented Feb 25, 2026

Uh oh!

situchan commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Feb 27, 2026

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Feb 27, 2026

Uh oh!

melvin-bot bot commented Feb 28, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

mollfpr commented Feb 16, 2026 •

edited

Loading

codecov bot commented Feb 16, 2026 •

edited by github-actions bot

Loading

situchan commented Feb 27, 2026 •

edited

Loading