feat: Add back withdrawal status column to group-by:withdrawal#82597
Conversation
melvin-bot
bot
requested review from
jayeshmangwani
and removed request for
a team
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
joekaufmanexpensify
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/components/SelectionListWithSections/Search/WithdrawalIDListItemHeader.tsx
Outdated
Show resolved
Hide resolved
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4273aab341
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85b1ef791c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ck-withdrawal-status-column-to-group-by-withdrawal
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product 👍
…ck-withdrawal-status-column-to-group-by-withdrawal
|
@TaduJR, please ping once you’ve added the above changes. |
|
I was about to push. Heads up Thanks |
|
@TaduJR could you address the comments, then we should be good to merge this soon? |
|
@TaduJR , the PR works well. I just have a minor comment regarding the variable names. For example:
Please update all usages accordingly. |
…ck-withdrawal-status-column-to-group-by-withdrawal
|
Hmm, @TaduJR can we change the default position of the column? It should match the mockup |
|
It's already a default column. It's included in both GROUP_CUSTOM_COLUMNS.WITHDRAWAL_ID (toggleable in Columns panel) and GROUP_DEFAULT_COLUMNS.WITHDRAWAL_ID (visible by default): GROUP_DEFAULT_COLUMNS.WITHDRAWAL_ID: [
this.TABLE_COLUMNS.GROUP_BANK_ACCOUNT,
this.TABLE_COLUMNS.GROUP_WITHDRAWN,
this.TABLE_COLUMNS.GROUP_WITHDRAWAL_STATUS, // on by default
this.TABLE_COLUMNS.GROUP_WITHDRAWAL_ID,
this.TABLE_COLUMNS.GROUP_EXPENSES,
this.TABLE_COLUMNS.GROUP_TOTAL,
], |
|
Sorry, I meant the positioning, updated my comment |
|
Once thats updated, this lgtm! |
|
Done @JS00001 |
|
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.24-1 🚀
|
|
Hi @TaduJR. QA team is blocked from using Expensify Card settlements in at least two different states (Pending, Cleared, or Failed) and cannot test this PR. |
|
Cleared and failed badges look good on staging. |
|
@joekaufmanexpensify can you try grouping by withdrawal id, but not using the reconciliation view? |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀
|
|
@JS00001 still nothing 
|
|
Not sure but sounds like BE bug, it might be BE pending settlements aren't being returned in the search results at all. |
|
cc @JS00001 thoughts? |
|
@joekaufmanexpensify I'm working on a BE fix for this, I agree its a bug |
6 participants
Explanation of Change
This PR adds the withdrawal status column to the wide (desktop) table layout when grouping by Withdrawal ID on the Reconciliation page, and updates status badges across the reports page to be centered and content-hugging.
Fixed Issues
$ #81417
PROPOSAL:
Tests
Prerequisites:
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.https://expensify.slack.com/archives/C01GTK53T8Q/p1771420161471369
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari