fix: Deleted expense still visible on chart by mhawryluk · Pull Request #82637 · Expensify/App

mhawryluk · 2026-02-17T10:51:41Z

Explanation of Change

After deleting an expense and going back to a bar chart, the chart would not update if the results were loading when running the effect handling search in the Search component. This PR updates the logic retrying search to cover this scenario.

Fixed Issues

$ #81110
PROPOSAL: N/A

Tests

skip native iOS mobile as there is no back button/gesture in this scenario

Create two manual expenses with date from different weeks.
Navigate to "Reports" > "Expenses"
Tap on "Filters" > "Group by" > "Week"
Apply filters.
Tap on "View" > "Bar"
Tap on any of the expenses on chart.
Long tap on expense preview and select it. (on narrow view. in wide view select the checkbox)
Tap on dropdown menu and delete the expense.
Use device's back button. (Rather quickly after deleting).
Verify the chart is updated and does not display the deleted expense.
Test again but with a saved search.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2026-02-17.o.11.17.46.mov

Android: mWeb Chrome

Nagranie.z.ekranu.2026-02-17.o.12.50.07.mov

iOS: Native

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-02-17.at.12.39.33.mp4

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-02-17.o.12.35.02.mov

codecov · 2026-02-17T10:58:27Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/index.tsx	`26.90% <50.00%> (-0.03%)`	⬇️
... and 174 files with indirect coverage changes

mateuuszzzzz · 2026-02-17T11:09:10Z

src/components/Search/index.tsx

            return;
        }

        // If count is already present, the latest response already contains totals and we can skip the re-query.


Let's update this comment to take changes from this PR into consideration

mhawryluk · 2026-02-17T11:28:32Z

Alternatively we could omit skipping handleSearch in the previous useEffect, but I guess this logic is there for a reason and we do sometimes show the total and chart together. cc: @ShridharGoel

App/src/components/Search/index.tsx

Lines 563 to 568 in f56783e

    
           if (searchResults?.search?.isLoading) { 
        
               if (shouldCalculateTotals && searchResults?.search?.count === undefined) { 
        
                   shouldRetrySearchWithTotalsRef.current = true; 
        
               } 
        
               return; 
        
           }

melvin-bot · 2026-02-17T11:54:05Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-17T11:54:10Z

@ChavdaSachin @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mhawryluk · 2026-02-17T11:55:46Z

@ShridharGoel could you review this one? it's chart related + it modifies your recent contribution

github-actions · 2026-02-17T11:56:59Z

src/components/Search/index.tsx

        if (searchResults?.search?.isLoading) {
-            if (shouldCalculateTotals && searchResults?.search?.count === undefined) {
-                shouldRetrySearchWithTotalsRef.current = true;
+            if (validGroupBy || (shouldCalculateTotals && searchResults?.search?.count === undefined)) {


❌ CONSISTENCY-5 (docs)

validGroupBy is now referenced inside this useEffect but is not included in the dependency array. The existing eslint-disable-next-line react-hooks/exhaustive-deps (at line 573) suppresses the warning, but the justification comment only explains the omission of isFocused — it does not explain why validGroupBy is intentionally omitted. This means the effect could read a stale validGroupBy value if the group-by selection changes while isLoading is true.

Either add validGroupBy to the dependency array, or update the justification comment to explain why it is safe to omit (e.g., the ref-based retry in the second effect handles changes).

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

if validGroupBy changes the queryJson will too, but okay

mhawryluk · 2026-02-17T11:57:51Z

@trjExpensify could we run an ad-hoc build for this PR and ask for a retest? just to make sure this fixes the linked issue, as the modified code fragments were introduced after the issue was raised

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46913847b7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-17T12:04:16Z

src/components/Search/index.tsx


-        shouldRetrySearchWithTotalsRef.current = false;
+        shouldRetrySearchWithTotalsOrGroupedRef.current = false;
        handleSearch({queryJSON, searchKey, offset, shouldCalculateTotals: true, prevReportsLength: filteredDataLength, isLoading: false});


Preserve totals flag when retrying grouped searches

This retry path now always calls handleSearch with shouldCalculateTotals: true, which overrides the value from useSearchShouldCalculateTotals for grouped queries. In the affected flow (for example, returning to a grouped chart while results are still loading), non-eligible searches that intentionally avoid totals aggregation are retried as totals queries, which can add unnecessary backend work and slower responses compared with the original search behavior.

Useful? React with 👍 / 👎.

ShridharGoel · 2026-02-17T12:10:45Z

Will start the review soon

ShridharGoel · 2026-02-17T16:59:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-17.at.10.20.44.PM.mov

github-actions · 2026-02-18T14:10:07Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-18T14:52:56Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-18T14:56:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82637.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a52b916-09da3e9-c7cedcd42615fe0f172530c4196b53e700065ef1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a52b916-09da3e9-36afbb556ceb441739af345b5fc7da8f7c812697/index.html

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-18T15:01:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-18T22:21:43Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:22:33Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:36:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

fix: Deleted expense still visible on chart

ee61823

melvin-bot bot assigned mhawryluk Feb 17, 2026

mateuuszzzzz reviewed Feb 17, 2026

View reviewed changes

Add comment

4691384

mateuuszzzzz approved these changes Feb 17, 2026

View reviewed changes

mhawryluk marked this pull request as ready for review February 17, 2026 11:53

mhawryluk requested review from a team as code owners February 17, 2026 11:53

melvin-bot bot requested review from heyjennahay and shubham1206agra and removed request for a team February 17, 2026 11:54

melvin-bot bot requested review from a team, ChavdaSachin and cristipaval and removed request for a team February 17, 2026 11:54

github-actions bot reviewed Feb 17, 2026

View reviewed changes

Add validGroupBy to dependency array

dc43ecc

chatgpt-codex-connector bot reviewed Feb 17, 2026

View reviewed changes

ShridharGoel approved these changes Feb 17, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

cristipaval approved these changes Feb 18, 2026

View reviewed changes

cristipaval merged commit a52b916 into Expensify:main Feb 18, 2026
31 of 32 checks passed

OSBotify mentioned this pull request Feb 18, 2026

Deploy Checklist: New Expensify 2026-02-18 #82863

Closed

76 tasks

melvin-bot bot mentioned this pull request Feb 19, 2026

[Due for payment 2026-02-26] Reports - Deleted expense is still visible on chart on "Bar" view mode. #81110

Closed

7 tasks

Conversation

mhawryluk commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mateuuszzzzz Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk commented Feb 17, 2026

Uh oh!

melvin-bot bot commented Feb 17, 2026

Uh oh!

melvin-bot bot commented Feb 17, 2026

Uh oh!

mhawryluk commented Feb 17, 2026

Uh oh!

github-actions bot Feb 17, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-5 (docs)

Uh oh!

mhawryluk Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk commented Feb 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Feb 17, 2026

Uh oh!

ShridharGoel commented Feb 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

This comment has been minimized.

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mhawryluk commented Feb 17, 2026 •

edited

Loading

codecov bot commented Feb 17, 2026 •

edited by github-actions bot

Loading