Perf: reduce LHN renderItem overhead with single-pass action lookup#82648
Conversation
…etrieval logic. Introduce new utility functions for finding last report actions and caching one-transaction thread report IDs.
…-reduce-sorting-overhead
…fety and code clarity. Updated function signatures to use optional parameters and refined comments for better understanding.
JKobrynski
left a comment
JKobrynski
left a comment
There was a problem hiding this comment.
+1 to Adam's suggestion, other than that code looks good!
src/libs/OptionsListUtils/index.ts
Outdated
| // Pre-compute the first visible IOU money request action (newest, since sorted descending) | ||
| const iouMoneyAction = sortedReportActions.find( | ||
| (reportAction) => | ||
| shouldReportActionBeVisible(reportAction, reportAction.reportActionID, isWriteActionAllowed) && | ||
| reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && | ||
| isMoneyRequestAction(reportAction), | ||
| ); | ||
| if (iouMoneyAction) { | ||
| lastVisibleIOUMoneyActions[reportID] = iouMoneyAction; | ||
| } else { | ||
| delete lastVisibleIOUMoneyActions[reportID]; | ||
| } |
There was a problem hiding this comment.
any loops in the callback fn should be avoided
There was a problem hiding this comment.
Agreed, merged the .filter() and .find() into a single for loop with an early break — one pass instead of two.
…on thread report ID. Remove cached function and improve report action visibility logic in OptionsListUtils. Add isNewerReportAction utility for comparing report actions based on timestamps.
…-reduce-sorting-overhead
…nused lastVisibleIOUMoneyActions and streamline the process for determining the first visible report action for display.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…Attributes config
…e reportAttributes config" This reverts commit 934de48. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-reduce-sorting-overhead
BartekObudzinski
changed the title
melvin-bot
bot
requested review from
joekaufmanexpensify and
sobitneupane
and removed request for
a team
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Performance Optimization Review - Correctness ConcernsAfter analyzing the full diff across all 6 commits, I found 3 potential correctness issues that should be addressed before merging: 1. Missing transformations in findLastReportActions (src/libs/ReportActionsUtils.ts)The original While these transformations may not affect which action is selected as newest, the returned action object itself will differ -- Action: Please verify this is intentional or apply the same transformations. 2. isOffline not passed in reportAttributes config (src/libs/actions/OnyxDerived/configs/reportAttributes.ts:210)The original LHN code called The Commit 5/6 attempted to fix this by wiring in 3. No tests for findLastReportActions (tests/unit/ReportActionsUtilsTest.ts)The tests cover
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 231009d55f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Type check is failing: |
…date test case for actionable mention whisper visibility
|
No product review needed |
|
Hi @sobitneupane could you review this PR please? |
sobitneupane
left a comment
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified there are no new alerts related to the
canBeMissingparam foruseOnyx - I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@BartekObudzinski Scenario 1 in this PR is failing because of a regression issue #83269 The issue is reproducible in: Web 
Bug7086427_1771884499892.8.mp4 |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.25-0 🚀
|
|
@BartekObudzinski Could you please confirm if it's expected that we see bandicam.2026-02-24.11-58-39-335.mp4 |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀
|
10 participants
Explanation of Change
Extend the
reportAttributesOnyxDerived config to exposeoneTransactionThreadReportID, moving its computation out of LHN'srenderItemand into the Onyx-derived layer. This replaces the per-rendergetOneTransactionThreadReportID()call with a reactive, pre-computed value, so LHN always reads an up-to-date result without re-computing it on every render.Additionally, replace two separate sort-based lookups in
renderItem(onegetSortedReportActionsForDisplaycall forlastReportActionand onegetSortedReportActions+ filter pass forlastAction) with a single-passfindLastReportActions()function that finds both values simultaneously, significantly reducing per-item computation overhead.Fixed Issues
$ #83025
PROPOSAL:
Tests
Scenario 1 — one-transaction thread report in LHN:
Scenario 2 — invite/remove action as last action in LHN :
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-20.at.10.38.56.mov
Android: mWeb Chrome
Screen.Recording.2026-02-20.at.10.42.07.mov
iOS: Native
Screen.Recording.2026-02-20.at.10.18.24.mov
iOS: mWeb Safari
Screen.Recording.2026-02-20.at.10.22.33.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-20.at.10.25.47.mov