chore: migrate old SelectionList to new SelectionListWithSections in MoneyRe… by sharabai · Pull Request #82662 · Expensify/App

sharabai · 2026-02-17T14:15:42Z

Explanation of Change

Fixed Issues

$ #65658
PROPOSAL:

Tests

There're multiple flows to test:

Regular web
Web on mobile
Mobile test
New Client flow

Regular web test

Go to home page
Click '+' FAB
Click 'Create Expense' button
Choose if not already chosen 'manual' tab(it could be 'scan' tab too, but it's quicker that way) and enter some value and click 'Next' button
You should be at 'Choose recipient' screen
Test this screen thoroughly by
- adding new people to the list by writing in input field emails
- writing some wrong phone number, e.g., +3453 -> you should see text below the input field that tells you about wrong phone number
- entering wrong email, e.g., df@e, -> you should see text with wrong email warning
- entering some substring that only part of contacts have -> you should see only that group of contacts

Web on Mobile

Assuming you're already in 'Choose recipient' screen (for reference check Regular-web-test-first steps)
Check that after searching some subgroup of users and starting scrolling, the keyboard becomes hidden

Mobile test

Assuming you're already in 'Choose recipient' screen (for reference check Regular-web-test-first steps)
If you haven't done it earlier you'd see an 'Import contacts' button and if you did it earlier, you'd see in Contacts users without Expensify Avatars, but with a generic 'User Avatar' icon.
- You can reject Contacts permissions (iOS example: Settings -> Apps -> Expensify -> Contacts -> None)
Check you see 'Import contacts' button and test that after clicking it, either Expensify app'd ask permission or if you rejected those permissions, it'd show you to Settings screen

New Client flow test

enter with a new account
you will see onboarding screen
skip those steps
go to 'Choose recipient' screen (for reference check Regular-web-test-first steps)
there you should see 'Manager McTest among your contacts' AND you should see a tooltip 'Choose our test manager to try it out!'
test that when you scroll the tooltip disappears and reappears at the correct position in the list

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios-82662.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

macOs-web-82662.mp4

codecov · 2026-02-17T14:23:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.43% <ø> (ø)`
...ts/SelectionList/ListItem/InviteMemberListItem.tsx	`91.17% <ø> (ø)`
...onents/SelectionList/ListItem/ListItemRenderer.tsx	`80.00% <ø> (ø)`
...ListWithSections/BaseSelectionListWithSections.tsx	`75.67% <100.00%> (ø)`
...pages/iou/request/MoneyRequestAttendeeSelector.tsx	`0.00% <ø> (ø)`
...s/iou/request/MoneyRequestParticipantsSelector.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

zfurtak

Everything looks fine to me 👍
Just take care of CLA check and I left one little comment :)

zfurtak · 2026-02-18T11:33:54Z

src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx

                <>
                    {customHeaderContent}
                    <FlashList
+                        ListHeaderComponent={customListHeaderContent}


nitpick, but put it please lower, somewhere next to ListFooterComponent, as it's not an important prop

melvin-bot · 2026-02-18T12:34:32Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e79aae32e7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-18T12:45:12Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

                canShowProductTrainingTooltip={canShowManagerMcTest}
-                headerContent={
+                customListHeaderContent={importContactsButtonComponent}
+                customHeaderContent={


Keep import-contacts prompt visible for empty searches

Switching this prop to customHeaderContent makes the ImportContactButton render only in the non-empty branch of BaseSelectionListWithSections (src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx), unlike the previous headerContent behavior. On native, when contacts permission is denied and a non-matching query is entered, showImportContacts suppresses the text-input header message and the list is empty, so the import-contacts guidance disappears entirely in that no-results state.

Useful? React with 👍 / 👎.

did you test this case @sharabai

@grgia yep, the comment was useful and I did change the code.

chatgpt-codex-connector · 2026-02-18T12:45:12Z

src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx

                        onEndReachedThreshold={onEndReachedThreshold}
                        onScrollBeginDrag={onScrollBeginDrag}
                        scrollEnabled={scrollEnabled}
+                        onScroll={triggerScrollEvent}


Invoke caller onScroll while emitting scroll events

This assignment overwrites the onScroll callback coming from SelectionListWithSections/index.tsx (via useWebSelectionListBehavior) instead of composing both handlers. On web touch devices, that callback is responsible for dismissing the keyboard during user scroll, so after this change scrolling the participants list can leave the keyboard covering results while only tooltip scroll events fire.

Useful? React with 👍 / 👎.

Let's check if it works correctly on mWeb app

dukenv0307 · 2026-02-18T13:42:05Z

@sharabai can you please check the bot's feedbacks above? Thanks

sharabai · 2026-02-18T17:04:01Z

@dukenv0307 I've addressed the ai feedback.

heyjennahay

Product review not required

dukenv0307 · 2026-02-21T03:48:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-21.at.10.46.51.mov

Android: mWeb Chrome

Screen.Recording.2026-02-21.at.10.35.43.mov

iOS: HybridApp

Screen.Recording.2026-02-21.at.10.45.42.mov

iOS: mWeb Safari

Screen.Recording.2026-02-21.at.10.37.37.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-21.at.10.31.10.mov

dukenv0307

LGTM

…MoneyRequestParticipantsSelector

grgia · 2026-02-24T13:05:04Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

+        if (!isWorkspacesOnly) {
+            if ((isPerDiemRequest ? availableOptions.recentReports.filter((report) => report.isPolicyExpenseChat) : availableOptions.recentReports).length > 0) {


@sharabai why did this if check change?

@grgia the if check is same. It was moved to from inside the object from prop shouldShow to an outside beforehand if check.
Look at this line It's hard to spot it in github diff.

github-actions · 2026-03-02T11:21:30Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-02T11:24:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-02T11:26:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82662.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ade00ad-39f6ce2-dc822c6f45aa1f84d81f3ae6196f07a4306afb28/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ade00ad-39f6ce2-5afeda3e9e95dc44f14dcf8311028e47894a4193/index.html

Web 🕸️
https://82662.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:02:05Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:16:53Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:07:14Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned sharabai Feb 17, 2026

sharabai force-pushed the refactor/replace-SelectionListWithSections-with-new-SelectionList-in-MoneyRequestParticipantsSelector branch 2 times, most recently from 5cf7c35 to d30d2d0 Compare February 17, 2026 16:30

zfurtak approved these changes Feb 18, 2026

View reviewed changes

sharabai force-pushed the refactor/replace-SelectionListWithSections-with-new-SelectionList-in-MoneyRequestParticipantsSelector branch from d30d2d0 to e79aae3 Compare February 18, 2026 12:25

sharabai marked this pull request as ready for review February 18, 2026 12:34

sharabai requested review from a team as code owners February 18, 2026 12:34

melvin-bot bot requested review from dukenv0307 and heyjennahay and removed request for a team February 18, 2026 12:34

melvin-bot bot removed the request for review from a team February 18, 2026 12:34

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

zfurtak mentioned this pull request Feb 18, 2026

[Due for payment 2026-03-31] [Due for payment 2026-03-13] [SelectionList Improvements][Phase 4] Migrate sectioned list usages (~25) #65658

Closed

sharabai force-pushed the refactor/replace-SelectionListWithSections-with-new-SelectionList-in-MoneyRequestParticipantsSelector branch 2 times, most recently from 412712c to 9fe82d2 Compare February 18, 2026 17:02

sharabai mentioned this pull request Feb 19, 2026

[No QA] Chore: keep consistent naming in SelectionList and SelectionListWithSections #82839

Merged

53 tasks

sharabai force-pushed the refactor/replace-SelectionListWithSections-with-new-SelectionList-in-MoneyRequestParticipantsSelector branch from 9fe82d2 to 280c9f4 Compare February 19, 2026 15:23

heyjennahay reviewed Feb 20, 2026

View reviewed changes

dukenv0307 approved these changes Feb 21, 2026

View reviewed changes

melvin-bot bot requested a review from grgia February 21, 2026 03:49

chore: migrate old SelectionList to new SelectionListWithSections in …

b91a8ca

…MoneyRequestParticipantsSelector

sharabai force-pushed the refactor/replace-SelectionListWithSections-with-new-SelectionList-in-MoneyRequestParticipantsSelector branch from 280c9f4 to b91a8ca Compare February 24, 2026 12:28

grgia reviewed Feb 24, 2026

View reviewed changes

sharabai requested a review from grgia February 25, 2026 12:20

grgia approved these changes Mar 2, 2026

View reviewed changes

grgia merged commit ade00ad into Expensify:main Mar 2, 2026
33 checks passed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

		if (!isWorkspacesOnly) {
		if ((isPerDiemRequest ? availableOptions.recentReports.filter((report) => report.isPolicyExpenseChat) : availableOptions.recentReports).length > 0) {

Conversation

sharabai commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Regular web test

Web on Mobile

Mobile test

New Client flow test

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zfurtak left a comment

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

grgia Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

sharabai Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Feb 18, 2026

Uh oh!

sharabai commented Feb 18, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Feb 21, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

grgia Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

sharabai Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

sharabai commented Feb 17, 2026 •

edited

Loading

codecov bot commented Feb 17, 2026 •

edited by github-actions bot

Loading

sharabai Feb 25, 2026 •

edited

Loading