[NoQA] Implement freeze and unfreeze actions and modals by ShridharGoel · Pull Request #82709 · Expensify/App

ShridharGoel · 2026-02-17T20:00:35Z

Explanation of Change

Implement freeze and unfreeze actions and modals

Fixed Issues

$ #81639
PROPOSAL:

Tests

Precondition: Enable the freeze card beta and should have an Expensify card.

Go to Account > Wallet.
Click on any Expensify card.
Verify that freeze card option is visible at the bottom of the details page.
Click on freeze card.
Verify that confirmation modal shows.
Confirm by clicking "Freeze card".
Verify that the freeze option gets removed and instead unfreeze option shows below the card image.
Click on "Unfreeze card".
Verify that confirmation modal shows.
Confirm by clicking "Unfreeze card".
Verify that the unfreeze option gets removed and instead freeze option shows at the bottom of the details page.
Verify that clicking cancel on any modal closes the modal.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-18.at.1.23.28.AM.mov

melvin-bot · 2026-02-17T20:00:42Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-02-17T20:00:49Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-17T20:07:33Z

Code Review - PR #82709

Bug: Wrong first argument passed to `freezeCard` and `unfreezeCard`

File: src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

The freezeCard and unfreezeCard functions in src/libs/actions/Card.ts expect workspaceAccountID as the first parameter:

// Function signatures in Card.ts:
function freezeCard(workspaceAccountID: number, card: Card, currentUserAccountID: number)
function unfreezeCard(workspaceAccountID: number, card: Card)

But the PR passes fundID instead:

// What the PR does:
Card.freezeCard(Number(currentCard?.fundID ?? CONST.DEFAULT_NUMBER_ID), currentCard, session?.accountID ?? CONST.DEFAULT_NUMBER_ID);
Card.unfreezeCard(Number(currentCard?.fundID ?? CONST.DEFAULT_NUMBER_ID), currentCard);

fundID and workspaceAccountID are different values. The workspaceAccountID is used internally by buildCardListUpdates to construct the correct Onyx key for optimistic updates. Passing fundID will cause the optimistic data to target the wrong Onyx key, meaning the UI won't reflect the freeze/unfreeze state change correctly.

UX inconsistency: Unfreeze button placement and component type differ from Freeze

File: src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

The unfreeze action uses a Button component placed at the top of the page (right after CardPreview), while the freeze action uses a MenuItem placed at the bottom (after View Transactions). This creates an inconsistent experience — the same toggle action appears in different locations with different visual treatments.

Consider placing both actions in the same position with the same component type for a symmetric UX.

Translation files look correct

The 10 language files add consistent translation keys (unfreeze, unfreezeCard, freezeDescription, unfreezeDescription) that match the English source strings. No issues found with the translations.

codecov · 2026-02-17T20:07:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	`66.66% <82.60%> (+3.50%)`	⬆️
... and 101 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d407282730

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

ShridharGoel · 2026-02-18T06:34:10Z

#82709 (comment) -> This is not valid.

Pujan92 · 2026-02-18T11:05:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-18.at.17.33.39.mov

Screen.Recording.2026-02-18.at.17.34.05.mov

Pujan92 · 2026-02-18T11:57:46Z

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

+                isVisible={isFreezeModalVisible}
+                onConfirm={handleConfirmFreeze}
+                onCancel={handleDismissFreezeModal}
+                onBackdropPress={handleDismissFreezeModal}


do we need to close on backdrop press?

@MariaHCD Can you confirm?

I think it should be fine to close?

Do we close on backdrop press for other confirmation modals in the app?

I think it should be fine to close in this case but would be good to be consistent with whatever the current approach is!

It seems to be a mixed approach. At some places this is done while ignored at others.

Okay, I don't see a specific reason why we wouldn't allow closing when the backdrop is pressed. Let's go with this approach for now. If needed, we can always update this in the future.

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

Pujan92

LGTM! Need to confirm #82709 (comment) by @MariaHCD

melvin-bot · 2026-02-18T12:26:53Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #81639 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

Pujan92 · 2026-02-18T12:28:41Z

Do we need to add NoQA tag for the PR?

ShridharGoel · 2026-02-18T12:29:51Z

Added, this will be tested once the feature is ready for release 1

MariaHCD · 2026-02-18T13:04:49Z

One last clarification but I think looks good to go!

#82709 (comment)

github-actions · 2026-02-18T13:08:25Z

🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-18T13:12:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82709.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6a4702c-09da3e9-c7cedcd42615fe0f172530c4196b53e700065ef1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6a4702c-09da3e9-36afbb556ceb441739af345b5fc7da8f7c812697/index.html

Web 🕸️
https://82709.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-18T13:14:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-18T22:21:49Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:22:39Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:36:59Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Implement freeze and unfreeze actions and modals

d407282

melvin-bot bot assigned ShridharGoel Feb 17, 2026

ShridharGoel marked this pull request as ready for review February 17, 2026 20:00

ShridharGoel requested review from a team as code owners February 17, 2026 20:00

melvin-bot bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team February 17, 2026 20:00

chatgpt-codex-connector bot reviewed Feb 17, 2026

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx Show resolved Hide resolved

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx Outdated Show resolved Hide resolved

ShridharGoel added 2 commits February 18, 2026 12:10

Fix lint

41ffd6b

Add locked account check

6b9efc1

Pujan92 reviewed Feb 18, 2026

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage/index.tsx Show resolved Hide resolved

Get rid of extra condition

fb2110a

Pujan92 approved these changes Feb 18, 2026

View reviewed changes

melvin-bot bot requested a review from NikkiWines February 18, 2026 12:27

ShridharGoel changed the title ~~Implement freeze and unfreeze actions and modals~~ [NoQA] Implement freeze and unfreeze actions and modals Feb 18, 2026

Add currentCard check again

82ff96a

MariaHCD requested review from MariaHCD and removed request for NikkiWines February 18, 2026 12:45

MariaHCD approved these changes Feb 18, 2026

View reviewed changes

MariaHCD merged commit 6a4702c into Expensify:main Feb 18, 2026
37 checks passed

OSBotify mentioned this pull request Feb 18, 2026

Deploy Checklist: New Expensify 2026-02-18 #82863

Closed

76 tasks

melvin-bot bot mentioned this pull request Feb 19, 2026

[Due for payment 2026-02-26] [Freeze Card] Handle freeze and unfreeze actions #81639

Closed

Conversation

ShridharGoel commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 17, 2026

Uh oh!

melvin-bot bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Code Review - PR #82709

Bug: Wrong first argument passed to freezeCard and unfreezeCard

UX inconsistency: Unfreeze button placement and component type differ from Freeze

Translation files look correct

Uh oh!

codecov bot commented Feb 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ShridharGoel commented Feb 18, 2026

Uh oh!

Pujan92 commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

MariaHCD Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

MariaHCD Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

Pujan92 commented Feb 18, 2026

Uh oh!

ShridharGoel commented Feb 18, 2026

Uh oh!

MariaHCD commented Feb 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

ShridharGoel commented Feb 17, 2026 •

edited

Loading

Bug: Wrong first argument passed to `freezeCard` and `unfreezeCard`

codecov bot commented Feb 17, 2026 •

edited by github-actions bot

Loading

Pujan92 commented Feb 18, 2026 •

edited

Loading