Delete user MENTIONWHISPER when ADDCOMMENT is deleted by deetergp · Pull Request #82720 · Expensify/App

deetergp · 2026-02-18T00:22:52Z

Explanation of Change

When a user sends a message with an @username mention targeting someone who is not a member of the chat room, the backend creates an ACTIONABLEMENTIONWHISPER at parentCommentID + 1. This whisper prompts the sender to either invite the mentioned user or dismiss the notification.

A companion backend fix (Auth PR #19971) was made so that when the parent comment is deleted, the backend cascades the deletion to the associated whisper by setting originalMessage.deleted on it.

However, the frontend was not hiding the whisper after this cascade deletion. The root cause is that isDeletedAction() in ReportActionsUtils.ts explicitly returns false for ACTIONABLEMENTIONWHISPER (since its deletion semantics differ from regular comments), bypassing the normal message.deleted check.

The fix is in isResolvedActionableWhisper(), which is already used by shouldReportActionBeVisible() to gate whisper visibility. We now treat originalMessage.deleted (set by the backend cascade deletion) the same as originalMessage.resolution (set when the user actively chooses invite/dismiss) — both cause the whisper to be hidden.

Fixed Issues

$ #63874
PROPOSAL: N/A

Tests

Open a chat room (not a DM)
Send a message that @mentions a user who is not a member of the room
Confirm the actionable mention whisper appears, asking if you want to invite them
Delete the message containing the @mention (long-press → Delete)
Verify that the actionable mention whisper is no longer visible in the chat after the deletion

Verify that no errors appear in the JS console

Offline tests

No offline-specific behavior changes. The fix operates on already-synced Onyx data.

QA Steps

Same as tests. Note: requires the companion Auth backend fix (PR #19971) to be deployed first.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

deetergp · 2026-02-26T19:45:03Z

This does not need to hold on https://github.com/Expensify/Auth/pull/19971, but it will be a no-op till that PR makes it to production. It can be reviewed in the meantime.

melvin-bot · 2026-02-26T19:45:12Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2026-03-03T09:16:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web-2.mov

web.mov

jayeshmangwani · 2026-03-03T09:17:31Z

@deetergp Changes look good 👍 Just two quick confirmations on expected behavior:

After deleting the parent message, we currently wait for the BE response before hiding the actionable whisper. Should we hide it optimistically?

q-1.mov

If the parent message is deleted offline, the whisper is still visible and clickable. Should we hide/delete it, or just disable the action?

q-2.mov

deetergp · 2026-03-04T01:32:26Z

Good catch @jayeshmangwani 👍 I've updated it so that we optimistically delete the mention whisper which should also get us number 2 for free, if I'm not mistaken.

jayeshmangwani · 2026-03-05T06:19:29Z

@deetergp It appears that Whisper remains visible after deleting the parent message while offline, and the options are still selectable.

offline-case.mov

codecov · 2026-03-05T23:35:54Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportActionsUtils.ts	`54.84% <100.00%> (+0.81%)`	⬆️
...ctions/OnyxDerived/configs/visibleReportActions.ts	`91.02% <100.00%> (ø)`
src/libs/actions/Report/index.ts	`67.43% <88.88%> (+0.65%)`	⬆️
...ort/ContextMenu/PopoverReportActionContextMenu.tsx	`43.94% <33.33%> (-0.10%)`	⬇️
... and 226 files with indirect coverage changes

Search report actions for an unresolved ACTIONABLE_MENTION_WHISPER or ACTIONABLE_REPORT_MENTION_WHISPER and mark it deleted in the same optimistic Onyx update as the comment deletion, so the whisper disappears immediately (online and offline).

jayeshmangwani · 2026-03-09T06:10:12Z

@deetergp , we are seeing two bugs.

Go to any room.
Send a message in room e.g., #testing. A whisper will appear to create the room.
Send another message to invite a user, for example:
testing @jm98289517@gmail.com.
This will show another whisper to invite the user.
Delete the message testing @jm98289517@gmail.com.

Issue:
When deleting this message, it will first deletes the whisper for #testing and then deletes the invite whisper.
However, only the whisper related to the deleted parent message should be removed.

whisper-bug-no-1.mov

Send two messages in the room:
#testing
testing @jm98289517@gmail.com
Each message will have its own whisper.
Go offline.
Delete the message testing @jm98289517@gmail.com.

Issue:
Instead of hiding the whisper associated with the deleted message, the system hides the whisper related to the #testing message.

whisper-bug-no-2.mov

deetergp · 2026-03-13T18:21:37Z

@jayeshmangwani Updated and retested and those bugs have been resolved.

jayeshmangwani · 2026-03-16T06:43:36Z

@deetergp , sorry, we still have one issue to resolve in this PR. When two invite messages are sent back-to-back, the whisper for the first message gets hidden.

bug-invite-user.mov

deetergp · 2026-03-16T23:21:08Z

@jayeshmangwani I'm pretty sure that's by design. It's caused by code on the back end that specifically states

    // We only allow one unresolved actionable mention whisper per user

To "fix" it would mean undoing those changes that @jasperhuangg put in place nearly two years ago.

jasperhuangg · 2026-03-16T23:27:46Z

@jayeshmangwani yep that's by design, no cause for concern

jayeshmangwani · 2026-03-17T14:01:10Z

@deetergp @jasperhuangg Problem is that we see separate whispers on staging and main, but not on ours PR, which makes it look like a regression. That said, if we’re okay with the current PR behavior, we’re good to go.

tested with the same user and report on both main and staging. Screenshots showing the differences are below.

Staging/main

Our PR

deetergp · 2026-03-17T23:07:57Z

@jayeshmangwani Updated!

jayeshmangwani

LGTM 🚀 let’s gooo!

melvin-bot · 2026-03-19T17:01:47Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-20T22:43:27Z

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-20T22:48:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82720.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f456efe-9be7b50-aa48244787d8863913559889813414fafa8ea867/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f456efe-9be7b50-c2e4e52dd4c3b18d9aa456573fc568050ff894b6/index.html

Web 🕸️
https://82720.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-20T22:48:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-23T09:50:00Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-03-23T10:59:59Z

Deploy Blocker #86084 was identified to be related to this PR.

deetergp · 2026-03-23T16:55:30Z

We've gone from none of them being deleted in production to not all of them being deleted, I wouldn't consider that to be a blocker, right?

deetergp self-assigned this Feb 18, 2026

deetergp changed the title ~~Delete mention with add comment~~ [HOLD Auth #19971] Delete user MENTIONWHISPER when ADDCOMMENT is deleted Feb 18, 2026

deetergp added 3 commits February 26, 2026 11:02

Include 'deleted' in considering if a whisper is resolved

af2c7d0

Add a test to cover deleted marking whispers resolved

f14c9ae

ESLint fix

11482d9

deetergp force-pushed the scott-deleteMentionWithAddComment branch from 0e9b46d to 11482d9 Compare February 26, 2026 19:02

deetergp added 2 commits February 26, 2026 11:20

Include reportID

20be867

Update the comment to better explain what we're testing

e7a4f2c

deetergp changed the title ~~[HOLD Auth #19971] Delete user MENTIONWHISPER when ADDCOMMENT is deleted~~ Delete user MENTIONWHISPER when ADDCOMMENT is deleted Feb 26, 2026

deetergp marked this pull request as ready for review February 26, 2026 19:45

deetergp requested review from a team as code owners February 26, 2026 19:45

melvin-bot bot requested review from jayeshmangwani and removed request for a team February 26, 2026 19:45

melvin-bot bot requested review from heyjennahay and removed request for a team February 26, 2026 19:45

deetergp added 2 commits March 3, 2026 17:20

Merge branch 'main' into scott-deleteMentionWithAddComment

c72739f

Optimistically delete the mention whisper

78b64e7

TypeScript Checker fix

97fb8aa

Merge branch 'main' into scott-deleteMentionWithAddComment

10b7697

deetergp added 3 commits March 6, 2026 10:19

Add a test for offline deletion

0595ce5

ESLint fix

90d3ff2

deetergp added 4 commits March 13, 2026 10:57

Merge branch 'main' into scott-deleteMentionWithAddComment

6b765ca

Make array of unresolved whisper IDs to delete

902943d

Add test for when multiple unresolved whispers present

3507c30

ESLint fixes

85a0d13

Merge branch 'main' into scott-deleteMentionWithAddComment

2e1b218

deetergp added 3 commits March 17, 2026 15:39

Pass the report action for reverse checking deleted status

54aae53

Add a test to ensure past whisper stays visible

f7600a5

Pass all report actions to shouldReportActionBeVisible

fb54737

jayeshmangwani approved these changes Mar 19, 2026

View reviewed changes

melvin-bot bot requested a review from youssef-lr March 19, 2026 17:01

youssef-lr approved these changes Mar 20, 2026

View reviewed changes

youssef-lr merged commit f456efe into main Mar 20, 2026
36 checks passed

youssef-lr deleted the scott-deleteMentionWithAddComment branch March 20, 2026 22:39

OSBotify mentioned this pull request Mar 23, 2026

Deploy Checklist: New Expensify 2026-03-23 #86080

Open

69 tasks

jponikarchuk mentioned this pull request Mar 23, 2026

Chat - Not all whispers from Concierge are deleted after deleting message containing mention #86084

Open

7 tasks

jponikarchuk mentioned this pull request Mar 23, 2026

[$250] Chat - After deleting mention, concierge whisper is still shown #63874

Open

16 tasks

Conversation

deetergp commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

deetergp commented Feb 26, 2026

Uh oh!

melvin-bot bot commented Feb 26, 2026

Uh oh!

jayeshmangwani commented Mar 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Mar 3, 2026

Uh oh!

deetergp commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayeshmangwani commented Mar 5, 2026

Uh oh!

codecov bot commented Mar 5, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jayeshmangwani commented Mar 9, 2026

Uh oh!

deetergp commented Mar 13, 2026

Uh oh!

jayeshmangwani commented Mar 16, 2026

Uh oh!

deetergp commented Mar 16, 2026

Uh oh!

jasperhuangg commented Mar 16, 2026

Uh oh!

jayeshmangwani commented Mar 17, 2026

Uh oh!

deetergp commented Mar 17, 2026

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

OSBotify commented Mar 20, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

jponikarchuk commented Mar 23, 2026

Uh oh!

deetergp commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

deetergp commented Feb 18, 2026 •

edited

Loading

deetergp commented Mar 4, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited by github-actions bot

Loading