hide Pay X reports in Todo Task when there is no bank account connected

[mukhrr]

Explanation of Change

Fixed Issues

$ #82207
PROPOSAL: #82207 (comment)

Tests

1. Log into New Expensify on Web as a report approver who does not have the business bank account connected in their Wallet
2. Make sure you don't have a bank account connected
3. Create a workspace
4. Create an expense in workspace
5. Submit -> Approve

Verify you don't see Any report in Reports/To Do and Home tasks

• Verify that no errors appear in the JS console

Offline tests

QA Steps

The same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web.mp4

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/PolicyUtils.ts	57.01% <100.00%> (+0.30%)	⬆️
src/libs/ReportUtils.ts	75.11% <100.00%> (-0.07%)	⬇️
src/libs/SearchUIUtils.ts	68.04% <100.00%> (ø)
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	0.00% <0.00%> (ø)
src/libs/actions/OnyxDerived/configs/todos.ts	95.23% <66.66%> (-4.77%)	⬇️
... and 12 files with indirect coverage changes

[melvin-bot]

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

test

[github-actions]

PR Review: hide Pay X reports in Todo Task when there is no bank account connected

Summary

This PR adds VBBA (Verified Business Bank Account) gating to hide "Pay X" reports in the Todo task list when there is no connected bank account. It modifies two source files and adds comprehensive tests.

Key Findings

1. Broad side-effect from isPolicyPayer change (src/libs/PolicyUtils.ts:432-434)

The isPolicyPayer function is a shared utility also called in SearchUIUtils.ts:875 to determine isEligibleForPaySuggestion. Adding return false when no VBBA exists means the Pay search suggestion will also be hidden for users without a VBBA -- not just the Todo items. This may be intended, but the PR description only mentions Todo tasks. Please confirm this broader behavioral change is desired.

2. Inconsistent VBBA gating logic between the two files

• PolicyUtils.ts: isPolicyPayer returns false if no VBBA -- hard stop, no fallback.
• todos.ts: Allows reports to pass through if the user has sharees access to the bank account, even without VBBA state being OPEN.

This means the Todo code in todos.ts adds a sharees-based fallback that isPolicyPayer does not have. If isPrimaryPayAction (called on line 67 of todos.ts) internally uses isPolicyPayer, the VBBA check in isPolicyPayer may already filter out reports before they even reach the sharees check in todos.ts. Please verify that the sharees fallback in todos.ts is actually reachable.

3. Duplicated VBBA check logic

The expression !!policy.achAccount?.bankAccountID && policy.achAccount?.state === CONST.BANK_ACCOUNT.STATE.OPEN is now present in three locations:

1. PolicyUtils.ts:432 (this PR)
2. todos.ts:70 (this PR)
3. SearchUIUtils.ts:885 (pre-existing)

Consider extracting a shared helper like hasVerifiedBusinessBankAccount(policy) in PolicyUtils.ts and reusing it.

4. Tests are thorough

The new tests in OnyxDerivedTest.tsx cover:

• No-VBBA exclusion
• VBBA inclusion
• Sharees fallback
• Existing tests properly updated with achAccount and BANK_ACCOUNT_LIST data

Recommendation

The main concern is item #2 -- the inconsistency between isPolicyPayer (no sharees fallback) and todos.ts (has sharees fallback). If isPrimaryPayAction depends on isPolicyPayer, the sharees path in todos.ts may be dead code. This needs verification before merging.

[dominictb]

@eh2077 will review this

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73280b34fa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[joekaufmanexpensify]

Just to make sure I'm following, additional admins beyond the workspace payer will still be able to pay reports, as long as they have access to the workspace bank account, correct? Because we intentionally added support for that case in #78794

[mukhrr]

Yes, here we try to hide report for those who has neither bank account nor access to workspace bank account.

[joekaufmanexpensify]

Good for product

[eh2077]

@dominictb Can you assign me as reviewer, so it'll be on my k2 table? thanks 🙇

[eh2077]

@mukhrr I think we can close this, thanks!