Freeze non top screens to prevent extra-rerenders#82764
Freeze non top screens to prevent extra-rerenders#82764mountiny merged 21 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Tested:
ScreenRecording_02-26-2026.20-23-48_1.MP4Looks good to me, the page updated quickly |
|
No screencaps, but Android is working well for me. |
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
mountiny
left a comment
There was a problem hiding this comment.
Let's give it a go, thank you @VickyStash
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.37-0 🚀
|
…-non-top-screens [CP Staging] Revert "Merge pull request #82764 from refactor/freeze-non-top-screens"
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀
|
Explanation of Change
Freezes non-top screens in the navigation stack to prevent unnecessary re-renders, using a ScreenFreezeWrapper for the split navigator on web and a react-navigation patch for mobile.
Fixed Issues
$ #33725
#9402
PROPOSAL:
Tests
Offline tests
Same as Tests steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios_web.mov
MacOS: Chrome / Safari
web.mp4