Narrow React Compiler dependencies in MoneyRequestReportNavigation by OlimpiaZurek · Pull Request #82785 · Expensify/App

OlimpiaZurek · 2026-02-18T12:09:34Z

Explanation of Change

This PR optimizes the performance of MoneyRequestReportNavigation by narrowing the React Compiler's dependency tracking for the expensive getSections computation. Previously, the compiler tracked currentSearchResults and currentUserDetails as whole objects — any change to any field invalidated the cache and re-ran the full computation. By extracting the specific sub-fields needed (.data, .accountID, etc.) into separate variables, the compiler now tracks only the fields actually used, so the computation only re-runs when its real inputs change.

Fixed Issues

$ #83052,

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-18T12:25:10Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...RequestReportView/MoneyRequestReportNavigation.tsx	`0.00% <0.00%> (ø)`
... and 15 files with indirect coverage changes

…rtNavigation

melvin-bot · 2026-02-20T15:10:05Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-20T15:10:11Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-02-20T15:56:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

marcaaron · 2026-02-20T19:24:18Z

src/components/MoneyRequestReportView/MoneyRequestReportNavigation.tsx

+    const searchResultsData = currentSearchResults?.data;
+    const searchResultsSearch = currentSearchResults?.search;
+    const currentAccountID = currentUserDetails.accountID;
+    const currentUserEmail = currentUserDetails.email ?? '';


By extracting the specific sub-fields needed (.data, .accountID, etc.) into separate variables, the compiler now tracks only the fields actually used, so the computation only re-runs when its real inputs change.

This is a fairly subtle implementation that leads to a great improvement. I'm wondering if we have a best practice for documenting these scenarios yet? It seems relatively easy to perhaps reverse this change if you view these as unnecessary when actually they are signals for React compiler 🤔

Should we add something like:

// React Compiler: destructure to narrow reactive dependencies and avoid recomputes on unrelated changes

marcaaron

Approving but lmk your thoughts on whether to document this in the code or elsewhere.

JmillsExpensify

Product review not required on this one.

JmillsExpensify · 2026-02-21T15:42:33Z

I'm the last reviewer and all remaining checks have passed, so merging.

github-actions · 2026-02-21T15:43:39Z

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-21T15:47:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82785.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-97fef84-08338eb-dcfabce0c3332c6a8d570fd85d35a211b2ffac88/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-97fef84-08338eb-67ab6d4dd02b5bf2e1035bea9eddce420de8fb0b/index.html

Web 🕸️
https://82785.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-21T15:48:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

JmillsExpensify · 2026-02-21T16:25:04Z

Ooops didn't mean to trigger an adhoc on this one.

m-natarajan · 2026-02-23T22:18:06Z

@OlimpiaZurek @Julesssss @marcaaron No QA steps, OK to checkoff this one?

OSBotify · 2026-02-24T01:18:14Z

🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-25T15:51:48Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned OlimpiaZurek Feb 18, 2026

Memoize getSections computation in MoneyRequestReportNavigation

498577e

OlimpiaZurek force-pushed the perf/memoize-getSections-in-MoneyRequestReportNavigation branch from f4a0a8d to 498577e Compare February 18, 2026 12:12

fix prettier

19416bc

remove useMemo

de43207

OlimpiaZurek changed the title ~~Memoize getSections computation in MoneyRequestReportNavigation~~ Narrow React Compiler dependencies in MoneyRequestReportNavigation Feb 19, 2026

mountiny mentioned this pull request Feb 20, 2026

[Due for payment 2026-03-04] [$250] Narrow React Compiler dependencies in MoneyRequestReportNavigation #83052

Closed

Merge branch 'main' into perf/memoize-getSections-in-MoneyRequestRepo…

253903a

…rtNavigation

OlimpiaZurek marked this pull request as ready for review February 20, 2026 15:09

OlimpiaZurek requested review from a team as code owners February 20, 2026 15:09

melvin-bot bot requested review from JmillsExpensify and bernhardoj and removed request for a team February 20, 2026 15:10

melvin-bot bot requested review from a team and marcaaron and removed request for a team February 20, 2026 15:10

OlimpiaZurek mentioned this pull request Feb 20, 2026

[Metrics] Create Expense flows #81849

Open

bernhardoj approved these changes Feb 20, 2026

View reviewed changes

marcaaron reviewed Feb 20, 2026

View reviewed changes

marcaaron approved these changes Feb 20, 2026

View reviewed changes

szymonzalarski98 approved these changes Feb 20, 2026

View reviewed changes

Julesssss approved these changes Feb 20, 2026

View reviewed changes

JmillsExpensify reviewed Feb 21, 2026

View reviewed changes

JmillsExpensify merged commit 97fef84 into Expensify:main Feb 21, 2026
37 checks passed

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

Conversation

OlimpiaZurek commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 18, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 20, 2026

Uh oh!

melvin-bot bot commented Feb 20, 2026

Uh oh!

bernhardoj commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

marcaaron Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Feb 21, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

OSBotify commented Feb 21, 2026

Uh oh!

JmillsExpensify commented Feb 21, 2026

Uh oh!

m-natarajan commented Feb 23, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

OlimpiaZurek commented Feb 18, 2026 •

edited

Loading

codecov bot commented Feb 18, 2026 •

edited by github-actions bot

Loading

bernhardoj commented Feb 20, 2026 •

edited

Loading