Skip to content

Stop clearing Description Hint when disabling Require description #82813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neil-marcellini merged 1 commit into from
Feb 18, 2026
Merged

Stop clearing Description Hint when disabling Require description #82813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/libs/actions/Policy/Category.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,6 @@ function setWorkspaceCategoryEnabled({
function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: string, areCommentsRequired: boolean, policyCategories: PolicyCategories = {}) {
const policyCategoryToUpdate = policyCategories?.[categoryName];
const originalAreCommentsRequired = policyCategoryToUpdate?.areCommentsRequired;
const originalCommentHint = policyCategoryToUpdate?.commentHint;

// When areCommentsRequired is set to false, commentHint has to be reset
const updatedCommentHint = areCommentsRequired ? policyCategories?.[categoryName]?.commentHint : '';

const onyxData: OnyxData<typeof ONYXKEYS.COLLECTION.POLICY_CATEGORIES> = {
optimisticData: [
Expand All @@ -496,7 +492,6 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st
areCommentsRequired: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
},
areCommentsRequired,
commentHint: updatedCommentHint,
},
},
},
Expand All @@ -512,7 +507,6 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st
areCommentsRequired: null,
},
areCommentsRequired,
commentHint: updatedCommentHint,
},
},
},
Expand All @@ -529,7 +523,6 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st
areCommentsRequired: null,
},
areCommentsRequired: originalAreCommentsRequired,
commentHint: originalCommentHint,
},
},
},
Expand Down
Loading