Skip to content

[CP Staging] Revert "Limit fallback image rendering and add priority to reduce carousel load times"#82837

Merged
mountiny merged 1 commit intomainfrom
revert-82282-lightbox-fallback-priority
Feb 18, 2026
Merged

[CP Staging] Revert "Limit fallback image rendering and add priority to reduce carousel load times"#82837
mountiny merged 1 commit intomainfrom
revert-82282-lightbox-fallback-priority

Conversation

@cristipaval
Copy link
Copy Markdown
Contributor

@cristipaval cristipaval commented Feb 18, 2026 •
edited
Loading

Explanation of Change

Reverts #82282.

This PR introduced a regression causing blank previews on the 4th attachment preview (see #82723).

Fixed Issues

$ #82723

@cristipaval
Revert "Merge pull request #82282 from callstack-internal/callstack-i…
18b312e 
…nternal/szymonzalarski/attachments/images-load-extremely-slow-when-viewing-in-the-app"

This reverts commit fda1e22, reversing
changes made to d3c00a5.
@cristipaval cristipaval requested review from a team as code owners February 18, 2026 17:06
@melvin-bot melvin-bot bot requested review from sobitneupane and removed request for a team February 18, 2026 17:06
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Feb 18, 2026

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and removed request for a team February 18, 2026 17:06
@cristipaval cristipaval requested a review from mountiny February 18, 2026 17:07
@cristipaval cristipaval changed the title Revert "Limit fallback image rendering and add priority to reduce carousel load times" [CP Staging] Revert "Limit fallback image rendering and add priority to reduce carousel load times" Feb 18, 2026
@cristipaval cristipaval added the CP Staging marks PRs that have been CP'd to staging label Feb 18, 2026
mountiny
mountiny approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert + the test file that was adjusted here #82642

@mountiny mountiny merged commit 02c3399 into main Feb 18, 2026
30 of 34 checks passed
@mountiny mountiny deleted the revert-82282-lightbox-fallback-priority branch February 18, 2026 17:16
@melvin-bot melvin-bot bot added the Emergency label Feb 18, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Feb 18, 2026

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2026 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/components/Lightbox/index.tsx 64.70% <50.00%> (-23.82%) ⬇️
... and 26 files with indirect coverage changes

OSBotify pushed a commit that referenced this pull request Feb 18, 2026
@mountiny @OSBotify
Merge pull request #82837 from Expensify/revert-82282-lightbox-fallba…
02d2e93 
…ck-priority

[CP Staging] Revert "Limit fallback image rendering and add priority to reduce carousel load times"

(cherry picked from commit 02c3399)

(cherry-picked to staging by mountiny)
@mountiny
Copy link
Copy Markdown
Contributor

mountiny commented Feb 18, 2026

Straight revert of 2 prs

@OSBotify OSBotify mentioned this pull request Feb 18, 2026
Closed
93 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 18, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 18, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 18, 2026

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.21-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 18, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82837.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-02c3399-cd3c01a-d5219b6a39723603f4f6aa40394fe7841a25d1e0/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-02c3399-cd3c01a-35a85a5633b688fba104fc567748f990cc30423f/index.html
Android iOS
Web 🕸️
https://82837.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 18, 2026

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 18, 2026

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.22-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 19, 2026

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform result
🕸 web 🕸 cancelled 🔪
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@melvin-bot melvin-bot bot mentioned this pull request Feb 19, 2026
Closed
7 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 19, 2026

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform result
🕸 web 🕸 failure ❌
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@cristipaval cristipaval mentioned this pull request Feb 19, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@sobitneupane sobitneupane Awaiting requested review from sobitneupane

@joekaufmanexpensify joekaufmanexpensify Awaiting requested review from joekaufmanexpensify

Assignees

@cristipaval cristipaval

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cristipaval @mountiny @OSBotify