[No QA] Fix failureNotifier issue body rendered as code block by neil-marcellini · Pull Request #82845 · Expensify/App

neil-marcellini · 2026-02-18T17:56:30Z

Explanation of Change

The dedent utility in failureNotifier.ts strips the minimum indentation from all lines in a template literal. When the errorMessage content was interpolated, its lines had different (lower) indentation than the rest of the template. This made dedent miscalculate the minimum indent — it stripped only 1 space instead of 12, leaving 11 leading spaces on every other line. GitHub Markdown renders 4+ leading spaces as a code block, which is why recent workflow failure issues have their entire body rendered inside a code block.

Fix: Remove dedent and use a plain template literal that starts at column 0. This is the simplest approach since dedent doesn't work reliably with interpolated multi-line values that have different indentation. A comment explains why the template is intentionally unindented relative to the surrounding code.

Fixed Issues

$ #82842

Tests

N/A — No QA, GitHub Actions workflow change only.

Local output verification

Ran a local simulation of the template with sample data. The fixed output has zero lines with 4+ leading spaces, matching correctly-formatted older issues.

Fixed output:

🚨 **Failure Summary** 🚨:

- **📋 Job Name**: [build (Expensify Dev, Debug, true)](https://github.com/Expensify/App/actions/runs/22149214165/job/64035394714)
- **🔧 Failure in Workflow**: Process new code merged to main
- **🔗 Triggered by PR**: [PR Link](https://github.com/Expensify/App/pull/82370)
- **👤 PR Author**: @roryabraham
- **🤝 Merged by**: @roryabraham
- **🐛 Error Message**:
failure: Process completed with exit code 1.

⚠️ **Action Required** ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named [build (Expensify Dev, Debug, true)](https://github.com/Expensify/App/actions/runs/22149214165/job/64035394714).
🔍 This issue has been automatically created and labeled with `Workflow Failure` for investigation.

**👀 Please look into the following:**
1. **Why the PR caused the job to fail?**
2. **Address any underlying issues.**

**🐛 We appreciate your help in squashing this bug!**

✅ No lines with 4+ leading spaces — will render as proper Markdown.

Broken output (before fix):

           🚨 **Failure Summary** 🚨:

           - **📋 Job Name**: [build (Expensify Dev, Debug, true)](...)
           - **🔧 Failure in Workflow**: Process new code merged to main
           ...

❌ 15 lines with 4+ leading spaces — renders as code block on GitHub.

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

N/A — CI workflow change only, no UI changes.

melvin-bot · 2026-02-18T17:56:36Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2026-02-18T17:58:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

roryabraham · 2026-02-18T17:58:43Z

@neil-marcellini do you need to rebuild GH actions?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f1164d16a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.github/actions/javascript/failureNotifier/index.js

neil-marcellini · 2026-02-18T18:16:20Z

No C+ review needed in my opinion.

neil-marcellini · 2026-02-18T18:21:42Z

@codex please review

chatgpt-codex-connector · 2026-02-18T18:27:43Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.github/actions/javascript/failureNotifier/failureNotifier.ts

The `dedent` utility strips the minimum indentation from all lines. When the errorMessage content was injected with `\n ` (1 space), it became the minimum-indentation line, so dedent only stripped 1 space instead of 12, leaving 11 spaces on every other line. GitHub Markdown renders 4+ leading spaces as a code block. Fix: pre-indent errorMessage lines to match the template indentation so dedent calculates the correct minimum and strips all 12 spaces. Co-authored-by: Cursor <cursoragent@cursor.com>

neil-marcellini · 2026-02-18T18:51:03Z

I filled out the whole checklist so I'm not sure why the CI check isn't passing, but I don't think it really matters so I'm going to merge anyways.

OSBotify · 2026-02-18T18:59:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-18T22:22:32Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:23:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:37:44Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

neil-marcellini requested a review from a team as a code owner February 18, 2026 17:56

melvin-bot bot assigned neil-marcellini Feb 18, 2026

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team February 18, 2026 17:56

roryabraham previously approved these changes Feb 18, 2026

View reviewed changes

neil-marcellini dismissed roryabraham’s stale review via 10d63ea February 18, 2026 18:00

neil-marcellini force-pushed the neil-marcellini-fix-failureNotifier-formatting branch 2 times, most recently from 10d63ea to 2cd81d1 Compare February 18, 2026 18:03

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

.github/actions/javascript/failureNotifier/index.js Outdated Show resolved Hide resolved

neil-marcellini force-pushed the neil-marcellini-fix-failureNotifier-formatting branch from 2cd81d1 to 7a9c89d Compare February 18, 2026 18:04

neil-marcellini requested review from roryabraham and removed request for abdulrahuman5196 February 18, 2026 18:14

roryabraham requested changes Feb 18, 2026

View reviewed changes

.github/actions/javascript/failureNotifier/failureNotifier.ts Outdated Show resolved Hide resolved

neil-marcellini force-pushed the neil-marcellini-fix-failureNotifier-formatting branch from 7a9c89d to 7e1eda1 Compare February 18, 2026 18:32

roryabraham approved these changes Feb 18, 2026

View reviewed changes

neil-marcellini merged commit 9052f2b into main Feb 18, 2026
28 of 30 checks passed

neil-marcellini deleted the neil-marcellini-fix-failureNotifier-formatting branch February 18, 2026 18:51

OSBotify mentioned this pull request Feb 18, 2026

Deploy Checklist: New Expensify 2026-02-18 #82863

Closed

76 tasks

Conversation

neil-marcellini commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

roryabraham commented Feb 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

roryabraham commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

neil-marcellini commented Feb 18, 2026

Uh oh!

neil-marcellini commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 18, 2026

Uh oh!

Uh oh!

neil-marcellini commented Feb 18, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

neil-marcellini commented Feb 18, 2026 •

edited

Loading