Add missing warning modals for re-exporting and retracting exported reports by MelvinBot · Pull Request #82885 · Expensify/App

MelvinBot · 2026-02-19T02:14:53Z

Explanation of Change

When a report has already been exported (via "Mark as exported" or "Export to integration"), two warning modals were not appearing:

"Careful!" re-export modal — The markAsManuallyExported and exportToIntegration functions were not optimistically setting report.isExportedToIntegration = true, so the isExported check short-circuited to false before the server confirmed the export. This meant the re-export warning modal was never triggered.
"Reopen report" modal on Retract — The RETRACT secondary action handler called retractReport() directly without checking isExported, unlike the adjacent REOPEN and UNAPPROVE handlers which both show confirmation modals for exported reports.

This PR fixes both issues by:

Adding optimistic isExportedToIntegration: true to both exportToIntegration and markAsManuallyExported (with false in failure data to revert on error)
Adding an isExported guard to the RETRACT action handler, following the same pattern as REOPEN

Fixed Issues

$ #82745

Tests

Precondition: Workspace connected to an accounting integration (e.g. Sage Intacct), Approvals and Payments disabled in Workflows.

Go to workspace chat
Create an expense
Click Submit on the expense preview
Open the expense report
Click More > Export > Mark as exported
Click More > Export > Mark as exported again
Verify the "Careful!" warning modal appears
Dismiss the modal
Click More > Retract
Verify the "Reopen report" warning modal appears

Verify that no errors appear in the JS console

Offline tests

Mark a report as exported while online
Go offline
Attempt to Mark as exported again
Verify the "Careful!" modal still appears (uses optimistic data)

QA Steps

Same as Tests above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…eports Set isExportedToIntegration optimistically in both exportToIntegration and markAsManuallyExported so the isExported check returns true immediately. Add isExported guard to the RETRACT action matching the existing REOPEN pattern. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

MelvinBot · 2026-02-19T02:15:02Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixExportRetractWarningModals
git checkout -b claude-fixExportRetractWarningModals upstream/claude-fixExportRetractWarningModals
git push -u origin claude-fixExportRetractWarningModals

Then you can close this PR and open a new one from your fork.

codecov · 2026-02-19T02:24:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Report/index.ts	`66.68% <0.00%> (-0.02%)`	⬇️
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
... and 27 files with indirect coverage changes

parasharrajat · 2026-02-26T19:05:54Z

@MelvinBot Merge main.

…ctWarningModals Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

MelvinBot · 2026-02-26T19:11:30Z

Merged main into this branch. No conflicts.

…uration Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

MelvinBot · 2026-02-26T19:16:57Z

Fixed the failing Prettier check: sorted imports in tests/unit/libs/getClipboardTextTest.ts to match Prettier's import ordering configuration. This file was not part of the PR's changes — it was a pre-existing formatting issue that was blocking the check.

parasharrajat · 2026-02-26T19:41:32Z

Screenshots

🔲 iOS / native

27.02.2026_01.19.47_REC.mp4

🔲 iOS / Safari

27.02.2026_01.21.06_REC.mp4

🔲 MacOS / Chrome

27.02.2026_01.02.46_REC.mp4

parasharrajat · 2026-03-15T15:20:50Z

@MelvinBot Resolve conflicts and mark this PR ready for review.

Main's refactored version already includes the isExportedToIntegration optimistic/failure data from this PR, with improvements (multi-report support, pendingFields, previousExportedValue revert). Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

melvin-bot · 2026-03-15T15:30:28Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-15T15:30:40Z

Resolved merge conflicts and marked this PR as ready for review.

Conflict details: The conflict was in src/libs/actions/Report/index.ts in the markAsManuallyExported function. Main had been refactored to support multiple report IDs (loop-based pattern with push()), and already incorporated this PR's isExportedToIntegration optimistic/failure data — with improvements (previousExportedValue revert instead of hardcoded false, plus pendingFields). Resolved by taking main's version for the conflicting sections since all of this PR's intended changes were already present in the updated main code.

The PR's other changes (exportToIntegration optimistic data in Report/index.ts and the RETRACT handler guard in MoneyReportHeader.tsx) merged cleanly without conflicts.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34b2fc5b42

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-15T15:36:31Z

src/libs/actions/Report/index.ts

+            value: {
+                isExportedToIntegration: false,
+            },


Restore prior export state on export API failure

In exportToIntegration(), the failure path always writes isExportedToIntegration: false, which is incorrect when the user is re-exporting a report that was already exported. If the write fails (for example offline or transient network error), this clears the exported flag in Onyx even though the report is still exported, and ReportUtils.isExported() will trust that false value over action history, so follow-up safeguards (like re-export/reopen warnings) stop appearing until state is re-synced. Please preserve and restore the previous value (similar to markAsManuallyExported) instead of hard-coding false.

Useful? React with 👍 / 👎.

@MelvinBot Fix this

Fixed in 638147a. Changed exportToIntegration() to capture previousExportedValue from Onyx before the optimistic update and restore it in failure data, matching the pattern already used in markAsManuallyExported().

Instead of hardcoding isExportedToIntegration: false in failure data, capture the previous value before the optimistic update and restore it on failure. This matches the pattern in markAsManuallyExported and prevents clearing the exported flag when re-exporting a report fails. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

melvin-bot · 2026-03-16T10:28:59Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2026-03-16T17:45:42Z

@codex review

chatgpt-codex-connector · 2026-03-16T17:55:47Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

joekaufmanexpensify

Good for product

lakchote

LGTM

lakchote · 2026-03-17T10:34:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

parasharrajat · 2026-03-17T10:35:27Z

@lakchote wait. I am still confirming this with product team. I have tested and added vid as I think this is ready but I need to confirm copy before we merge.

lakchote · 2026-03-19T20:09:27Z

Merging (see #82745 (comment))

github-actions · 2026-03-19T20:18:46Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T20:23:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82885.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9cfe426-c58bf3c-85a0504ac1e2c2261939f77ac30c28f0a9bcc461/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9cfe426-c58bf3c-55f68a5cf836d8a8634336d73ef8dcc8bec35925/index.html

Web 🕸️
https://82885.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-23T09:50:03Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-24T11:45:46Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.42-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned parasharrajat Feb 19, 2026

MelvinBot requested a review from a team February 19, 2026 02:14

MelvinBot mentioned this pull request Feb 19, 2026

[Due for payment 2026-03-31] [$250] Expense - No warning modal when reexporting & reopening an already exported report #82745

Open

7 tasks

Merge remote-tracking branch 'origin/main' into claude-fixExportRetra…

1fc5bf6

…ctWarningModals Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

Fix: Sort imports in getClipboardTextTest.ts to match Prettier config…

d8f9130

…uration Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>

MelvinBot marked this pull request as ready for review March 15, 2026 15:30

MelvinBot requested a review from a team as a code owner March 15, 2026 15:30

melvin-bot bot requested review from joekaufmanexpensify and parasharrajat March 15, 2026 15:30

melvin-bot bot removed request for a team March 15, 2026 15:30

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

MelvinBot requested a review from a team as a code owner March 16, 2026 10:28

melvin-bot bot requested review from lakchote and removed request for a team March 16, 2026 10:28

joekaufmanexpensify approved these changes Mar 16, 2026

View reviewed changes

lakchote approved these changes Mar 17, 2026

View reviewed changes

lakchote merged commit 9cfe426 into main Mar 19, 2026
35 of 38 checks passed

lakchote deleted the claude-fixExportRetractWarningModals branch March 19, 2026 20:09

OSBotify mentioned this pull request Mar 23, 2026

Deploy Checklist: New Expensify 2026-03-23 #86080

Closed

70 tasks

Conversation

MelvinBot commented Feb 19, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Feb 19, 2026

Uh oh!

codecov bot commented Feb 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

parasharrajat commented Feb 26, 2026

Uh oh!

MelvinBot commented Feb 26, 2026

Uh oh!

MelvinBot commented Feb 26, 2026

Uh oh!

parasharrajat commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

Uh oh!

parasharrajat commented Mar 15, 2026

Uh oh!

melvin-bot bot commented Mar 15, 2026

Uh oh!

MelvinBot commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

parasharrajat Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

lakchote commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

parasharrajat commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Mar 19, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

Reviewers

codecov bot commented Feb 19, 2026 •

edited by github-actions bot

Loading

parasharrajat commented Feb 26, 2026 •

edited

Loading

lakchote commented Mar 17, 2026 •

edited

Loading

parasharrajat commented Mar 17, 2026 •

edited

Loading