[No QA] Perf: Extract Search and Workspaces tab buttons to isolate Onyx subscriptions by BartekObudzinski · Pull Request #82902 · Expensify/App

BartekObudzinski · 2026-02-19T09:11:12Z

Explanation of Change

This PR extracts SearchTabButton and WorkspacesTabButton into separate components from NavigationTabBar, isolating approximately 33 Onyx subscriptions from the parent component's render path. This prevents unnecessary re-renders of the NavigationTabBar when Onyx data specific to these tabs changes.

The performance improvement is measurable: the ManualNavigateToInboxTab telemetry span improved by ~220ms (measured 10x on the same edge case scenario).

This is purely a structural optimization with no functional changes. The button behavior, accessibility, and visual appearance remain identical.

Fixed Issues

$ #82940
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…riptions

…orkspaces-tab-buttons # Conflicts: # src/components/Navigation/NavigationTabBar/index.tsx

codecov · 2026-02-19T09:20:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...onents/Navigation/NavigationTabBar/getLastRoute.ts	`100.00% <100.00%> (ø)`
...c/components/Navigation/NavigationTabBar/index.tsx	`55.40% <60.00%> (+2.93%)`	⬆️
...ents/Navigation/NavigationTabBar/getTabIconFill.ts	`0.00% <0.00%> (ø)`
...avigation/NavigationTabBar/WorkspacesTabButton.tsx	`76.47% <76.47%> (ø)`
...ts/Navigation/NavigationTabBar/SearchTabButton.tsx	`51.85% <51.85%> (ø)`
... and 20 files with indirect coverage changes

adhorodyski · 2026-02-19T13:33:38Z

src/components/Navigation/NavigationTabBar/getTabIconFill.ts

@@ -0,0 +1,13 @@
+import type {ThemeColors} from '@styles/theme/types';
+
+function getTabIconFill(theme: ThemeColors, isSelected: boolean, isHovered: boolean): string {


2nd and 3rd arguments can be a config object instead in case you wan to add more later

adhorodyski

can't tell you how much I love it

JKobrynski

Looking good!

JKobrynski · 2026-02-19T13:36:55Z

src/components/Navigation/NavigationTabBar/getLastRoute.ts

+
+function getLastRoute(rootState: NavigationState, navigator: ValueOf<typeof NAVIGATORS>, screen: Screen) {
+    const lastNavigator = rootState.routes.findLast((route) => route.name === navigator);
+    const lastNavigatorState = lastNavigator && lastNavigator.key ? getPreservedNavigatorState(lastNavigator?.key) : undefined;


NAB:

I know this code was moved from somewhere else not written by you, but I think this would be enough 😄

lastNavigator?.key ? getPreservedNavigatorState(lastNavigator?.key) : undefined;

the ? inside of () is actually redundant, already present inside the first ?: ternary block

…meters and simplify last route retrieval logic

melvin-bot · 2026-02-19T14:46:20Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001

this looks great!

ChavdaSachin · 2026-02-19T18:02:03Z

Does this need my review?

JS00001 · 2026-02-19T18:02:50Z

@ChavdaSachin could you run through the checklist please?

ChavdaSachin · 2026-02-19T18:04:56Z

Lemme take a quick look at code and complete the checklist then.

ChavdaSachin

LGTM

ChavdaSachin · 2026-02-19T18:14:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

NA

JS00001 · 2026-02-19T18:15:49Z

OSBotify · 2026-02-19T18:23:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-19T19:18:20Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-19T19:22:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82902.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6a7429c-1fe8027-9f4bae31f0820d093e22a2b27ecdb8bdf6cea757/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6a7429c-1fe8027-8970d98e20f59e4f456faea2d2ac963d5f0195ce/index.html

Web 🕸️
https://82902.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-20T16:44:01Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-23T21:45:43Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

BartekObudzinski added 2 commits February 19, 2026 10:07

Perf: Extract Search and Workspaces tab buttons to isolate Onyx subsc…

ef37bbe

…riptions

Merge remote-tracking branch 'origin/main' into perf/extract-search-w…

0a15436

…orkspaces-tab-buttons # Conflicts: # src/components/Navigation/NavigationTabBar/index.tsx

melvin-bot bot assigned BartekObudzinski Feb 19, 2026

adhorodyski reviewed Feb 19, 2026

View reviewed changes

adhorodyski approved these changes Feb 19, 2026

View reviewed changes

JKobrynski reviewed Feb 19, 2026

View reviewed changes

Refactor: Update getTabIconFill function to accept an object for para…

f9a685c

…meters and simplify last route retrieval logic

mountiny mentioned this pull request Feb 19, 2026

[Due for payment 2026-03-02] Extract Search and Workspaces tab buttons to isolate Onyx re-renders #82940

Closed

BartekObudzinski marked this pull request as ready for review February 19, 2026 14:46

BartekObudzinski requested review from a team as code owners February 19, 2026 14:46

melvin-bot bot requested review from ChavdaSachin and joekaufmanexpensify and removed request for a team February 19, 2026 14:46

melvin-bot bot removed the request for review from a team February 19, 2026 14:46

luacmartins self-requested a review February 19, 2026 14:57

JS00001 approved these changes Feb 19, 2026

View reviewed changes

luacmartins approved these changes Feb 19, 2026

View reviewed changes

ChavdaSachin approved these changes Feb 19, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 February 19, 2026 18:14

JS00001 approved these changes Feb 19, 2026

View reviewed changes

JS00001 merged commit 6a7429c into Expensify:main Feb 19, 2026
31 of 34 checks passed

OSBotify mentioned this pull request Feb 20, 2026

Deploy Checklist: New Expensify 2026-02-20 #83077

Closed

67 tasks

		@@ -0,0 +1,13 @@
		import type {ThemeColors} from '@styles/theme/types';

		function getTabIconFill(theme: ThemeColors, isSelected: boolean, isHovered: boolean): string {

Conversation

BartekObudzinski commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adhorodyski Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski left a comment

Choose a reason for hiding this comment

Uh oh!

JKobrynski left a comment

Choose a reason for hiding this comment

Uh oh!

JKobrynski Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 19, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin commented Feb 19, 2026

Uh oh!

JS00001 commented Feb 19, 2026

Uh oh!

ChavdaSachin commented Feb 19, 2026

Uh oh!

ChavdaSachin left a comment

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

JS00001 commented Feb 19, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

BartekObudzinski commented Feb 19, 2026 •

edited

Loading

codecov bot commented Feb 19, 2026 •

edited by github-actions bot

Loading

adhorodyski Feb 19, 2026 •

edited

Loading

ChavdaSachin commented Feb 19, 2026 •

edited

Loading