Skip to content

[No QA] Add hidden upgrade guide for personal workspace to Collect plan#83059

Merged
twisterdotcom merged 4 commits intomainfrom
garrettmknight-patch-4
Feb 20, 2026
Merged

[No QA] Add hidden upgrade guide for personal workspace to Collect plan#83059
twisterdotcom merged 4 commits intomainfrom
garrettmknight-patch-4

Conversation

@garrettmknight
Copy link
Contributor

This document explains the upgrade process from a personal workspace to the Collect plan, detailing changes in billing, settings migration, and feature availability.

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/588858
PROPOSAL: add a hidden help page to describe the paid personal workspace > collect workspace migration so AZ can use it when answering questions.

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

This document explains the upgrade process from a personal workspace to the Collect plan, detailing changes in billing, settings migration, and feature availability.
@garrettmknight garrettmknight self-assigned this Feb 20, 2026
@garrettmknight garrettmknight requested a review from a team as a code owner February 20, 2026 14:46
@melvin-bot melvin-bot bot requested review from brunovjk and removed request for a team February 20, 2026 14:46
@melvin-bot
Copy link

melvin-bot bot commented Feb 20, 2026

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@garrettmknight garrettmknight removed the request for review from brunovjk February 20, 2026 14:48
@garrettmknight garrettmknight changed the title Add hidden upgrade guide for personal workspace to Collect plan [No QA] Add hidden upgrade guide for personal workspace to Collect plan Feb 20, 2026
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new hidden help page (docs/Hidden/upgrade-personal-workspace-to-collect-plan.md) that explains the migration path from paid personal workspaces (Track/Submit) to the Collect plan. The document is well-structured, covers the topic comprehensively, and addresses anticipated user concerns through both body content and an FAQ section. There are a few issues to address -- a typo, a tense inconsistency, a missing FAQ wrapper, and a potential overlap with an existing page -- but overall this is a solid addition.

Scores Summary

  • Readability: 8/10 - Clear, well-organized content with logical section flow. Short paragraphs and bullet points make it scannable. Minor issues: a typo ("workpsace" on line 72, "disocount" on line 91), and a tense shift in the numbered list under "What Happens During the Collect Plan Upgrade" (headings use present tense but the list items use past tense: "Created", "Copied", "Moved" instead of "Creates", "Copies", "Moves").
  • AI Readiness: 9/10 - Excellent YAML metadata with well-formed internalScope, rich keywords list, and descriptive title/description. Headings are descriptive and use full task phrasing (e.g., "How Submit Workspaces Work After the Collect Plan Upgrade"). Heading hierarchy uses only # and ## (with one ### exception under billing, which is acceptable as a sub-topic). No vague references; context is self-contained.
  • Style Compliance: 7/10 - The FAQ section uses raw Markdown (# FAQ with ## sub-headings) instead of the Jekyll {% include faq-begin.md %} / {% include faq-end.md %} wrapper pattern used by other hidden pages in the repo (see Upgrade-to-a-Collect-Plan.md and TEMPLATE.md). Additionally, there is an existing hidden page at docs/Hidden/Upgrade-to-a-Collect-Plan.md covering a related Collect plan upgrade scenario -- consider whether these two pages should cross-reference each other or be consolidated to avoid user confusion.

Key Findings

Positive aspects:

  • The document thoroughly addresses a complex migration scenario with clear before/after explanations.
  • The internalScope field is well-written and follows the recommended format ("Audience is... Covers... Does not cover...").
  • The keyword list is comprehensive and includes internal identifiers (wasDuplicatedFromPersonal2026) that will aid support tooling.
  • Section structure mirrors a user's natural questions: who is affected, what happened, what changed, what to do next.
  • The FAQ section anticipates real user questions (SmartScan cancellation, "Group" label confusion, billing for 2 members).

Issues to address:

  1. Typos: "workpsace" (line 72) should be "workspace"; "disocount" (line 91) should be "discount".
  2. Tense inconsistency: In "What Happens During the Collect Plan Upgrade", the intro says "When your workspace is upgraded, we:" (present tense) but the numbered steps use past tense ("Created", "Copied", "Moved"). These should be consistent -- either present tense throughout ("Create a new Collect workspace", "Copy your relevant settings...") or past tense with matching intro ("When your workspace was upgraded, we:").
  3. Missing FAQ wrapper: The FAQ section should use {% include faq-begin.md %} and {% include faq-end.md %} instead of a raw # FAQ heading, to match the pattern used in other hidden help pages and the documentation template.
  4. Potential overlap: docs/Hidden/Upgrade-to-a-Collect-Plan.md covers upgrading from a Free plan to Collect, and docs/Hidden/collect-upgrade.md covers Collect-to-Control upgrades. This new page covers personal-workspace-to-Collect. These are distinct scenarios, but it may help to add a brief note or link distinguishing this page from the existing Collect upgrade pages, especially for support agents who may land on the wrong one.

Recommendations

  1. Fix the two typos ("workpsace" and "disocount") before merging.
  2. Normalize tense in the numbered migration steps to match the introductory clause.
  3. Adopt the FAQ include pattern ({% include faq-begin.md %} / {% include faq-end.md %}) for consistency with the rest of the hidden docs. This also ensures the FAQ renders correctly with the collapsible HTML wrapper used by the Jekyll site.
  4. Consider cross-referencing the existing Upgrade-to-a-Collect-Plan.md and collect-upgrade.md pages to help support agents quickly identify which upgrade scenario applies.

Files Reviewed

  • docs/Hidden/upgrade-personal-workspace-to-collect-plan.md (new file, 198 lines) -- Well-structured migration guide with comprehensive coverage; needs typo fixes, tense normalization, and FAQ wrapper alignment.

Review performed by HelpDot Summary Reviewer.

Correct typos in the upgrade documentation regarding the Collect Plan.
garrettmknight and others added 2 commits February 20, 2026 06:50
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OSBotify
Copy link
Contributor

OSBotify commented Feb 20, 2026

A preview of your ExpensifyHelp changes have been deployed to https://319916b2.helpdot.pages.dev ⚡️

Updated articles:

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bb5117b65

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@twisterdotcom twisterdotcom merged commit 4e37992 into main Feb 20, 2026
15 of 16 checks passed
@twisterdotcom twisterdotcom deleted the garrettmknight-patch-4 branch February 20, 2026 15:05
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.3.24-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants