[No QA] Optimize ExpenseReportListItemRow - Split ActionCell into smaller components by jmusial · Pull Request #83079 · Expensify/App

jmusial · 2026-02-20T16:09:11Z

Explanation of Change

Move pay-specific hooks out of ActionCell into PayActionCell

The original ActionCell called all pay-related hooks unconditionally at the component top level — useReportWithTransactionsAndViolations, usePolicy, useOnyx(BANK_ACCOUNT_LIST), useOnyx(chatReport), and canIOUBePaid (×2) — for every row in the search results, even rows with a VIEW, SUBMIT, or APPROVE action.

These hooks are now scoped to PayActionCell, which only mounts for rows where action === 'pay'. This removes several Onyx subscriptions and computations per non-PAY row.

Perf improvement

For the the whole Home -> Reports nav

For ExpenseReportListItemRow Component

The improvement should be visible everywhere where ActionCell was used. Not only Reports

Methodology

Measured on account with 10 reports with in different CONST.SEARCH.ACTION_TYPES.
Times are avg between 5 measurements for before and after.

[No QA] added as this is just a refactor.

Fixed Issues

$ #82428
PROPOSAL:

Tests

Open the app
Go to Reports page
Verify that ActionButtons are there and working as expected

Offline tests

N/A

QA Steps

N / A

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

jmusial · 2026-02-20T16:11:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9712947112

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/SelectionListWithSections/Search/ActionCell/index.tsx

codecov · 2026-02-20T16:21:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ConnectToNetSuiteFlow/index.tsx	`0.00% <ø> (ø)`
...ections/Search/ActionCell/actionTranslationsMap.ts	`100.00% <100.00%> (ø)`
src/pages/workspace/accounting/netsuite/utils.ts	`0.00% <ø> (ø)`
...ectionListWithSections/Search/ActionCell/index.tsx	`91.66% <91.66%> (ø)`
...WithSections/Search/ActionCell/BadgeActionCell.tsx	`0.00% <0.00%> (ø)`
...stWithSections/Search/ActionCell/PayActionCell.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

luacmartins · 2026-02-20T17:58:58Z

Nice! This is looking good! Let's mark it as ready for review!

adhorodyski · 2026-02-20T20:44:38Z

Can we get it tested against a really high traffic account?

jmusial · 2026-02-23T12:51:46Z

Perf improvement for `applausetester@applause.expensifail.com`

\

Methodology is same - 5 measurements before & after the change

For the the whole Home -> Reports nav

For ExpenseReportListItemRow Component

melvin-bot · 2026-02-23T12:53:44Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-23T12:57:03Z

src/components/SelectionListWithSections/Search/ActionCell/PayActionCell.tsx

+                enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
+                onPress={(type, payAsBusiness, methodID, paymentMethod) => confirmPayment(type as ValueOf<typeof CONST.IOU.PAYMENT_TYPE>, payAsBusiness, methodID, paymentMethod)}
+                style={[styles.w100, shouldDisablePointerEvents && styles.pointerEventsNone]}
+                wrapperStyle={[styles.w100]}


❌ CONSISTENCY-5 (docs)

This eslint-disable-next-line suppresses @typescript-eslint/prefer-nullish-coalescing without an accompanying comment explaining why the logical OR (||) is preferred over nullish coalescing (??) here.

Add a comment explaining the reason, for example:

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- We intentionally use || because empty string policyID should fall through to iouReport?.policyID policyID={policyID || iouReport?.policyID}

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

This is a valid comment (unless we specifically want to use iouReport?.policyID if policyID is 0 (CONST.DEFAULT_NUMBER_ID)

TBH - this part of code was just moved - earlier it was like this in src/components/SelectionListWithSections/Search/ActionCell.tsx#165.

IMO adding a comment like a bit suggests seems bit redundant, as the code is self explanatory here. WDYT ?

TBH - this part of code was just moved - earlier it was like this in

But why was it implemented like that initially? Is there a reason we must use (||) instead of (??)?
This is the only instance throughout the app where it's used for policyID

Ah, fair point I think it was introduced by this PR and I think there was no @typescript-eslint/prefer-nullish-coalescing rule at that point.

@getusha is there a reason you user || here ?

That seems like an oversight to me

@getusha is there a reason you user || here ?

I'm not really sure, but I think policyID can somehow be an empty string.

eVoloshchak · 2026-02-23T16:00:31Z

src/components/SelectionListWithSections/Search/ActionCell/PayActionCell.tsx

+                enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
+                onPress={(type, payAsBusiness, methodID, paymentMethod) => confirmPayment(type as ValueOf<typeof CONST.IOU.PAYMENT_TYPE>, payAsBusiness, methodID, paymentMethod)}
+                style={[styles.w100, shouldDisablePointerEvents && styles.pointerEventsNone]}
+                wrapperStyle={[styles.w100]}


This is a valid comment (unless we specifically want to use iouReport?.policyID if policyID is 0 (CONST.DEFAULT_NUMBER_ID)

src/components/SelectionListWithSections/Search/ActionCell/actionTranslationsMap.ts

eVoloshchak · 2026-02-23T19:40:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-23.at.21.00.25.mov

Android: mWeb Chrome

Screen.Recording.2026-02-23.at.20.58.32.mov

iOS: HybridApp

Screen.Recording.2026-02-23.at.20.51.13.mov

iOS: mWeb Safari

Screen.Recording.2026-02-23.at.20.53.48.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-23.at.20.48.36.mov

eVoloshchak

LGTM!

luacmartins

LGTM

OSBotify · 2026-02-23T20:17:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-23T20:20:52Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-23T20:41:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83079.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e9444bb-173a462-47c921220ffaf444c2ed902dbc7e6edb6c9840e2/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://83079.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-24T01:19:17Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-25T15:52:51Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Split ActionCell into smaller components

9712947

melvin-bot bot assigned jmusial Feb 20, 2026

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

src/components/SelectionListWithSections/Search/ActionCell/index.tsx Outdated Show resolved Hide resolved

jmusial mentioned this pull request Feb 20, 2026

[Due for payment 2026-03-16] [Due for payment 2026-03-11] [$250] [Performance] Optimize ExpenseReportListItemRow (~1.2ms × 50 = 60ms total) #82428

Closed

jmusial marked this pull request as ready for review February 23, 2026 12:53

jmusial requested review from a team as code owners February 23, 2026 12:53

melvin-bot bot requested review from eVoloshchak and heyjennahay and removed request for a team and heyjennahay February 23, 2026 12:53

melvin-bot bot removed the request for review from a team February 23, 2026 12:53

github-actions bot reviewed Feb 23, 2026

View reviewed changes

eVoloshchak suggested changes Feb 23, 2026

View reviewed changes

jmusial added 4 commits February 23, 2026 17:16

address review findings

987e2e0

Merge branch 'main' into perf/split-action-cell

c643ba3

Merge branch 'main' into perf/split-action-cell

a0440b2

fix prettier

158f7d8

eVoloshchak approved these changes Feb 23, 2026

View reviewed changes

melvin-bot bot requested a review from luacmartins February 23, 2026 20:02

luacmartins approved these changes Feb 23, 2026

View reviewed changes

luacmartins merged commit e9444bb into Expensify:main Feb 23, 2026
29 of 32 checks passed

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

Conversation

jmusial commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Move pay-specific hooks out of ActionCell into PayActionCell

Perf improvement

Methodology

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Feb 20, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

luacmartins commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhorodyski commented Feb 20, 2026

Uh oh!

jmusial commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf improvement for applausetester@applause.expensifail.com

For the the whole Home -> Reports nav

For ExpenseReportListItemRow Component

Uh oh!

melvin-bot bot commented Feb 23, 2026

Uh oh!

github-actions bot Feb 23, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-5 (docs)

Uh oh!

eVoloshchak Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

getusha Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eVoloshchak commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

jmusial commented Feb 20, 2026 •

edited

Loading

codecov bot commented Feb 20, 2026 •

edited by github-actions bot

Loading

luacmartins commented Feb 20, 2026 •

edited

Loading

jmusial commented Feb 23, 2026 •

edited

Loading

Perf improvement for `applausetester@applause.expensifail.com`

eVoloshchak commented Feb 23, 2026 •

edited

Loading