Fix: Error messages not announced by screen readers when displayed#83120
Closed
marufsharifi wants to merge 2 commits intoExpensify:mainfrom
Closed
Fix: Error messages not announced by screen readers when displayed#83120marufsharifi wants to merge 2 commits intoExpensify:mainfrom
marufsharifi wants to merge 2 commits intoExpensify:mainfrom
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
joekaufmanexpensify
approved these changes
Feb 25, 2026
Contributor
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine for product 👍
Contributor
Author
|
@suneox, kindly bump. thanks. |
Contributor
Author
|
@suneox, quick bump. thanks. |
Contributor
|
@marufsharifi There’s no difference in behavior in the existing code. We should ensure |
Contributor
|
@marufsharifi In addition to waiting for PR #82964, we're still waiting for confirmation of the detailed expected behavior. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Before, form validation errors were visible on screen but often not announced, so users could miss that something went wrong. Now, when an error message appears, it is marked as an alert on the web, which prompts screen readers to announce it immediately.
Fixed Issues
$ #74866
PROPOSAL: #74866 comment
Tests
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-25.at.3.13.00.PM.mov
Android: mWeb Chrome
w.mp4
iOS: Native
Screen.Recording.2026-02-25.at.3.43.31.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-25.at.3.47.05.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-25.at.3.14.06.PM.mov