[No QA] refactor getReportName to have 1 param#83177
Merged
tgolen merged 5 commits intoExpensify:mainfrom Feb 27, 2026
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
bot
requested review from
DylanDylann and
joekaufmanexpensify
and removed request for
a team and
joekaufmanexpensify
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| const reportID = report?.reportID; | ||
| const currentChatName = getReportName(report); | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-5 (docs)
This newly added eslint-disable-next-line lacks a justification comment explaining why the rule is disabled. Other files in this PR include tracking comments (e.g., // This will be fixed as follow up https://github.com/Expensify/App/pull/75357).
Add a comment above or on the same line explaining the reason for the disable, for example:
// This will be fixed as follow up https://github.com/Expensify/App/pull/75357
// eslint-disable-next-line @typescript-eslint/no-deprecated
const currentChatName = getReportName({report});Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
Author
There was a problem hiding this comment.
Ignore lint check because we just need to refactor the getReportName function
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #66411 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Contributor
|
cc @tgolen |
tgolen
requested changes
Feb 25, 2026
| reports?: Report[]; | ||
| policies?: Policy[]; | ||
| isReportArchived?: boolean; | ||
| conciergeReportID?: string; |
Contributor
There was a problem hiding this comment.
It would be really great if there were more explicit comments on the parameters in the type so people understand what their purpose is and when it's OK to pass it or not. Could you please add that for the two new parameters? Bonus points if you do it for all the parameters!
Contributor
Author
There was a problem hiding this comment.
In this PR, I just updated the GetReportNameParams type so I've added the comments for reportAttributes and conciergeReportID. Can you please check again?
tgolen
previously approved these changes
Feb 26, 2026
Contributor
tgolen
left a comment
tgolen
left a comment
There was a problem hiding this comment.
That's nice. Thanks! This PR picked up a conflict in the meantime
Contributor
Author
|
@tgolen Done |
tgolen
approved these changes
Feb 27, 2026
Contributor
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.28-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.30-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #66411
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-23.at.15.29.58.mov