Add personal card empty state, warning flow and upgrade flow by narefyev91 · Pull Request #83211 · Expensify/App

narefyev91 · 2026-02-23T14:20:14Z

Explanation of Change

Add personal card empty state, warning flow and upgrade flow

Fixed Issues

$ #78390
$ #78393
$ #78394
$ #78395

Tests

Empty flow:

Open wallet page
Verify that user sees Add personal card button
If user does not have any company card setup - banner in the bottom should be shown

Upgrade path:

Have more than 2 personal cards and not paid workspace
Click on Add personal card - Verify that upgrade screens with Create new workspace is shown
Create new workspace - verify that new workspaces created/success page is shown

Warning page:

User should be a part of workspace with company card existing direct feed
Click on add personal card - verify that warning message is shown with 2 buttons "personal card" and "ask admin"
Ask admin should open expense chat of the workspace
If user is admin - should see different copy and 2 buttons "personal card" and "company card"

Verify that no errors appear in the JS console

Offline tests

Should working the same as in online

QA Steps

Pre-condition: user is on the personalCardImport beta

Empty flow:

Open wallet page
Verify that user sees Add personal card button
If user does not have any company card setup - banner in the bottom should be shown

Upgrade path:

Have more than 2 personal cards and not paid workspace
Click on Add personal card - Verify that upgrade screens with Create new workspace is shown
Create new workspace - verify that new workspaces created/success page is shown

Warning page:

User should be a part of workspace with company card existing direct feed
Click on add personal card - verify that warning message is shown with 2 buttons "personal card" and "ask admin"
Ask admin should open expense chat of the workspace
If user is admin - should see different copy and 2 buttons "personal card" and "company card"

For users NOT on the beta:
Verify Add personal card button does NOT show on the Wallet page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile

# Conflicts: # src/SCREENS.ts # src/libs/CardUtils.ts

# Conflicts: # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/types.ts # src/pages/settings/Wallet/WalletPage/index.tsx # src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

# Conflicts: # src/pages/settings/Wallet/WalletPage/index.tsx

melvin-bot · 2026-02-23T14:20:20Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

narefyev91 · 2026-02-23T14:21:03Z

@joekaufmanexpensify i think you could run ad-hoc and test these 3 issues:
#78390,
#78393,
#78394

github-actions · 2026-02-23T14:24:06Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-02-23T14:30:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
src/ROUTES.ts	`15.34% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/components/Icon/chunks/illustrations.chunk.ts	`0.00% <ø> (ø)`
src/components/Section/index.tsx	`92.00% <100.00%> (ø)`
src/libs/CardFeedUtils.ts	`88.75% <100.00%> (ø)`
src/libs/CardUtils.ts	`81.91% <100.00%> (ø)`
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/actions/ImportTransactions.ts	`59.01% <ø> (ø)`
... and 12 more
... and 17 files with indirect coverage changes

github-actions · 2026-02-24T17:27:54Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-24T17:31:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83211.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://83211.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2026-02-24T17:53:58Z

BUG:

Not seeing Company cards warning - employee when accessing the personal card flow from a non-admin member of a workspace with a company card feed. The admin warning is working as expected for admins though.

2026-02-24_12-52-59.mp4

joekaufmanexpensify · 2026-02-24T18:06:35Z

Maybe BUG: Company cards ad banner is not flush with bottom of Assigned cards section

It was in the design doc . I feel like that might look slightly better, cc @Expensify/design in case you have thoughts on this.

Note: the Import transactions button is behind a separate beta and will be moving inside of the Add personal card flow once this PR is done. So while its placement looks odd now, it shouldn't actually be shipped to customers like this. cc @dylanexpensify

Design doc

PR

joekaufmanexpensify · 2026-02-24T18:10:20Z

@narefyev91 is there a reason this list of countries is not alphabetical? I would expect it to be.

joekaufmanexpensify · 2026-02-24T18:12:12Z

I see it isn't actually possible to connect new personal cards yet on the adhoc, but will continue once it is 👍

shawnborton · 2026-02-24T18:44:45Z

Agree with you Joe, looks like it's not matching the DD specs.

narefyev91 · 2026-02-25T08:34:33Z

BUG:

Not seeing Company cards warning - employee when accessing the personal card flow from a non-admin member of a workspace with a company card feed. The admin warning is working as expected for admins though.

2026-02-24_12-52-59.mp4

@joekaufmanexpensify for this one - issue related to missing data in Onyx. To make it working currently your test user should open workspace with company card feed. After that on wallet page you would be able to see warning RHP.
Problem here - that OpenPaymentsPage API call is not return "sharedNVP_private_domain_member_18441278" keys
(which has information about available feeds).
To make it working we need to adjust OpenPaymentsPage to return that data.

Before going to workspace:

Goes to workspace:

After coming back from workspace with feed:

Click on add personal card:

github-actions · 2026-03-04T13:52:23Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-04T13:56:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83211.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://83211.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2026-03-04T17:54:58Z

@ShridharGoel could you check on the Travel CVV thing since you already have an account with that setup?

joekaufmanexpensify · 2026-03-04T18:01:51Z

Confirmed BUG: showing HTML tags in employee and admin warnings and Maybe BUG: Ask your admin button for employee warning not working are fixed 👍

joekaufmanexpensify · 2026-03-04T18:24:21Z

Started a thread on this archived workspaces thing so we can align more quickly.

joekaufmanexpensify · 2026-03-04T21:17:26Z

@Expensify/design is there supposed to be a standard amount of space between the header and title on pages in a "flow" to add something? I noticed the gap at the top on a few of the personal card pages looks slightly larger than in the bank account flow, but not sure if this is a standardized thing.

Existing bank account flow

New personal card warning pages

ShridharGoel · 2026-03-05T08:12:28Z

Travel card placement looks fine now

Screen.Recording.2026-03-05.at.1.41.34.PM.mov

narefyev91 · 2026-03-05T08:56:46Z

@Expensify/design is there supposed to be a standard amount of space between the header and title on pages in a "flow" to add something? I noticed the gap at the top on a few of the personal card pages looks slightly larger than in the bank account flow, but not sure if this is a standardized thing.

Existing bank account flow
### New personal card warning pages

yeah it should be the same padding - already updated. Thanks!

src/selectors/Card.ts

ShridharGoel · 2026-03-05T13:49:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-05.at.7.39.21.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-03-05.at.7.40.03.PM.mov

iOS: HybridApp

Screen.Recording.2026-03-05.at.7.24.49.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-05.at.7.25.45.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-05.at.7.20.05.PM.mov

ShridharGoel · 2026-03-05T13:52:56Z

@narefyev91 @joekaufmanexpensify Is it expected to not see the company cards banner here?

Screen.Recording.2026-03-05.at.7.22.23.PM.mov

joekaufmanexpensify · 2026-03-05T13:55:09Z

Yes, expected. We're only supposed to show it on the empty state. It's removed when the user has any kind of personal or company card.

amyevans

Looks great! 🚀

github-actions · 2026-03-05T14:33:32Z

🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-05T14:38:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83211.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8575dc0-18d2287-e648523f04e5106217dae3b5cf5c74d08a223e9e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8575dc0-18d2287-5eaa4bf14ee6d54997288fd2457eb78c4d7ba3bb/index.html

Web 🕸️
https://83211.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-05T14:41:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T04:14:30Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mitarachim · 2026-03-06T04:35:46Z

Deploy Blocker #84357 was identified to be related to this PR.

kavimuru · 2026-03-06T15:50:59Z

@narefyev91 @amyevans @joekaufmanexpensify
Pre-condition: user is on the personalCardImport beta

Is applause.expensifail.com domain is under beta to test this one? Also applause cannot add personal cards.

joekaufmanexpensify · 2026-03-06T15:58:30Z

@kavimuru you can hold off from testing since it is behind beta and relies on another PRs to be fully functional. I will check it off

OSBotify · 2026-03-06T22:43:43Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

narefyev91 added 13 commits January 26, 2026 10:41

Add personal card

b8e614b

more logic

aa53fb4

Merge branch 'refs/heads/main' into add-personal-card

9731c27

add logic for non us

92fdb37

Merge branch 'refs/heads/main' into add-personal-card

e7a6b8f

# Conflicts: # src/SCREENS.ts # src/libs/CardUtils.ts

add empty personal card

55814d7

add logic for start adding personal card

880e39a

Merge branch 'refs/heads/main' into add-personal-card

3dfc43a

# Conflicts: # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/types.ts # src/pages/settings/Wallet/WalletPage/index.tsx # src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

warning for create personal card

24695cd

add warning for admin/user

b0908c9

Merge branch 'refs/heads/main' into add-personal-card

dcfc048

# Conflicts: # src/pages/settings/Wallet/WalletPage/index.tsx

error for adding card

55896b9

Merge branch 'refs/heads/main' into add-personal-card

0fbacc1

# Conflicts: # src/pages/settings/Wallet/WalletPage/index.tsx

melvin-bot bot assigned narefyev91 Feb 23, 2026

This comment has been minimized.

Sign in to view

amyevans mentioned this pull request Feb 23, 2026

[Personal card import] [R3] Assigned cards empty state #78390

Open

narefyev91 added 2 commits February 24, 2026 11:58

fix checks

bfa95ca

Merge branch 'main' into add-personal-card

a101cb7

move travel to company cards

9106218

narefyev91 added 2 commits March 5, 2026 10:35

remove padding

e3dfe37

Merge branch 'main' into add-personal-card

0b2fde2

ShridharGoel approved these changes Mar 5, 2026

View reviewed changes

src/selectors/Card.ts Outdated Show resolved Hide resolved

chaining

327a9fc

ShridharGoel approved these changes Mar 5, 2026

View reviewed changes

rollback comments

fea9c2e

amyevans approved these changes Mar 5, 2026

View reviewed changes

amyevans merged commit 8575dc0 into Expensify:main Mar 5, 2026
31 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

mitarachim mentioned this pull request Mar 6, 2026

Wallet - Add personal card button is not responsive #84357

Closed

7 tasks

Conversation

narefyev91 commented Feb 23, 2026 • edited by amyevans Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 23, 2026

Uh oh!

narefyev91 commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

This comment has been minimized.

codecov bot commented Feb 23, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

joekaufmanexpensify commented Feb 24, 2026

BUG:

Uh oh!

joekaufmanexpensify commented Feb 24, 2026

Maybe BUG: Company cards ad banner is not flush with bottom of Assigned cards section

Design doc

PR

Uh oh!

joekaufmanexpensify commented Feb 24, 2026

Uh oh!

joekaufmanexpensify commented Feb 24, 2026

Uh oh!

shawnborton commented Feb 24, 2026

Uh oh!

narefyev91 commented Feb 25, 2026

BUG:

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

joekaufmanexpensify commented Mar 4, 2026

Uh oh!

joekaufmanexpensify commented Mar 4, 2026

Uh oh!

joekaufmanexpensify commented Mar 4, 2026

Uh oh!

joekaufmanexpensify commented Mar 4, 2026

Existing bank account flow

New personal card warning pages

Uh oh!

ShridharGoel commented Mar 5, 2026

Uh oh!

narefyev91 commented Mar 5, 2026

Existing bank account flow

Uh oh!

Uh oh!

ShridharGoel commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Mar 5, 2026

Uh oh!

joekaufmanexpensify commented Mar 5, 2026

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

narefyev91 commented Feb 23, 2026 •

edited by amyevans

Loading

codecov bot commented Feb 23, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Mar 5, 2026 •

edited

Loading