[No QA] Fix Android AdHoc build artifact paths#83238
Merged
roryabraham merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
The AAB and sourcemap upload paths had 'release/' hardcoded, but Adhoc builds output to 'adhoc/'. Use wildcards to match both variants. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Wildcards in upload-artifact paths preserve the variant subdirectory inside the artifact, breaking downstream jobs that expect files at the root (e.g. deploy.yml's createRelease expects Expensify-release.aab directly). Copy AAB and sourcemap to a flat staging dir first. Co-authored-by: Cursor <cursoragent@cursor.com>
Julesssss
approved these changes
Feb 23, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
51 tasks
51 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.25-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes a regression from #81269 where
buildAndroid.ymlhadrelease/hardcoded in the AAB and sourcemap artifact upload paths. ForAdhocbuilds, Gradle outputs to anadhoc/directory, so those uploads (and the downstream APK generation) fail.Uses wildcards (
*) instead of hardcoded variant names to work for bothReleaseandAdhocbuilds.Fixed Issues
Fixes the
testBuildOnPushfailure: https://github.com/Expensify/App/actions/runs/22322244001/job/64583355295Tests
None.
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop