fix: Added better error handling for AddTrackedExpenseToPolicy API by Uzaifm127 · Pull Request #83322 · Expensify/App

Uzaifm127 · 2026-02-24T13:10:32Z

Explanation of Change

In this PR, we are adding better error handling (by removing the ghost IOU report created after submitting the expense from self DM to workspace) to AddTrackedExpenseToPolicy API.

Fixed Issues

$ #78359
PROPOSAL: #78359 (comment)

Tests

Click on FAB > Create expense.
Create a manual expense and submit it to self DM.
Tap on "Submit it to someone" option on whisper message and Select a workspace.
Open test-tools and enable "Simulate failing network requests" option.
Now submit the expense to the selected workspace.
Verify that there is no IOU/Expense report created on workspace chat.
Verify that the error is appearing correctly in self DM with message "Unexpected error submitting this expense. Please try again later".

Verify that no errors appear in the JS console

Offline tests

We are implementing better error handling which doesn't require offline behaviour.

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-native.mp4

Android: mWeb Chrome

Android-mweb.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

macOS.mp4

melvin-bot · 2026-02-24T13:10:40Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Uzaifm127 · 2026-02-24T13:11:51Z

I was having problem while recording on Android, will add recordings on android later.

codecov · 2026-02-24T13:17:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/index.ts	`72.58% <17.39%> (+1.38%)`	⬆️
... and 638 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a37b0ed748

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/index.ts

joekaufmanexpensify

Good for product 👍

…sts already otherwise it'll be cleared

Uzaifm127 · 2026-02-26T14:58:17Z

Added the recordings on Android and added the codex suggestion.

Uzaifm127 · 2026-03-02T12:37:05Z

@suneox Bump for updates on this PR, Thanks.

suneox · 2026-03-03T14:12:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

CleanShot.2026-03-11.at.01.54.51.5.mp4

Android: mWeb Chrome

CleanShot.2026-03-11.at.01.52.13.4.mp4

iOS: HybridApp

CleanShot.2026-03-11.at.01.50.34.3.mp4

iOS: mWeb Safari

CleanShot.2026-03-11.at.01.47.50.2.mp4

MacOS: Chrome / Safari

CleanShot.2026-03-11.at.01.44.11.1.mp4

suneox · 2026-03-03T17:56:03Z

@Uzaifm127 When reverting optimistic data in cases where an existing report group is present, the red dot still appears on the report group.

CleanShot.2026-03-04.at.00.46.36.1.mp4

suneox · 2026-03-03T17:59:23Z

src/libs/actions/IOU/index.ts

+        const additionalFailureData: Array<OnyxUpdate<BuildOnyxDataForMoneyRequestKeys>> = [];
+        const iouReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${iouParams.reportID}`];
+        const shouldClearOptimisticIOUReport = !iouReport || iouReport.pendingFields?.createChat === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD;
+


We can move logic rebuild the additionalFailureData into getConvertTrackedExpenseInformation function

Moved the entire logic of building the additional failure data to a new function.

Uzaifm127 · 2026-03-05T15:40:33Z

@suneox Apology for the delay, will look into this and provide the updates within 2 days.

…dm and move the additional failure data building logic in a function

Uzaifm127 · 2026-03-06T12:35:09Z

@Uzaifm127 When reverting optimistic data in cases where an existing report group is present, the red dot still appears on the report group.

Fixed.

mac-os.mp4

Uzaifm127 · 2026-03-10T12:02:58Z

@suneox Bump for updates here. Thanks.

suneox · 2026-03-10T19:10:11Z

@suneox Bump for updates here. Thanks.

The fallback functionality for failed values works. I’ve also updated the checklist

github-actions · 2026-03-11T20:18:39Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-11T20:23:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83322.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5306b9d-3d8daef-099d81665ef12600a5f8ac96537ab5e10588fd80/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5306b9d-3d8daef-ae8b58dc5f8cb54e133be47276fdc45cb2f262bb/index.html

Web 🕸️
https://83322.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-12T23:17:17Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.37-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-03-13T08:42:53Z

@Uzaifm127 @suneox Could you please confirm what is expected behaviour when disable simulate network failure request? The expense automatically moves to the workspace chat without retrying the submission. The expense disappears from Self DM. Is this an issue?

Bug7101868_1773386724651.Screenrecorder-2026-03-13-12-44-23-704.mp4

suneox · 2026-03-13T12:42:06Z

@Uzaifm127 @suneox Could you please confirm what is expected behaviour when disable simulate network failure request? The expense automatically moves to the workspace chat without retrying the submission. The expense disappears from Self DM. Is this an issue?

Bug7101868_1773386724651.Screenrecorder-2026-03-13-12-44-23-704.mp4

@jponikarchuk Currently, the "Simulate Network Failure" function automatically retries after it is turned off so this behavior is expected. When Simulate Network Failure is enabled, the expense shows an error in Self DM because the request fails. After it is turned off, the error disappears as the request automatically retries.

The current PR improves how the previous state is restored. You can compare this with the behavior before this PR, where the error still remained even after the request succeeded

Uzaifm127 · 2026-03-13T12:56:20Z

@jponikarchuk Same as @suneox said. Simulate Network Failure always retries when we turn it off.

OSBotify · 2026-03-16T10:05:43Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Added better error handling for AddTrackedExpenseToPolicy API

a37b0ed

Uzaifm127 requested review from a team as code owners February 24, 2026 13:10

melvin-bot bot assigned Uzaifm127 Feb 24, 2026

melvin-bot bot requested review from joekaufmanexpensify and suneox and removed request for a team February 24, 2026 13:10

melvin-bot bot removed the request for review from a team February 24, 2026 13:10

chatgpt-codex-connector bot reviewed Feb 24, 2026

View reviewed changes

src/libs/actions/IOU/index.ts Outdated Show resolved Hide resolved

joekaufmanexpensify previously approved these changes Feb 24, 2026

View reviewed changes

Uzaifm127 added 2 commits February 26, 2026 20:24

added a check where optimistic preview action will be restored if exi…

321988d

…sts already otherwise it'll be cleared

Merge branch 'main' of https://github.com/Uzaifm127/App into fix/78359

8921de2

Uzaifm127 dismissed joekaufmanexpensify’s stale review via 8921de2 February 26, 2026 14:55

Uzaifm127 mentioned this pull request Feb 26, 2026

[Due for payment 2026-03-23] [$250] Report-Error and infinite loading when submitting track expense to WS with workflows disabled #78359

Closed

7 tasks

suneox reviewed Mar 3, 2026

View reviewed changes

fix the RBR appearing on group of expenses when submitting from self …

82d1bbf

…dm and move the additional failure data building logic in a function

suneox approved these changes Mar 11, 2026

View reviewed changes

melvin-bot bot requested a review from Valforte March 11, 2026 13:34

Valforte approved these changes Mar 11, 2026

View reviewed changes

Valforte merged commit 5306b9d into Expensify:main Mar 11, 2026
30 of 31 checks passed

github-actions bot mentioned this pull request Mar 11, 2026

Investigate workflow job failing on main: test / test (job 8) #84955

Closed

OSBotify mentioned this pull request Mar 12, 2026

Deploy Checklist: New Expensify 2026-03-12 #85146

Closed

87 tasks

Conversation

Uzaifm127 commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 24, 2026

Uh oh!

Uzaifm127 commented Feb 24, 2026

Uh oh!

codecov bot commented Feb 24, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uzaifm127 commented Feb 26, 2026

Uh oh!

Uzaifm127 commented Mar 2, 2026

Uh oh!

suneox commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox commented Mar 3, 2026

Uh oh!

suneox Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uzaifm127 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uzaifm127 commented Mar 5, 2026

Uh oh!

Uzaifm127 commented Mar 6, 2026

Uh oh!

Uzaifm127 commented Mar 10, 2026

Uh oh!

suneox commented Mar 10, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

jponikarchuk commented Mar 13, 2026

Uh oh!

suneox commented Mar 13, 2026

Uh oh!

Uzaifm127 commented Mar 13, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uzaifm127 commented Feb 24, 2026 •

edited

Loading

codecov bot commented Feb 24, 2026 •

edited by github-actions bot

Loading

suneox commented Mar 3, 2026 •

edited

Loading