Migrate `BaseImage` web component to expo-image by VickyStash · Pull Request #83325 · Expensify/App

VickyStash · 2026-02-24T13:44:28Z

Explanation of Change

Migrate web BaseImage from react-native Image to expo-image

Replace react-native Image with expo-image Image in BaseImage.tsx (web), aligning it with the native implementation
Remove the react-native-web image header support patch (+003+image-header-support.patch) since expo-image handles HTTP headers natively
Use recyclingKey prop instead of the React key for image recycling

Fixed Issues

$ #33725
#9402
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open the app
Open a chat that has image attachments and expenses with receipts.
Make sure attachments are loaded correctly.
3.1 Open any attachment, see it loads correctly
Make sure receipts images are loaded as expected:
- in the expenses preview
- in the transactions row
- on the transaction thread screen
Open the Reports tab -> Expenses, make sure the receipts previews are correctly loaded in the table. On web: hover over any receipt image and make sure bigger preview is displayed correctly.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

web.mp4

github-actions · 2026-02-24T13:44:37Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-02-24T13:53:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...onents/TransactionItemRow/ReceiptPreview/index.tsx	`0.00% <0.00%> (ø)`
src/components/Image/BaseImage.tsx	`0.00% <0.00%> (ø)`
... and 52 files with indirect coverage changes

VickyStash · 2026-02-25T15:02:49Z

Note: While testing I've found side issue: #78859 (comment), should be fixed in this PR

melvin-bot · 2026-02-25T15:10:03Z

@shubham1206agra @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 561676171c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-25T15:26:43Z

src/components/Image/BaseImage.tsx

+    useEffect(() => {
+        // expo-image doesn't support onLoadStart on web, so we call it manually when the source changes, matching react-native-web's Image behavior
+        onLoadStart?.();
+    }, [source, onLoadStart]);


Stop retriggering onLoadStart on every render

Calling onLoadStart from a useEffect that depends on both source and onLoadStart causes it to fire on every rerender when callers pass non-memoized handlers (for example ImageView passes onLoadStart={imageLoadingStart} in src/components/ImageView/index.tsx, where imageLoadingStart is recreated each render). On web this can repeatedly enqueue state updates (setImageSize({width: 0, height: 0})) and lead to render thrashing or an update loop even when the image URL has not changed, which is a behavior regression from the prior event-driven react-native image implementation.

Useful? React with 👍 / 👎.

I think that previously the same kind of logic was used in the Image from react-native-web, it also called onLoadStart from a useEffect that depends on both source and onLoadStart:
https://github.com/necolas/react-native-web/blob/a9de220ba9e65bdea540fb5322ffb1da2b0bf442/packages/react-native-web/src/exports/Image/index.js#L278-L322

Just maybe I need to add a check for the source to be not a falsy value.

JmillsExpensify

No product review required on this one.

JmillsExpensify · 2026-02-25T15:39:34Z

Whoops mean to comment not approve, though plenty more review to go in any case.

mountiny · 2026-02-25T23:33:39Z

@shubham1206agra can you please prioritize this review?

github-actions · 2026-02-25T23:34:43Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny

Code wise looking good

shubham1206agra · 2026-02-26T03:12:43Z

@mountiny, is there any way we can send the HIEC image in the App without doing any conversions?

VickyStash · 2026-02-26T08:22:51Z

@mountiny, is there any way we can send the HIEC image in the App without doing any conversions?

@shubham1206agra We are doing conversions to support HEIC images display on the web I beleive.
You can check the PR #48861, and related slack discussion

…web-to-expo

mountiny · 2026-02-26T22:23:10Z

HEIC is a long long discussion in the App

github-actions · 2026-02-26T22:37:00Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny · 2026-02-26T22:45:41Z

@shubham1206agra also asked in slack, but do you have capacity to review and complete the checklist tomorrow?

github-actions · 2026-02-26T23:06:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83325.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-42b9d16-fdd2355-69a3db4be925b0a751460a24670496fa712168f8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-42b9d16-fdd2355-0f053823b53cbdda98885667c93ed35ee9ed9802/index.html

Web 🕸️
https://83325.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2026-02-27T18:54:59Z

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

mountiny · 2026-02-27T22:57:31Z

@shubham1206agra Will do the checklist tomorrow

shubham1206agra · 2026-03-02T14:02:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: mWeb Chrome

Screen.Recording.2026-03-02.at.7.22.22.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-02.at.7.17.14.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-02.at.7.12.04.PM.mov

OSBotify · 2026-03-02T17:33:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-02T17:59:02Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-02T18:04:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83325.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b195373-1c9ede1-0b5652789c26dac753560e005e5f9906e53d2ec6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b195373-1c9ede1-4e777df7d163b37cd3aa75bcaef2456a4b7954e0/index.html

Web 🕸️
https://83325.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:03:11Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-03-03T04:44:01Z

This PR failing because of the issue
This issue is reproducible in: Web

1.mp4

jponikarchuk · 2026-03-03T05:13:45Z

Deploy Blocker #83982 was identified to be related to this PR.

OSBotify · 2026-03-04T03:17:59Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:08:20Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

VickyStash added 2 commits February 24, 2026 12:22

Update web BaseImage to use expo-image

a059b0b

Remove the unnecessary patch

a2317a4

melvin-bot bot assigned VickyStash Feb 24, 2026

Fix loading

175d8bc

VickyStash mentioned this pull request Feb 24, 2026

[Due for payment 2026-03-30] [Due for payment 2026-03-24] Migrate the main chat list to FlashList #33725

Open

Julesssss self-requested a review February 25, 2026 00:53

Fix receipt preview display

5616761

VickyStash marked this pull request as ready for review February 25, 2026 15:09

VickyStash requested review from a team as code owners February 25, 2026 15:09

melvin-bot bot requested review from JmillsExpensify, mountiny and shubham1206agra and removed request for a team February 25, 2026 15:10

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

Improve the check

820433d

JmillsExpensify approved these changes Feb 25, 2026

View reviewed changes

mountiny approved these changes Feb 25, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Julesssss approved these changes Feb 26, 2026

View reviewed changes

Merge branch 'main' into VickyStash/refactor/33725-migrate-baseimage-…

42b9d16

…web-to-expo

shubham1206agra approved these changes Mar 2, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 2, 2026 14:02

Julesssss approved these changes Mar 2, 2026

View reviewed changes

Julesssss merged commit b195373 into Expensify:main Mar 2, 2026
39 checks passed

Julesssss mentioned this pull request Mar 2, 2026

[Image][$1000] Improve NewDot image uploading experience, add large file support #9402

Closed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

jponikarchuk mentioned this pull request Mar 3, 2026

[Due for payment 2026-03-13] [$250] Expense - When hovering for the first time, the cropped receipt preview appears #83982

Closed

7 tasks

VickyStash mentioned this pull request Mar 3, 2026

Fix web image caching authentication issues with expo-image #83112

Open

Conversation

VickyStash commented Feb 24, 2026 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

codecov bot commented Feb 24, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

VickyStash commented Feb 25, 2026

Uh oh!

melvin-bot bot commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Feb 25, 2026

Uh oh!

mountiny commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

shubham1206agra commented Feb 26, 2026

Uh oh!

VickyStash commented Feb 26, 2026

Uh oh!

mountiny commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

mountiny commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

mountiny commented Feb 27, 2026

Uh oh!

shubham1206agra commented Mar 2, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

jponikarchuk commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jponikarchuk commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

VickyStash commented Feb 24, 2026 •

edited by Julesssss

Loading

codecov bot commented Feb 24, 2026 •

edited by github-actions bot

Loading

jponikarchuk commented Mar 3, 2026 •

edited

Loading