[No QA] fix: iOS deploy uploading wrong IPA to TestFlight by roryabraham · Pull Request #83350 · Expensify/App

roryabraham · 2026-02-24T18:05:13Z

Explanation of Change

The find commands in deploy.yml that locate .ipa and .dSYM.zip artifacts were recursing into the Mobile-Expensify submodule directory. This caused them to pick up a test fixture at Mobile-Expensify/tests/iOS/Payload.ipa instead of the actual build artifact downloaded to the repo root.

The test fixture IPA has metadata like app_version: 1.0, build_version: 1, so when uploaded to App Store Connect, it would never process into a real build – causing Fastlane to hang at "Waiting for the build to show up in the build list" for hours until timeout.

The fix adds -maxdepth 1 to all find commands that locate .ipa and .dSYM.zip files, restricting the search to the directory where artifacts are downloaded.

Fixed Issues

N/A – fix for broken staging deploys

Tests

None - CP to test.

Verify that no errors appear in the JS console

Offline tests

N/A – CI/CD workflow change only.

QA Steps

[No QA]

PR Author Checklist

Screenshots/Videos

Android: Native

N/A – CI/CD change only

Android: mWeb Chrome

N/A – CI/CD change only

iOS: Native

N/A – CI/CD change only

iOS: mWeb Safari

N/A – CI/CD change only

MacOS: Chrome / Safari

N/A – CI/CD change only

Made with Cursor

The find command used to locate the .ipa artifact was recursing into the Mobile-Expensify submodule and picking up a test fixture (Mobile-Expensify/tests/iOS/Payload.ipa) instead of the actual build artifact. This caused Fastlane to upload the test fixture to App Store Connect, which would never process, causing the job to hang for hours. Add -maxdepth 1 to all find commands that locate .ipa and .dSYM.zip files so they only search the directory where artifacts are downloaded. Co-authored-by: Cursor <cursoragent@cursor.com>

The find commands were recursing into the Mobile-Expensify submodule and picking up test fixtures (e.g. Mobile-Expensify/tests/iOS/Payload.ipa) or framework dSYMs (e.g. Turf.framework.dSYM.zip) instead of the actual build artifacts. - Hardcode known filenames: Expensify.apk, Expensify.app.dSYM.zip - Use shell globs (*.ipa, *.aab) for build-produced files with unknown names -- globs don't recurse into subdirectories - Add fail-fast validation so missing artifacts produce clear errors instead of silently uploading the wrong file - Add debug logging (ls) to show all candidates in CI output Co-authored-by: Cursor <cursoragent@cursor.com>

Build workflows now output the exact filenames they produce: - buildAndroid: AAB_FILENAME, APK_FILENAME (always Expensify.apk) - buildIOS: IPA_FILENAME (from Rock export), DSYM_FILENAME (Expensify.app.dSYM.zip) Deploy jobs reference these outputs directly instead of using find or glob to discover artifacts. This eliminates the risk of picking up wrong files from submodules or framework dSYMs. Co-authored-by: Cursor <cursoragent@cursor.com>

For consistency with buildAndroid and buildIOS, buildWeb now outputs TAR_FILENAME, ZIP_FILENAME, and SOURCEMAP_FILENAME. Deploy references the tar filename from the build output instead of hardcoding it. Co-authored-by: Cursor <cursoragent@cursor.com>

- buildAndroid: SOURCEMAP_FILENAME (index.android.bundle.map), PROGUARD_MAPPING_FILENAME (mapping.txt) - buildIOS: SOURCEMAP_FILENAME (main.jsbundle.map) These will be needed by a future Sentry upload job to reference the correct artifacts without discovery. Co-authored-by: Cursor <cursoragent@cursor.com>

Reference needs.buildWeb.outputs.TAR_FILENAME instead of hardcoding webBuild.tar.gz, matching the pattern used in deploy.yml. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-02-24T18:45:08Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

- buildAndroid: group consecutive GITHUB_OUTPUT redirects (SC2129) - buildIOS: use find instead of ls for IPA discovery (SC2012) Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-02-24T19:10:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83350.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8365aa8-7d3026d-adb53180ebf0a31057edb6211e7737874ad31b70/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8365aa8-7d3026d-a1e8ff9fd28a618c0cd4aa9fbfc640046936f0b1/index.html

Web 🕸️
https://83350.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2026-02-24T19:23:53Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

On Adhoc builds with a Rock remote-cache hit, the IPA only exists on Rock's servers (via ROCK_ARTIFACT_URL) and isn't materialized locally. Warn instead of failing in this case, matching the Android build's behavior for missing AAB files. Release builds still hard-fail. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham · 2026-02-24T19:42:23Z

@codex review

GitHub Actions runs bash with set -e, so find returning non-zero (because .rock/cache/ios/export/ doesn't exist on cache hits) would kill the step before reaching the Adhoc warning fallback. Add || true to match the pattern used in the Android build. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham · 2026-02-24T20:06:16Z

@codex review

puneetlath · 2026-02-24T20:10:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector · 2026-02-24T20:17:04Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[No QA] fix: iOS deploy uploading wrong IPA to TestFlight (cherry picked from commit 432aa05) (cherry-picked to staging by roryabraham)

OSBotify · 2026-02-24T21:51:44Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-25T15:54:06Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-25T18:28:15Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:59:36Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned roryabraham Feb 24, 2026

roryabraham and others added 3 commits February 24, 2026 10:16

roryabraham changed the title ~~Fix iOS deploy uploading wrong IPA to TestFlight~~ [No QA] Fix iOS deploy uploading wrong IPA to TestFlight Feb 24, 2026

roryabraham and others added 2 commits February 24, 2026 10:39

Use buildWeb output for tar filename in buildAdHoc

8365aa8

Reference needs.buildWeb.outputs.TAR_FILENAME instead of hardcoding webBuild.tar.gz, matching the pattern used in deploy.yml. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix actionlint shellcheck warnings in build workflows

3ac10f4

- buildAndroid: group consecutive GITHUB_OUTPUT redirects (SC2129) - buildIOS: use find instead of ls for IPA discovery (SC2012) Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham requested a review from puneetlath February 24, 2026 19:23

roryabraham marked this pull request as ready for review February 24, 2026 19:23

roryabraham requested a review from a team as a code owner February 24, 2026 19:23

melvin-bot bot requested review from mjasikowski and removed request for a team February 24, 2026 19:23

This comment was marked as resolved.

Sign in to view

roryabraham changed the title ~~[No QA] Fix iOS deploy uploading wrong IPA to TestFlight~~ [No QA] fix: iOS deploy uploading wrong IPA to TestFlight Feb 24, 2026

This comment was marked as resolved.

Sign in to view

puneetlath approved these changes Feb 24, 2026

View reviewed changes

roryabraham merged commit 432aa05 into main Feb 24, 2026
13 of 16 checks passed

roryabraham deleted the rory-fix-ipa-path branch February 24, 2026 20:18

OSBotify pushed a commit that referenced this pull request Feb 24, 2026

Merge pull request #83350 from Expensify/rory-fix-ipa-path

9190ae7

[No QA] fix: iOS deploy uploading wrong IPA to TestFlight (cherry picked from commit 432aa05) (cherry-picked to staging by roryabraham)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 24, 2026

OSBotify mentioned this pull request Feb 24, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

roryabraham mentioned this pull request Feb 27, 2026

[No QA] ci: don't fail iOS build when IPA is missing on Rock cache hits #83647

Merged

51 tasks

Conversation

roryabraham commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

melvin-bot bot commented Feb 24, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

roryabraham commented Feb 24, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

roryabraham commented Feb 24, 2026

Uh oh!

puneetlath commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Feb 24, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roryabraham commented Feb 24, 2026 •

edited

Loading

puneetlath commented Feb 24, 2026 •

edited

Loading