Skip to content

Conversation

@marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Mar 29, 2022

Details

cc @mountiny Well, I messed up and removed the logic for the catch() in API.js, but forgot to update this here 😄

Fixed Issues

No Issue, but related to this one https://github.com/Expensify/Expensify/issues/201109

Tests

QA Steps

Same as #7929

  • Verify that no errors appear in the JS console

@marcaaron marcaaron requested a review from a team as a code owner March 29, 2022 01:26
@marcaaron marcaaron self-assigned this Mar 29, 2022
@melvin-bot melvin-bot bot requested review from danieldoglas and removed request for a team March 29, 2022 01:26
@marcaaron marcaaron requested a review from mountiny March 29, 2022 01:27
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, thanks for the follow up 🙌 😄

@marcaaron
Copy link
Contributor Author

Sorry @danieldoglas gonna merge this one, but lmk if you have any questions about it.

@marcaaron marcaaron merged commit 564ec88 into main Mar 30, 2022
@marcaaron marcaaron deleted the marcaaron-fixSetWalletLinkedBankAccount branch March 30, 2022 00:54
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.47-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Apr 5, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.49-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants