feature: Update company card + Expensify Card icons in NewDot#83425
feature: Update company card + Expensify Card icons in NewDot#83425pecanoro merged 10 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dubielzyk-expensify @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Here it is in action, some quick thoughts: CleanShot.2026-02-27.at.06.55.32.mp4
Thoughts @Expensify/design? |
Good shout. I agree.
I think it's ok for company and personal pending transactions to both use the card + hourglass icon. Do you feel differently?
It's whack as heck, but you've posted the correct one so I think that should take care of it? |
Made an icon in Figma. Here's the pending Expensify icon: expensify-card-hourglass.svg.zip
Yeah I'm kinda fine with this as well. |
|
@Expensify/design i added the expensify-card-hourglass icon and updated the company card icon |
|
Sweet. I'll run a new build |
|
🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
I guess there's an argument that Card feed filter would have your personal card there so that's another filter altogether? |
|
Yeah let's probably leave that be for now. |
|
New build is feeling good to me 👍 |
Reviewer Checklist
Screenshots/Videos |
heyjennahay
left a comment
There was a problem hiding this comment.
LOVE the tool tips so much, we should have done this years ago in Classic 😅 Also very happy with the differentiated icons. Thanks everyone for your work on this
|
Changes look good! @daledah |
|
@ZhenjaHorbach all looks good now |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|





Explanation of Change
Fixed Issues
$ #82768
PROPOSAL: #82768 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-27.at.12.58.24.mov