Fix: Allow updating NetSuite tokens without resetting connection configuration by imgyf · Pull Request #83434 · Expensify/App

imgyf · 2026-02-25T10:06:08Z

Explanation of Change

When a user needs to update their NetSuite token credentials (due to an authentication error, token rotation, etc.), the app previously called ConnectPolicyToNetSuite, which triggers initConnection on the backend and resets all user configuration (subsidiary, export destinations, mappings, custom segments, etc.).

This PR adds support for the backend's UpdateNetSuiteTokens command, which validates and updates credentials then triggers a sync — all while preserving existing config.

Changes:

src/libs/API/types.ts — Added UPDATE_NETSUITE_TOKENS write command mapped to existing ConnectPolicyToNetSuiteParams
src/libs/actions/connections/NetSuiteCommands.ts — Added updateNetSuiteTokens() action mirroring connectPolicyToNetSuite() but dispatching the new command
src/pages/.../NetSuiteTokenInputForm.tsx — Updated form submission to call updateNetSuiteTokens when isAuthenticationError is true, otherwise connectPolicyToNetSuite as before

Fixed Issues

$ #82339
PROPOSAL: #82339 (comment)

Tests

Connect a workspace to NetSuite and configure settings (subsidiary, export destinations, mappings, etc.)
Simulate an auth error by setting isAuthenticationError: true on the connection's lastSync in Onyx
Navigate to Workspace > Accounting, observe the auth error message
Click the three-dot menu on NetSuite > Enter credentials
Fill in credential fields and click Confirm
Open Network tab and verify the request goes to UpdateNetSuiteTokens (not ConnectPolicyToNetSuite)
Verify existing configuration is preserved after re-entering credentials

Verify that no errors appear in the JS console

Fresh connection scenario:

Remove any existing NetSuite connection from a workspace
Connect NetSuite for the first time via Workspace > Accounting
Verify the request goes to ConnectPolicyToNetSuite as before

Failure scenarios:

Simulate an auth error on the NetSuite connection
Navigate to the credentials form via three-dot menu > Enter credentials
Leave one or more fields empty and click Confirm
Verify a "This field is required" error is shown for each empty field and the form is not submitted
Fill in all fields with dummy values, then submit while the backend returns an error (or while offline with no queued request support)
Verify the app does not crash and no unhandled errors appear in the console

Offline tests

Simulate an auth error and navigate to the credentials form
Go offline
Fill in credentials and click Confirm
Verify the request is queued
Go back online and verify the UpdateNetSuiteTokens request is sent

QA Steps

Have a workspace with a configured NetSuite connection (subsidiary, export destinations, mappings set up)
Trigger an authentication error on the NetSuite connection
Re-enter credentials via Workspace > Accounting > NetSuite three-dot menu > Enter credentials
Verify credentials are updated successfully and all existing configuration is preserved
Verify a fresh first-time NetSuite connection still uses ConnectPolicyToNetSuite

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

83434-android-native-vid.mov

Android: mWeb Chrome

83434-android-mweb-vid.mov

iOS: Native

83434-ios-native-vid.mov

iOS: mWeb Safari

83434-ios-mweb-vid.mov

MacOS: Chrome / Safari

83434-macos-safari-vid.mov

…h error When users update their NetSuite token credentials due to an authentication error, the app previously called ConnectPolicyToNetSuite which triggers initConnection and resets all existing configuration. This change adds a new UpdateNetSuiteTokens command that preserves existing config and only updates the credentials, then conditionally calls it when isAuthenticationError is true on the NetSuite connection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

melvin-bot · 2026-02-26T16:56:01Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-26T16:56:06Z

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-26T16:59:35Z

src/libs/actions/connections/NetSuiteCommands.ts

    API.write(WRITE_COMMANDS.CONNECT_POLICY_TO_NETSUITE, parameters, {optimisticData});
 }

+function updateNetSuiteTokens(policyID: string, credentials: Omit<ConnectPolicyToNetSuiteParams, 'policyID'>) {


❌ CONSISTENCY-3 (docs)

The updateNetSuiteTokens function body is an exact duplicate of connectPolicyToNetSuite (lines 21-37) -- identical signature, identical optimistic data construction, identical parameter assembly. The only difference is the write command (UPDATE_NETSUITE_TOKENS vs CONNECT_POLICY_TO_NETSUITE).

Extract the shared logic into a helper that accepts the command as a parameter:

function writeNetSuiteCredentials( command: typeof WRITE_COMMANDS.CONNECT_POLICY_TO_NETSUITE | typeof WRITE_COMMANDS.UPDATE_NETSUITE_TOKENS, policyID: string, credentials: Omit<ConnectPolicyToNetSuiteParams, 'policyID'>, ) { const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.POLICY_CONNECTION_SYNC_PROGRESS>> = [ { onyxMethod: Onyx.METHOD.MERGE, key: `${ONYXKEYS.COLLECTION.POLICY_CONNECTION_SYNC_PROGRESS}${policyID}`, value: { stageInProgress: CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.NETSUITE_SYNC_CONNECTION, connectionName: CONST.POLICY.CONNECTIONS.NAME.NETSUITE, timestamp: new Date().toISOString(), }, }, ]; const parameters: ConnectPolicyToNetSuiteParams = { policyID, ...credentials, }; API.write(command, parameters, {optimisticData}); } function connectPolicyToNetSuite(policyID: string, credentials: Omit<ConnectPolicyToNetSuiteParams, 'policyID'>) { writeNetSuiteCredentials(WRITE_COMMANDS.CONNECT_POLICY_TO_NETSUITE, policyID, credentials); } function updateNetSuiteTokens(policyID: string, credentials: Omit<ConnectPolicyToNetSuiteParams, 'policyID'>) { writeNetSuiteCredentials(WRITE_COMMANDS.UPDATE_NETSUITE_TOKENS, policyID, credentials); }

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@imgyf Could you explain about it, such as why you 👎?

@truph01 after looking through the comment again, it's actually valid so I've fixed it in the latest commit.

dannymcclain · 2026-02-26T19:26:15Z

Would you mind adding a video of the flow for desktop web? I mostly just want to see the placement of the option in the menu.

JmillsExpensify

Product review not required on this one.

imgyf · 2026-02-27T09:16:46Z

Hi @dannymcclain , here's the video as requested.

83434-video.mov

dannymcclain · 2026-02-27T15:17:58Z

Nice! Thank you 👍

truph01 · 2026-03-02T08:16:11Z

@imgyf Please update your PR author checklist to include videos, not only screenshots.

imgyf · 2026-03-03T08:05:17Z

@truph01 I have updated the PR author checklist to include videos for all 5 platforms, please review.

truph01 · 2026-03-05T08:00:06Z

@imgyf Could you merge main here?

…te-netsuite-tokens

imgyf · 2026-03-05T09:04:06Z

@truph01 merged main as requested.

imgyf · 2026-03-06T04:27:42Z

@truph01 not sure why PR Author Checklist check is failing when I already have all checkboxes checked?

imgyf · 2026-03-09T09:13:34Z

@truph01 please review again.

truph01 · 2026-03-10T05:09:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-10.at.12.09.28.mov

Android: mWeb Chrome

Screen.Recording.2026-03-10.at.12.08.44.mov

iOS: HybridApp

Screen.Recording.2026-03-10.at.12.02.33.mov

iOS: mWeb Safari

Screen.Recording.2026-03-10.at.12.05.08.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-10.at.11.47.57.mov

JmillsExpensify

No product review required.

codecov · 2026-03-12T19:25:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
...uiteTokenInput/subPages/NetSuiteTokenInputForm.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/connections/NetSuiteCommands.ts	`0.00% <0.00%> (ø)`
... and 17 files with indirect coverage changes

github-actions · 2026-03-12T19:41:39Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-12T19:47:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83434.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0607d51-fda79d3-c5a61c9e34c7159e233bbaf3fdc066fd347507e3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0607d51-fda79d3-183a6d3a16b3ac0bcb4c000e6d76ad130e1d3544/index.html

Web 🕸️
https://83434.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-12T23:17:26Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.37-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-03-13T07:35:30Z

Deploy Blocker #85196 was identified to be related to this PR.

imgyf · 2026-03-13T07:40:51Z

@jponikarchuk do you want me to revert the PR first?

m-natarajan · 2026-03-13T14:54:44Z

@imgyf @yuwenmemon @truph01 Can this one please be tested internally, not able to Trigger an authentication error on the NetSuite connection . Tried by login to Netsuite website and unable to find the disconnect like we do for QBO connection. Unable to reconnect if connected with invalid tokens or credentials #85196

luacmartins · 2026-03-13T20:14:25Z

@yuwenmemon any way to test this internally?

imgyf · 2026-03-14T04:57:37Z

Regression Note

This PR caused a deploy blocker: #85196

What went wrong: The conditional in NetSuiteTokenInputForm checked isAuthenticationError to decide between updateNetSuiteTokens and connectPolicyToNetSuite, but didn't account for unverified connections. When a first-time connection fails with incorrect tokens, isAuthenticationError is true but the connection was never fully initialized (verified: false). The form then called updateNetSuiteTokens, which requires an already-initialized connection, causing the user to be stuck in an error loop even after entering correct tokens.

Fix: PR #85200 added an isConnectionUnverified check so unverified connections always use connectPolicyToNetSuite (full initialization). Follow-up PR #85288 extracts the selection logic into a shared shouldUseUpdateNetSuiteTokens helper with unit tests.

Takeaway: When branching on connection error state, always consider the connection lifecycle stage (unverified vs verified), an error flag alone doesn't tell you whether the connection was ever successfully initialized.

OSBotify · 2026-03-16T10:05:52Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned imgyf Feb 25, 2026

imgyf changed the title ~~[WIP] Allow updating NetSuite tokens without resetting connection configuration~~ [WIP] Fix: Allow updating NetSuite tokens without resetting connection configuration Feb 25, 2026

imgyf marked this pull request as ready for review February 26, 2026 16:55

imgyf requested review from a team as code owners February 26, 2026 16:55

melvin-bot bot requested review from a team, JmillsExpensify and truph01 and removed request for a team February 26, 2026 16:55

melvin-bot bot requested review from yuwenmemon and removed request for a team February 26, 2026 16:56

imgyf changed the title ~~[WIP] Fix: Allow updating NetSuite tokens without resetting connection configuration~~ Fix: Allow updating NetSuite tokens without resetting connection configuration Feb 26, 2026

imgyf mentioned this pull request Feb 26, 2026

[$250] Allow updating NetSuite tokens without resetting connection configuration #82339

Open

github-actions bot reviewed Feb 26, 2026

View reviewed changes

JmillsExpensify reviewed Feb 26, 2026

View reviewed changes

imgyf added 2 commits March 5, 2026 16:21

Merge branch 'main' of github.com:Expensify/App into imgyf/82339-upda…

6adb935

…te-netsuite-tokens

refactor: implement shared logic in writeNetSuiteCredentials

c7e8ceb

truph01 approved these changes Mar 10, 2026

View reviewed changes

imgyf requested a review from JmillsExpensify March 10, 2026 13:01

JmillsExpensify reviewed Mar 10, 2026

View reviewed changes

yuwenmemon approved these changes Mar 12, 2026

View reviewed changes

yuwenmemon merged commit 0607d51 into Expensify:main Mar 12, 2026
32 of 36 checks passed

github-actions bot mentioned this pull request Mar 12, 2026

[Due for payment 2026-03-24] Investigate workflow job failing on main: test / test (job 7) #85128

Open

OSBotify mentioned this pull request Mar 12, 2026

Deploy Checklist: New Expensify 2026-03-12 #85146

Closed

87 tasks

OSBotify mentioned this pull request Mar 13, 2026

[Due for payment 2026-03-30] NetSuite - Not able to connect the integration with correct tokens, when edit incorrect input #85196

Open

7 tasks

imgyf mentioned this pull request Mar 13, 2026

Fix: NetSuite auth error persists after correcting tokens on unverified connection #85200

Merged

52 tasks

imgyf deleted the imgyf/82339-update-netsuite-tokens branch March 18, 2026 07:34

Conversation

imgyf commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 26, 2026

Uh oh!

melvin-bot bot commented Feb 26, 2026

Uh oh!

github-actions bot Feb 26, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-3 (docs)

Uh oh!

truph01 Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imgyf Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Feb 26, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

imgyf commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Feb 27, 2026

Uh oh!

truph01 commented Mar 2, 2026

Uh oh!

imgyf commented Mar 3, 2026

Uh oh!

truph01 commented Mar 5, 2026

Uh oh!

imgyf commented Mar 5, 2026

Uh oh!

imgyf commented Mar 6, 2026

Uh oh!

imgyf commented Mar 9, 2026

Uh oh!

truph01 commented Mar 10, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

jponikarchuk commented Mar 13, 2026

Uh oh!

imgyf commented Mar 13, 2026

Uh oh!

m-natarajan commented Mar 13, 2026

Uh oh!

luacmartins commented Mar 13, 2026

Uh oh!

imgyf commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Note

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

imgyf commented Feb 25, 2026 •

edited

Loading

truph01 Mar 5, 2026 •

edited

Loading

imgyf commented Feb 27, 2026 •

edited

Loading

codecov bot commented Mar 12, 2026 •

edited by github-actions bot

Loading

imgyf commented Mar 14, 2026 •

edited

Loading