Split contexts to state and actions - Batch 4 by staszekscp · Pull Request #83454 · Expensify/App

staszekscp · 2026-02-25T15:24:25Z

cc: @mountiny

Explanation of Change

Migration of the following contexts to follow state/actions split pattern:

VideoPopoverMenuContext
VolumeContext
MenuItemGroupContext
SidebarOrderedReportsContextProvider
OptionListContextProvider

Fixed Issues

$ #80271
PROPOSAL:

Tests

Prerequisites

A report with a non-paid expense
A report with a video

Steps

Mark the expense as paid
See if the LHN reorders (if the GBR disappears, the report should go down the list)
Go to Settings -> Profile and press any of the MenuItems, see if RHP opens correctly
WEB ONLY: Go to + -> Create Expense -> Manual and long press on the currency amount. Upon releasing the button the input should still be focused
Go to Search and type anything. See if the autocomplete updates the list of suggestions
Open a video and see if you can manipulate the volume

Offline tests

QA Steps

Prerequisites

A report with a non-paid expense
A report with a video

Steps

Mark the expense as paid
See if the LHN reorders (if the GBR disappears, the report should go down the list)
Go to Settings -> Profile and press any of the MenuItems, see if RHP opens correctly
WEB ONLY: Go to + -> Create Expense -> Manual and long press on the currency amount. Upon releasing the button the input should still be focused
Go to Search and type anything. See if the autocomplete updates the list of suggestions
Open a video and see if you can manipulate/mute the volume

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-02-27.at.12.14.31.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-26.at.14.53.56.mov

codecov · 2026-02-26T09:12:30Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MenuItem.tsx	`88.20% <100.00%> (+0.05%)`	⬆️
src/components/MenuItemGroup.tsx	`100.00% <100.00%> (ø)`
src/components/Navigation/DebugTabView.tsx	`35.22% <ø> (ø)`
...c/components/Navigation/NavigationTabBar/index.tsx	`53.33% <ø> (ø)`
src/components/NumberWithSymbolForm.tsx	`43.64% <100.00%> (ø)`
src/components/OptionListContextProvider.tsx	`86.33% <100.00%> (+0.30%)`	⬆️
...components/SelectionList/ListItem/BaseListItem.tsx	`96.29% <ø> (ø)`
...ponents/SelectionListWithSections/BaseListItem.tsx	`95.74% <ø> (ø)`
src/components/TestToolMenu.tsx	`87.87% <ø> (ø)`
src/components/VideoPlayer/BaseVideoPlayer.tsx	`48.44% <100.00%> (+0.20%)`	⬆️
... and 7 more
... and 13 files with indirect coverage changes

melvin-bot · 2026-02-27T11:19:31Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 573a75d193

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T11:34:31Z

src/hooks/useMouseContext.tsx


-    const value = useMemo(() => ({isMouseDownOnInput, setMouseDown, setMouseUp}), [isMouseDownOnInput]);
+    const stateValue = {isMouseDownOnInput};
+    const actionsValue = {setMouseDown, setMouseUp};


Memoize mouse actions context value

MouseActionsContext now receives a fresh object on every MouseProvider render, so components that only call useMouseActions() still re-render whenever isMouseDownOnInput toggles. This defeats the state/actions split and can reintroduce the same UI churn this migration is trying to remove (for example, NumberWithSymbolForm will still update on mouse down/up transitions), so the actions context should keep a stable value identity across unrelated state updates.

Useful? React with 👍 / 👎.

auto memoized

JmillsExpensify

Looks good from a product perspective.

mkhutornyi · 2026-02-27T14:48:01Z

I got one-time crash when typing on search. Not reproducible anymore.

Screen.Recording.2026-02-27.at.2.47.25.pm.mov

mkhutornyi · 2026-02-27T14:48:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-27.at.2.43.35.pm.mov

Screen.Recording.2026-02-27.at.2.44.40.pm.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 573a75d193

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T15:02:24Z

src/hooks/useMouseContext.tsx

+    const stateValue = {isMouseDownOnInput};
+    const actionsValue = {setMouseDown, setMouseUp};


Memoize mouse context values to avoid list-wide rerenders

MouseProvider now constructs stateValue and actionsValue inline on every render, so both context value props change identity even when isMouseDownOnInput is unchanged. Because React context updates are identity-based, any parent rerender of this provider now forces all useMouseState/useMouseActions consumers (e.g., selection list items in the money request flow) to rerender unnecessarily, which is a measurable regression from the previous memoized behavior and can cause interaction lag on large lists.

Useful? React with 👍 / 👎.

The component is memoized by the React Compiler

OSBotify · 2026-02-27T23:24:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-27T23:40:02Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-27T23:45:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83454.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5023f38-8ca3480-dc822c6f45aa1f84d81f3ae6196f07a4306afb28/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5023f38-8ca3480-d01d46958e4893317b51dc4b466687b660e8b45d/index.html

Web 🕸️
https://83454.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:03:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:18:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:08:26Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

staszekscp added 4 commits February 25, 2026 11:48

Migrate VideoPopoverMenuContext

b0d55f9

Migrate VolumeContext

8a3f2f8

Migrate MenuItemGroupContext

a7bf2fe

Migrate SidebarOrderedReportsContextProvider

816178f

melvin-bot bot assigned staszekscp Feb 25, 2026

staszekscp mentioned this pull request Feb 25, 2026

[Due for payment 2026-03-25] [Due for payment 2026-03-11] Split context providers to return State and Actions separately #80271

Open

staszekscp added 2 commits February 25, 2026 16:35

Migrate OptionListContextProvider

2707b60

Migrate MouseContext

e85a402

staszekscp changed the title ~~Split contexts to state and actions - Batch 3~~ Split contexts to state and actions - Batch 4 Feb 25, 2026

Merge remote-tracking branch 'origin/main' into perf/migrate-contexts-3

573a75d

staszekscp marked this pull request as ready for review February 27, 2026 11:19

staszekscp requested review from a team as code owners February 27, 2026 11:19

melvin-bot bot requested review from JmillsExpensify and mkhutornyi and removed request for a team February 27, 2026 11:19

melvin-bot bot removed the request for review from a team February 27, 2026 11:19

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

JmillsExpensify approved these changes Feb 27, 2026

View reviewed changes

mkhutornyi approved these changes Feb 27, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny February 27, 2026 14:48

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

mountiny approved these changes Feb 27, 2026

View reviewed changes

mountiny merged commit 5023f38 into Expensify:main Feb 27, 2026
35 of 38 checks passed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

		const stateValue = {isMouseDownOnInput};
		const actionsValue = {setMouseDown, setMouseUp};

Conversation

staszekscp commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 26, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Feb 27, 2026

Uh oh!

mkhutornyi commented Feb 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

staszekscp Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

staszekscp commented Feb 25, 2026 •

edited

Loading

codecov bot commented Feb 26, 2026 •

edited by github-actions bot

Loading