[Domain control] [Release 3.5] Export domain members by war-in · Pull Request #83459 · Expensify/App

war-in · 2026-02-25T16:24:45Z

Explanation of Change

Add the ability to export domain members to a CSV file from the Domain Members page. This introduces:

A new ExportDomainMembersCSV write command with domainAccountID parameter
An exportMembersToCSV action in Domain.ts that constructs a POST request and triggers a
file download via fileDownload
A "More" dropdown button (using ButtonWithDropdownMenu) on the Domain Members page header
with a "Download CSV" option
Offline handling: shows a modal informing the user the feature requires internet
Download failure handling: shows a modal informing the user the download failed

Fixed Issues

$ #79571
PROPOSAL:

Tests

Navigate to a domain members page
Verify a "More" dropdown button appears next to the "Add member" button
Click the "More" dropdown and verify it contains a "Download CSV" option
Click "Download CSV" and verify a CSV file named DomainMembers.csv is downloaded
Verify the CSV contains the expected domain member data
Select one or more members and verify the "More" dropdown is replaced by the bulk action
buttons
Deselect all members and verify the "More" dropdown reappears

Offline tests

Go offline
Click "Download CSV" from the "More" dropdown
Verify a modal appears saying you appear to be offline and this feature requires internet
Tap "Confirm" to dismiss the modal

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.12.07.38.mov

# Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/languages/en.ts # src/libs/API/parameters/index.ts # src/libs/API/types.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/libs/Navigation/linkingConfig/config.ts # src/libs/Navigation/types.ts # src/libs/actions/Domain.ts # src/pages/domain/Members/DomainMembersPage.tsx # src/types/onyx/DomainErrors.ts # src/types/onyx/DomainPendingActions.ts

…kuba-nowakowski/domain_export_member # Conflicts: # src/CONST/index.ts # src/ROUTES.ts # src/SCREENS.ts # src/languages/en.ts # src/libs/actions/Domain.ts # src/pages/domain/Members/DomainMembersPage.tsx # src/types/onyx/DomainErrors.ts # src/types/onyx/DomainPendingActions.ts

# Conflicts: # src/pages/domain/Members/DomainMembersPage.tsx

codecov · 2026-02-25T16:34:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/actions/Domain.ts	`48.69% <0.00%> (-1.86%)`	⬇️
src/pages/domain/Members/DomainMembersPage.tsx	`0.00% <0.00%> (ø)`
... and 22 files with indirect coverage changes

…port_member

melvin-bot · 2026-03-04T11:23:42Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in · 2026-03-04T11:27:11Z

@codex review

situchan · 2026-03-04T11:27:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

DomainMembers-2026-03-04

chatgpt-codex-connector · 2026-03-04T11:35:32Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-03-04T16:28:00Z

More button takes more width on mobile than expected. This should be fixed after merging #84059 right?

war-in · 2026-03-04T16:29:10Z

More button takes more width on mobile than expected. This should be fixed after merging #84059 right?

Yes! I a;ready fix it there

situchan · 2026-03-04T16:36:31Z

Bug: Download not working on android

android.mov

war-in · 2026-03-04T16:38:06Z

Bug: Download not working on android

@situchan are you on staging? The command is not yet deployed to prod

situchan · 2026-03-04T16:41:39Z

Bug: Download not working on android

@situchan are you on staging? The command is not yet deployed to prod

oh yes, you're right. staging works.

However, I cannot open downloaded file

Screen.Recording.2026-03-04.at.10.40.39.PM.mov

EDIT: not blocker. I cannot open all csv files

joekaufmanexpensify

Design doc project

github-actions · 2026-03-04T21:49:41Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-04T21:55:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-04T21:55:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83459.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cc655fd-34c44ab-559517d484b71b38021b706d5f651f2491e6b44f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cc655fd-34c44ab-03677b4667338034365195a66f5f3749c1886768/index.html

Web 🕸️
https://83459.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:14:48Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:44:01Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

sumo-slonik and others added 8 commits January 13, 2026 11:39

preparation for download CSV with members

fcbb2e8

fix export members

b5eba5f

fix: remove unrelated changes

58753eb

refactor: use useConfirmModal

638b39d

Merge branch 'main' into feature/kuba-nowakowski/domain_export_member

0eb3db3

# Conflicts: # src/pages/domain/Members/DomainMembersPage.tsx

fix: post-merge fixes

ffe8613

melvin-bot bot assigned war-in Feb 25, 2026

war-in changed the title ~~[HOLD https://github.com/Expensify/App/issues/82259] [Domain control] [Release 3.5] Export domain members~~ [Domain control] [Release 3.5] Export domain members Mar 4, 2026

war-in added 2 commits March 4, 2026 10:22

Merge branch 'refs/heads/main' into feature/kuba-nowakowski/domain_ex…

28b8c7b

…port_member

feat: integrate download command

fc5058d

war-in marked this pull request as ready for review March 4, 2026 11:23

war-in requested review from a team as code owners March 4, 2026 11:23

melvin-bot bot requested a review from situchan March 4, 2026 11:23

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 4, 2026 11:23

fix: rename function

55464c8

war-in added this to Bring Domain Control to NewDot Mar 4, 2026

war-in moved this to Ready for Review in Bring Domain Control to NewDot Mar 4, 2026

situchan approved these changes Mar 4, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 4, 2026 16:43

joekaufmanexpensify approved these changes Mar 4, 2026

View reviewed changes

mountiny approved these changes Mar 4, 2026

View reviewed changes

mountiny merged commit cc655fd into Expensify:main Mar 4, 2026
37 of 38 checks passed

github-project-automation bot moved this from Ready for Review to Done in Bring Domain Control to NewDot Mar 4, 2026

situchan mentioned this pull request Mar 4, 2026

[Domain control] [Release 3.1] Add Settings option to More on DomainMembersPage #84059

Merged

50 tasks

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Conversation

war-in commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 25, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

war-in commented Mar 4, 2026

Uh oh!

situchan commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Mar 4, 2026

Uh oh!

situchan commented Mar 4, 2026

Uh oh!

war-in commented Mar 4, 2026

Uh oh!

situchan commented Mar 4, 2026

Uh oh!

war-in commented Mar 4, 2026

Uh oh!

situchan commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

war-in commented Feb 25, 2026 •

edited

Loading

codecov bot commented Feb 25, 2026 •

edited by github-actions bot

Loading

situchan commented Mar 4, 2026 •

edited

Loading

situchan commented Mar 4, 2026 •

edited

Loading