Skip to content

perf: scope draft/reaction Onyx subscriptions to per-item level in report actions list#83547

Merged
cristipaval merged 6 commits intoExpensify:mainfrom
callstack-internal:perf/per-item-level-subs-2
Mar 16, 2026
Merged

perf: scope draft/reaction Onyx subscriptions to per-item level in report actions list#83547
cristipaval merged 6 commits intoExpensify:mainfrom
callstack-internal:perf/per-item-level-subs-2

Conversation

@waterim
Copy link
Contributor

@waterim waterim commented Feb 26, 2026 •
edited
Loading

Details

This PR scopes draft/reaction Onyx subscriptions to per-item level in report actions list

ListItemRenderer renders: Before = 155, After = 40

Fixed Issues

$ #83891

Tests

Note: all of these changes works optimistically

Test 1:

  1. Add an emoji reaction
  2. Only the reacted message re-renders

Test 2:

  1. Open a thread
  2. Parent action renders correctly with draft/reactions

Test 3:

  1. Open an expense report
  2. MoneyRequestReportActionsList behaves correctly
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Sending a message in a chat and verifying it appears correctly
  2. Adding/removing emoji reactions on messages
  3. Editing a message draft, then discarding/sending it
  4. Opening a thread and verifying the parent action displays correctly
  5. Sending a message in a money request report chat
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Details

@waterim waterim requested review from a team as code owners February 26, 2026 09:30
@melvin-bot melvin-bot bot requested review from ShridharGoel and removed request for a team February 26, 2026 09:30
@melvin-bot
Copy link

melvin-bot bot commented Feb 26, 2026

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team February 26, 2026 09:30
@codecov
Copy link

codecov bot commented Feb 26, 2026 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ges/inbox/report/ReportActionsListItemRenderer.tsx 85.71% <ø> (ø)
src/pages/inbox/report/ReportActionsList.tsx 77.94% <66.66%> (-0.40%) ⬇️
...equestReportView/MoneyRequestReportActionsList.tsx 57.49% <50.00%> (+0.43%) ⬆️
...ages/inbox/report/ReportActionItemParentAction.tsx 0.00% <0.00%> (ø)
... and 12 files with indirect coverage changes

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Feb 26, 2026

@waterim Let's add QA steps as well, just some sanity tests since they will probably not be able to check the render count.

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Feb 26, 2026

@waterim Can you have a look? Is this the correct way to test?

Screen.Recording.2026-02-26.at.5.08.14.PM.mov

@waterim
Copy link
Contributor Author

waterim commented Mar 2, 2026

@ShridharGoel yes, seems correct, profile send message

@waterim
Copy link
Contributor Author

waterim commented Mar 2, 2026

@ShridharGoel updated QA steps with focus on ensuring no regressions in

@cristipaval
Copy link
Contributor

cristipaval commented Mar 2, 2026

FYI: I created a subissue for this PR #83891

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Mar 4, 2026

But sending a message seems to have re-rendered other items as well in this

@waterim
Copy link
Contributor Author

waterim commented Mar 5, 2026

@ShridharGoel The re-renders you see on send message are expected, updated tests, 1st test was wrong for this PR.

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Mar 6, 2026

@waterim Isn't it still rendering all messages on adding an emoji?

Screen.Recording.2026-03-06.at.5.44.28.PM.mov

@waterim
Copy link
Contributor Author

waterim commented Mar 9, 2026 •
edited
Loading

@ShridharGoel Just rechecked the profiler and you are right, all the messages are rerendering in the end.

When you add an emoji, the optimistic update correctly re-renders only the affected message and that's what I was trying to achieve here in the PR by scoping draft/reaction subscriptions to the per-item level.

However, when the server response arrives and updates the reportActions Onyx collection, new object references flow through, ReportActionsView → ReportActionsList → all items get a new reportAction prop, even for actions whose data didn't actually change. That's a separate issue with report action reference stability that I'm working on in a different PR.

Let me add a note to test steps not to confuse

@cristipaval cristipaval mentioned this pull request Mar 10, 2026
Open
@ShridharGoel
Copy link
Contributor

ShridharGoel commented Mar 11, 2026 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-11.at.11.30.09.PM.mov
Screen.Recording.2026-03-11.at.11.36.42.PM.mov

@melvin-bot melvin-bot bot requested a review from cristipaval March 11, 2026 18:19
cristipaval
cristipaval previously approved these changes Mar 12, 2026
View reviewed changes
@cristipaval
Copy link
Contributor

cristipaval commented Mar 12, 2026

@waterim, could you please resolve conflicts?

@waterim
Merge remote-tracking branch 'upstream/main' into perf/per-item-level…
5029567 
…-subs-2

# Conflicts:
#	src/pages/inbox/report/ReportActionsList.tsx
#	src/pages/inbox/report/ReportActionsListItemRenderer.tsx
@waterim
Copy link
Contributor Author

waterim commented Mar 12, 2026

@cristipaval done

heyjennahay
heyjennahay reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor

@heyjennahay heyjennahay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review not required

@cristipaval
Copy link
Contributor

cristipaval commented Mar 12, 2026

@waterim , lint fails

@waterim
Copy link
Contributor Author

waterim commented Mar 13, 2026

@cristipaval fixed and resolved

@cristipaval cristipaval merged commit a5664a4 into Expensify:main Mar 16, 2026
31 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83547.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a5664a4-03346cd-6e767c9c7e5e45305f3fabe687886df6dead7db1/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a5664a4-03346cd-17cb72b46ff698009f95e6deec623d99527dd40a/index.html
Android iOS
Web 🕸️
https://83547.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor

OSBotify commented Mar 16, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 17, 2026
Closed
75 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 17, 2026

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.39-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 18, 2026

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyjennahay heyjennahay heyjennahay left review comments

@cristipaval cristipaval cristipaval approved these changes

+1 more reviewer

@ShridharGoel ShridharGoel ShridharGoel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@waterim waterim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@waterim @ShridharGoel @cristipaval @OSBotify @heyjennahay