Decompose ReportScreen core subcomponents by adhorodyski · Pull Request #83560 · Expensify/App

adhorodyski · 2026-02-26T11:43:24Z

@mountiny @rlinoz

Explanation of Change

Isolate Onyx subscriptions in ReportScreen's child components to reduce unnecessary re-renders, saving ~150ms on keyboard open/close
Move isComposerFullSize subscription from ReportScreen into ReportFooter, removing a top-level Onyx subscription
Tighten ReportFooter's interface by removing manual memo comparators and relying on React Compiler
Narrow HeaderView's Onyx subscriptions (parentReport, report) with selectors that extract only the fields actually used
Extract a shared HeaderLoadingBar component that owns its own SequentialQueue subscription, isolating queue-related re-renders from MoneyReportHeader, MoneyRequestHeader, and MoneyRequestReportView
Narrow ONYXKEYS.NETWORK subscriptions in MoneyReportHeader and MoneyRequestHeader with a shouldFailAllRequests selector instead of subscribing to the full Network object

Removed all idle state renders on report headers (all variants). This happens every time the sequential queue runs.

Allowed the compiler to kick in, no passive effects and way less work (-150ms with ~15 more commits):

Fixed Issues

$ #77173
$ #84150
PROPOSAL:

Tests

Open any report chat — verify header, footer, and composer render correctly
Toggle online/offline — verify the loading bar appears/disappears without full header re-renders
Open/close the keyboard on a report — confirm ~150ms improvement vs. main
Hold an expense and dismiss the educational modal — verify the hold flow still works (exercises shouldFailAllRequests path)
Submit/approve a money report — verify header actions remain functional

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

ReportFooter is the only consumer of isComposerFullSize. By owning the subscription internally, we remove two parent-level Onyx subscriptions (ReportScreen + MoneyRequestReportView), avoiding unnecessary re-renders of those heavy components when the composer size changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Internalize policy, reportMetadata, and pendingAction into ReportFooter via useOnyx selectors and derivation from report, removing 3 props from the public interface. Remove manual memo() wrappers from ReportFooter, ReportScreen, and HeaderView — the React Compiler handles memoization. Also remove manual useCallback wrappers that the compiler auto-memoizes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Replace grandParentReportActions full-collection subscription with useParentReportAction hook, add selector for account (guideDetails only), and add selector for reportMetadata (pendingChatMembers only). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…e-renders The useLoadingBarVisibility hook subscribes to PERSISTED_REQUESTS without a selector, causing HeaderView to re-render on every queue mutation. By extracting LoadingBar into a dedicated child component and adding boolean selectors to the hook, queue processing no longer triggers re-renders of HeaderView's ~50 local variables and deeply nested JSX. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

… isolate queue re-renders Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…der with selector Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

melvin-bot · 2026-02-26T16:23:57Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

adhorodyski · 2026-02-26T16:28:18Z

Fixing the failing unit test suite

…defined

codecov · 2026-02-26T16:53:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/HeaderLoadingBar.tsx	`100.00% <100.00%> (ø)`
.../MoneyRequestReportView/MoneyRequestReportView.tsx	`0.00% <ø> (ø)`
src/hooks/useLoadingBarVisibility.ts	`100.00% <100.00%> (ø)`
src/hooks/useParentReportAction.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/ReportScreen.tsx	`69.50% <ø> (+0.09%)`	⬆️
src/selectors/Account.ts	`100.00% <100.00%> (ø)`
src/selectors/Network.ts	`100.00% <100.00%> (ø)`
src/selectors/ReportMetaData.ts	`100.00% <100.00%> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
src/components/MoneyRequestHeader.tsx	`0.00% <0.00%> (ø)`
... and 2 more
... and 12 files with indirect coverage changes

mountiny · 2026-02-26T20:46:48Z

@codex review

src/pages/inbox/HeaderView.tsx

src/selectors/Network.ts

chatgpt-codex-connector · 2026-02-26T20:58:52Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/inbox/ReportScreen.tsx

src/pages/inbox/HeaderView.tsx

ShridharGoel · 2026-02-26T21:35:47Z

Looks like the report screen is broken, can you check once?

Edit: It was happening when the pages were not loading. After doing a cache reset and refresh, the below is not showing but still worth checking.

ShridharGoel · 2026-02-26T21:39:36Z

Seeing some janky behaviour when closing an expense details page (timestamp 0:12 onwards).

Screen.Recording.2026-02-27.at.3.08.51.AM.mov

adhorodyski · 2026-02-27T13:28:25Z

@ShridharGoel are you sure the same is not reproducible on main? I didn't apply any changes at this level in this PR.

ShridharGoel · 2026-02-27T13:36:26Z

Just tried, able to repro this on main as well

ShridharGoel · 2026-02-27T13:36:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-27.at.8.13.47.PM.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-27.at.8.07.49.PM.mov

adhorodyski · 2026-02-27T13:40:50Z

oki, I'm adding the tests as @mountiny asked for and we're good here

ShridharGoel · 2026-02-27T13:40:53Z

Can you add the missing import in HeaderLoadingBar ?

Move accountGuideDetailsSelector to Account.ts and reportMetadataSelector (renamed to pendingChatMembersSelector) to ReportMetaData.ts. Add unit tests for all new selectors including Network selectors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski · 2026-02-27T13:42:43Z

ah yes my bad, thanks for spotting this one! Adding now

rlinoz

Tests well!

github-actions · 2026-02-27T15:17:41Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-27T15:22:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83560.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2bc86e9-44accfa-e3c56d96f34f056e6aa026be4b5b58e47ff3b64d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2bc86e9-44accfa-0d6e5a599c317dd54c88fba8439bfcb320ec9d2f/index.html

Web 🕸️
https://83560.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:03:38Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:18:26Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:08:47Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned adhorodyski Feb 26, 2026

adhorodyski force-pushed the decompose-findings-4 branch from a63150d to 0c7fb17 Compare February 26, 2026 11:59

adhorodyski and others added 6 commits February 26, 2026 14:55

Reuse HeaderLoadingBar in MoneyReportHeader and MoneyRequestHeader to…

a22f3d2

… isolate queue re-renders Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Narrow Network subscriptions in MoneyReportHeader and MoneyRequestHea…

423d69e

…der with selector Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge exfy/main: resolve conflict in HeaderView.tsx

67a719d

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski changed the title ~~[No QA] Move isComposerFullSize Onyx subscription into ReportFooter~~ Decompose ReportScreen core subcomponents Feb 26, 2026

adhorodyski marked this pull request as ready for review February 26, 2026 16:23

adhorodyski requested review from a team as code owners February 26, 2026 16:23

melvin-bot bot requested review from shubham1206agra and trjExpensify and removed request for a team February 26, 2026 16:23

melvin-bot bot removed the request for review from a team February 26, 2026 16:23

Fix canEvict error in useParentReportAction when parentReportID is un…

0cc622e

…defined

mountiny requested review from ShridharGoel and removed request for shubham1206agra February 26, 2026 20:46

mountiny reviewed Feb 26, 2026

View reviewed changes

src/pages/inbox/HeaderView.tsx Outdated Show resolved Hide resolved

src/selectors/Network.ts Show resolved Hide resolved

ShridharGoel reviewed Feb 26, 2026

View reviewed changes

src/pages/inbox/ReportScreen.tsx Show resolved Hide resolved

src/pages/inbox/HeaderView.tsx Show resolved Hide resolved

Merge branch 'Expensify:main' into decompose-findings-4

abf0deb

add missing react import

66bf420

rlinoz approved these changes Feb 27, 2026

View reviewed changes

ShridharGoel approved these changes Feb 27, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz February 27, 2026 14:51

rlinoz approved these changes Feb 27, 2026

View reviewed changes

rlinoz merged commit 2bc86e9 into Expensify:main Feb 27, 2026
30 of 31 checks passed

adhorodyski deleted the decompose-findings-4 branch February 27, 2026 14:53

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

ShridharGoel mentioned this pull request Mar 4, 2026

[Metrics] Improve Open Report Performance #77173

Open

rlinoz mentioned this pull request Mar 4, 2026

[Due for payment 2026-03-11] Decompose ReportScreen core subcomponents #84150

Closed

Conversation

adhorodyski commented Feb 26, 2026 • edited by rlinoz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 26, 2026

Uh oh!

adhorodyski commented Feb 26, 2026

Uh oh!

codecov bot commented Feb 26, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

ShridharGoel commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhorodyski commented Feb 27, 2026

Uh oh!

ShridharGoel commented Feb 27, 2026

Uh oh!

ShridharGoel commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

adhorodyski commented Feb 27, 2026

Uh oh!

ShridharGoel commented Feb 27, 2026

Uh oh!

adhorodyski commented Feb 27, 2026

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adhorodyski commented Feb 26, 2026 •

edited by rlinoz

Loading

codecov bot commented Feb 26, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Feb 26, 2026 •

edited

Loading

ShridharGoel commented Feb 26, 2026 •

edited

Loading

ShridharGoel commented Feb 27, 2026 •

edited

Loading